From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#13387: emacsclient -t suspends emacs Date: Thu, 10 Jan 2013 02:04:25 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1357802715 15074 80.91.229.3 (10 Jan 2013 07:25:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 10 Jan 2013 07:25:15 +0000 (UTC) Cc: Paul Eggert To: 13387@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 10 08:25:33 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TtCVy-0006y2-NM for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Jan 2013 08:25:26 +0100 Original-Received: from localhost ([::1]:47451 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtCVi-0006Ua-CV for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Jan 2013 02:25:10 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:42570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtCVe-0006Rj-CR for bug-gnu-emacs@gnu.org; Thu, 10 Jan 2013 02:25:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtCVb-0004ED-E3 for bug-gnu-emacs@gnu.org; Thu, 10 Jan 2013 02:25:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35804) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtCVb-0004E5-AM for bug-gnu-emacs@gnu.org; Thu, 10 Jan 2013 02:25:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TtCVa-0000Yu-MI for bug-gnu-emacs@gnu.org; Thu, 10 Jan 2013 02:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dan Nicolaescu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Jan 2013 07:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13387 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13387-submit@debbugs.gnu.org id=B13387.13578026652111 (code B ref 13387); Thu, 10 Jan 2013 07:25:02 +0000 Original-Received: (at 13387) by debbugs.gnu.org; 10 Jan 2013 07:24:25 +0000 Original-Received: from localhost ([127.0.0.1]:52584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TtCUx-0000Xy-Lg for submit@debbugs.gnu.org; Thu, 10 Jan 2013 02:24:25 -0500 Original-Received: from fencepost.gnu.org ([208.118.235.10]:46579 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TtCUt-0000Xp-90 for 13387@debbugs.gnu.org; Thu, 10 Jan 2013 02:24:20 -0500 Original-Received: from dann by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TtCBd-0005nL-5y; Thu, 10 Jan 2013 02:04:25 -0500 In-Reply-To: (Dan Nicolaescu's message of "Tue, 08 Jan 2013 12:09:08 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:69556 Archived-At: Dan Nicolaescu writes: > With the current trunk: > > emacs -Q & > M-x server-start RET > and from the same terminal do: > emacsclient -t > > This results in: > [1] + Suspended (tty output) emacs -Q > > This is a regression, it works just fine in 24.1 The commit that caused this is 110801. This hunk looks suspicious: @@ -1286,11 +1282,7 @@ child_setup (int in, int out, int err, c if (err != in && err != out) emacs_close (err); -#if defined HAVE_SETPGID || ! (defined USG && defined SETPGRP_RELEASES_CTTY) - setpgid (pid, pid); -#endif - - /* setpgrp_of_tty is incorrect here; it uses input_fd. */ + setpgid (0, 0); tcsetpgrp (0, pid); /* execvp does not accept an environment arg so the only way it replaces setpgid (pid, pid) with setpgid (0, 0) on GNU/Linux.