unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@gnu.org>
To: Kim Storm <storm@cua.dk>
Cc: 11191@debbugs.gnu.org, Chong Yidong <cyd@gnu.org>
Subject: bug#11191: C-x C-x does not activate the selection anymore with cua-selection-mode
Date: Thu, 12 Apr 2012 23:13:53 -0400	[thread overview]
Message-ID: <yxq7gxk9vda.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <4F831328.5040303@cua.dk> (Kim Storm's message of "Mon, 09 Apr 2012 18:49:44 +0200")

Kim Storm <storm@cua.dk> writes:

> On 04/09/2012 04:16 PM, Dan Nicolaescu wrote:
>> You might want to do something different for cua-mode vs
>> cua-selection-mode (where C-x C-x has no other problems).
>>
>
> You are right -- maybe this version suits all:
>
> (defun cua-exchange-point-and-mark (arg)
>   "Exchanges point and mark.
>
> Don't activate the mark if `cua-enable-cua-keys` is non-nil.
> Just activate the mark if a prefix argument is given.
>
> See also `exchange-point-and-mark'."
>   (interactive "P")
>   (if cua-enable-cua-keys
>       (if arg
>       (setq mark-active t)
>     (let (mark-active)
>       (exchange-point-and-mark)
>       (if cua--rectangle
>           (cua--rectangle-corner 0))))
>     (exchange-point-and-mark arg)))
>
> Would someone pls. commit this change.

This works fine.

Yidong, I think this can go in whatever branch will be used for 24.1.
(Sorry, I can't check it in myself).



> Here is a change log entry:
>
>      * emulation/cua-base.el (cua-exchange-point-and-mark):
>      Fallback to exchange-point-and-mark when cua-enable-cua-keys is nil.
>
> Then you can also close bug #6199
>
> Thanks
> Kim





  reply	other threads:[~2012-04-13  3:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-07  3:27 bug#11191: C-x C-x does not activate the selection anymore with cua-selection-mode Dan Nicolaescu
2012-04-08 13:18 ` Chong Yidong
2012-04-09  5:50   ` Dan Nicolaescu
2012-04-09 11:00     ` Kim Storm
2012-04-09 11:06       ` Lennart Borgman
2012-04-09 14:16       ` Dan Nicolaescu
2012-04-09 16:49         ` Kim Storm
2012-04-13  3:13           ` Dan Nicolaescu [this message]
2012-04-13  7:10             ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yxq7gxk9vda.fsf@fencepost.gnu.org \
    --to=dann@gnu.org \
    --cc=11191@debbugs.gnu.org \
    --cc=cyd@gnu.org \
    --cc=storm@cua.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).