From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#11191: C-x C-x does not activate the selection anymore with cua-selection-mode Date: Thu, 12 Apr 2012 23:13:53 -0400 Message-ID: References: <87vclapdk6.fsf@gnu.org> <4F82C14D.7000100@cua.dk> <4F831328.5040303@cua.dk> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1334286894 29891 80.91.229.3 (13 Apr 2012 03:14:54 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 13 Apr 2012 03:14:54 +0000 (UTC) Cc: 11191@debbugs.gnu.org, Chong Yidong To: Kim Storm Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 13 05:14:52 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SIWyK-0007qI-Dp for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Apr 2012 05:14:52 +0200 Original-Received: from localhost ([::1]:57427 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SIWyJ-00031D-Ma for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Apr 2012 23:14:51 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SIWyG-00030x-Nz for bug-gnu-emacs@gnu.org; Thu, 12 Apr 2012 23:14:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SIWyE-0004YH-Qv for bug-gnu-emacs@gnu.org; Thu, 12 Apr 2012 23:14:48 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SIWyE-0004Y9-NQ for bug-gnu-emacs@gnu.org; Thu, 12 Apr 2012 23:14:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SIWzS-000864-6a for bug-gnu-emacs@gnu.org; Thu, 12 Apr 2012 23:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dan Nicolaescu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Apr 2012 03:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11191 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11191-submit@debbugs.gnu.org id=B11191.133428691431057 (code B ref 11191); Fri, 13 Apr 2012 03:16:02 +0000 Original-Received: (at 11191) by debbugs.gnu.org; 13 Apr 2012 03:15:14 +0000 Original-Received: from localhost ([127.0.0.1]:55393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIWyg-00084p-9V for submit@debbugs.gnu.org; Thu, 12 Apr 2012 23:15:14 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:59403) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIWyd-00084e-2e for 11191@debbugs.gnu.org; Thu, 12 Apr 2012 23:15:12 -0400 Original-Received: from dann by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1SIWxN-0003nH-7w; Thu, 12 Apr 2012 23:13:53 -0400 In-Reply-To: <4F831328.5040303@cua.dk> (Kim Storm's message of "Mon, 09 Apr 2012 18:49:44 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:58967 Archived-At: Kim Storm writes: > On 04/09/2012 04:16 PM, Dan Nicolaescu wrote: >> You might want to do something different for cua-mode vs >> cua-selection-mode (where C-x C-x has no other problems). >> > > You are right -- maybe this version suits all: > > (defun cua-exchange-point-and-mark (arg) > "Exchanges point and mark. > > Don't activate the mark if `cua-enable-cua-keys` is non-nil. > Just activate the mark if a prefix argument is given. > > See also `exchange-point-and-mark'." > (interactive "P") > (if cua-enable-cua-keys > (if arg > (setq mark-active t) > (let (mark-active) > (exchange-point-and-mark) > (if cua--rectangle > (cua--rectangle-corner 0)))) > (exchange-point-and-mark arg))) > > Would someone pls. commit this change. This works fine. Yidong, I think this can go in whatever branch will be used for 24.1. (Sorry, I can't check it in myself). > Here is a change log entry: > > * emulation/cua-base.el (cua-exchange-point-and-mark): > Fallback to exchange-point-and-mark when cua-enable-cua-keys is nil. > > Then you can also close bug #6199 > > Thanks > Kim