From: Michael Albinus <michael.albinus@gmx.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>, 9803@debbugs.gnu.org
Subject: bug#9803: [PATCH] Add ERT option to skip test
Date: Wed, 23 Oct 2013 14:21:59 +0200 [thread overview]
Message-ID: <yqpgy55kgot4.fsf@gmx.de> (raw)
In-Reply-To: <87a9i1af3d.fsf@gmx.de> (Michael Albinus's message of "Tue, 22 Oct 2013 10:23:50 +0200")
Michael Albinus <michael.albinus@gmx.de> writes:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>> You want to use either `cl-flet' or `cl-macrolet', depending on whether
>> you want to define skip-if as a local function or a local macro.
>
> `cl-macrolet' does it, thanks! I will also handle `should', `should-not'
> and `should-error' this way.
Well, it works only for tests which use `should', `should-not' and
`should-error' in the body of `ert-deftest'. Unfortunately, there are
several tests which use helper functions, calling `should' and
friends. For those tests it doesn't work this way.
Since this is not related to the `skip-unless' check, I will commit just
a patch introducing this macro. Changing the scope of `should',
`should-not' and `should-error' could be fixed later.
>> Stefan
Best regards, Michael.
next prev parent reply other threads:[~2013-10-23 12:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 3:42 bug#9803: Add ERT option to skip test Glenn Morris
2013-07-04 18:40 ` Michael Albinus
2013-10-18 13:37 ` bug#9803: [PATCH] " Michael Albinus
2013-10-19 1:02 ` Glenn Morris
2013-10-19 2:12 ` Stefan Monnier
2013-10-19 6:44 ` Michael Albinus
2013-10-19 6:44 ` Michael Albinus
2013-10-20 2:02 ` Glenn Morris
2013-10-20 14:09 ` Michael Albinus
2013-10-21 15:08 ` Michael Albinus
2013-10-21 16:53 ` Stefan Monnier
2013-10-21 17:02 ` Michael Albinus
2013-10-21 19:23 ` Stefan Monnier
2013-10-22 8:23 ` Michael Albinus
2013-10-23 12:21 ` Michael Albinus [this message]
2013-10-24 7:46 ` Michael Albinus
2013-10-24 8:00 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yqpgy55kgot4.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=9803@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).