From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#9803: [PATCH] Add ERT option to skip test Date: Wed, 23 Oct 2013 14:21:59 +0200 Message-ID: References: <87vc0usnrj.fsf@gmx.de> <87txgcyqyk.fsf@gmx.de> <87ppqywtjk.fsf@gmx.de> <87y55m36d3.fsf@gmx.de> <87a9i1af3d.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1382530997 4045 80.91.229.3 (23 Oct 2013 12:23:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 23 Oct 2013 12:23:17 +0000 (UTC) To: Stefan Monnier , 9803@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 23 14:23:20 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VYxT5-0007EQ-E1 for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Oct 2013 14:23:19 +0200 Original-Received: from localhost ([::1]:49142 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYxT5-00044V-0e for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Oct 2013 08:23:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYxSw-000410-Mv for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2013 08:23:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VYxSo-0000fi-M6 for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2013 08:23:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51485) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYxSo-0000fY-IU for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2013 08:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VYxSo-0004v2-6u for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2013 08:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Oct 2013 12:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9803 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9803-submit@debbugs.gnu.org id=B9803.138253093118830 (code B ref 9803); Wed, 23 Oct 2013 12:23:02 +0000 Original-Received: (at 9803) by debbugs.gnu.org; 23 Oct 2013 12:22:11 +0000 Original-Received: from localhost ([127.0.0.1]:37270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VYxRy-0004te-5e for submit@debbugs.gnu.org; Wed, 23 Oct 2013 08:22:10 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:59995) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VYxRv-0004t8-8p for 9803@debbugs.gnu.org; Wed, 23 Oct 2013 08:22:08 -0400 Original-Received: from uw001237 ([84.135.116.81]) by mail.gmx.com (mrgmx102) with ESMTPA (Nemesis) id 0MW9TR-1VEtJx2Kc5-00XJ6n for <9803@debbugs.gnu.org>; Wed, 23 Oct 2013 14:22:01 +0200 In-Reply-To: <87a9i1af3d.fsf@gmx.de> (Michael Albinus's message of "Tue, 22 Oct 2013 10:23:50 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Provags-ID: V03:K0:CfV6zS6mqCBv6wJ25aqr4FdLiZBnBKFFqj3TE105g5IdIJc+35O Sz1SIH+caCDbyA1yIxEwYNMNDf9eMllpKYROQDkc5E/haTXjCKyG6KqjieFn3n0gvol1RvW LHdTqrJGMbuHhlnnbtQkqx52VGy5B894vG+K9h4KiDMHr0hTvqc6KC+mNfW/WuMaOD4XNtB popAvAz0vn2nqmF15ZobA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:79531 Archived-At: Michael Albinus writes: > Stefan Monnier writes: > >> You want to use either `cl-flet' or `cl-macrolet', depending on whether >> you want to define skip-if as a local function or a local macro. > > `cl-macrolet' does it, thanks! I will also handle `should', `should-not' > and `should-error' this way. Well, it works only for tests which use `should', `should-not' and `should-error' in the body of `ert-deftest'. Unfortunately, there are several tests which use helper functions, calling `should' and friends. For those tests it doesn't work this way. Since this is not related to the `skip-unless' check, I will commit just a patch introducing this macro. Changing the scope of `should', `should-not' and `should-error' could be fixed later. >> Stefan Best regards, Michael.