From: Andrea Corallo <acorallo@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Mattias Engdegård" <mattias.engdegard@gmail.com>, 66615@debbugs.gnu.org
Subject: bug#66615: 30.0.50; Inconsistent 'number-or-marker' type definition in the cl- machinery
Date: Thu, 19 Oct 2023 17:24:23 -0400 [thread overview]
Message-ID: <yp1lebyl308.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <jwvbkcu8zul.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 19 Oct 2023 10:22:10 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>>> - There is a `number-or-marker-p` primitive and `cl-typep` doesn't know
>>>> how to use it for `(or number marker)`.
>>> Well we could just remove 'number-or-marker-p' 😃
>
> Indeed, or we could teach `cl-typep` how to make use of it.
>
>>> I see your point, actually my main drive is to make the situation more
>>> coherent so I'm unblocked in the first place, just the method
>>> specializer functionality is a blocker for removing 'number-or-marker'.
>
> That's what I had understood, and indeed there were some loose ends there.
>
>> Okay with a567faf4c2b I added 'number-or-marker' where it was missing.
>
> Thanks. I also added corresponding `integer-or-marker`.
Hi Stefan thanks,
I've to question now the following entry introduced in
`cl--typeof-types' for correctness:
(integer number integer-or-marker number-or-marker atom)
The doc says :
Each element has the form (TYPE . SUPERTYPES) where TYPE is one of
the symbols returned by ‘type-of’, and SUPERTYPES is the list of its
supertypes from the most specific to least specific.
And indeed not every 'number' is an 'integer-or-marker'.
I suspect that's the reason why this commit introduces few failures in
the native-comp testsuite.
At this point of the night I'm not sure if and how 'integer-or-marker'
can be added correctly to this representation.
Best Regards
Andrea
next prev parent reply other threads:[~2023-10-19 21:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 17:59 bug#66615: 30.0.50; Inconsistent 'number-or-marker' type definition in the cl- machinery Andrea Corallo
2023-10-18 18:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-19 8:56 ` Andrea Corallo
2023-10-19 12:02 ` Andrea Corallo
2023-10-19 14:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-19 21:24 ` Andrea Corallo [this message]
2023-10-19 22:34 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-20 9:05 ` Andrea Corallo
2023-10-20 13:45 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-20 15:42 ` Andrea Corallo
2023-10-20 20:51 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-22 7:03 ` Andrea Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yp1lebyl308.fsf@fencepost.gnu.org \
--to=acorallo@gnu.org \
--cc=66615@debbugs.gnu.org \
--cc=mattias.engdegard@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).