unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Andrea Corallo <acorallo@gnu.org>
Cc: 66615@debbugs.gnu.org, mattias.engdegard@gmail.com
Subject: bug#66615: 30.0.50; Inconsistent 'number-or-marker' type definition in the cl- machinery
Date: Wed, 18 Oct 2023 14:30:38 -0400	[thread overview]
Message-ID: <jwvsf67pz89.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <yp134y7zu9y.fsf@fencepost.gnu.org> (Andrea Corallo's message of "Wed, 18 Oct 2023 13:59:21 -0400")

> My question is, why do we consider 'number-or-marker' in the first place
> a type if we support the or syntax in `cl-typep' like
> (cl-typep 3 '(or marker number)) ?

I'm not sure I can give a good answer in general, but I can tell you
some reasons that explain some of what we see:

- There is a `number-or-marker-p` primitive and `cl-typep` doesn't know
  how to use it for `(or number marker)`.
- method specializers (currently) can't be `(or number marker)` but can be
  `number-or-marker`.

> I'd like to fix this inconsistency in order to progress with my
> development, originally I worked out the attached patch but I now
> suspect that (unless there's a specific reason) we should just remove
> 'number-or-marker' as a type entirely instead.

I'd lean towards keeping it :-)

> PS also I think we have a similar issue/question with
> 'integer-or-marker'.

Yup.


        Stefan






  reply	other threads:[~2023-10-18 18:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-18 17:59 bug#66615: 30.0.50; Inconsistent 'number-or-marker' type definition in the cl- machinery Andrea Corallo
2023-10-18 18:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-10-19  8:56   ` Andrea Corallo
2023-10-19 12:02     ` Andrea Corallo
2023-10-19 14:22       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-19 21:24         ` Andrea Corallo
2023-10-19 22:34           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-20  9:05             ` Andrea Corallo
2023-10-20 13:45               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-20 15:42                 ` Andrea Corallo
2023-10-20 20:51                   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-22  7:03                     ` Andrea Corallo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvsf67pz89.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=66615@debbugs.gnu.org \
    --cc=acorallo@gnu.org \
    --cc=mattias.engdegard@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).