From: Andrea Corallo <akrl@sdf.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: Michael Heerdegen <michael_heerdegen@web.de>,
51140@debbugs.gnu.org, Robert Irelan <rirelan@gmail.com>
Subject: bug#51140: 28.0.50; cl-letf appears not to work with native-comp (at least for process-exit-status and other builtins)
Date: Tue, 30 Nov 2021 16:22:23 +0000 [thread overview]
Message-ID: <xjftuft1um8.fsf@ma.sdf.org> (raw)
In-Reply-To: <CADwFkmnHXVbuF3wxe_v9xSL00QjciNjWvioXLSxt=L2AQ9t_ZQ@mail.gmail.com> (Stefan Kangas's message of "Mon, 18 Oct 2021 22:31:32 -0700")
Stefan Kangas <stefan@marxist.se> writes:
> Robert Irelan <rirelan@gmail.com> writes:
>
>> (defun +ivy--always-return-zero-exit-code-a (fn &rest args)
>> (let ((process-exit-status-orig
>> (symbol-function 'process-exit-status)))
>> (cl-letf* (((symbol-function 'process-exit-status)
>> (lambda (_proc)
>> (let ((code (funcall process-exit-status-orig _proc)))
>> (if (= code 2) 0 code)))))
>> (apply fn args)))
>> (advice-add #'counsel-rg :around #'+ivy--always-return-zero-exit-code-a)
>
> Thanks, copying in Andrea here.
I tried to reproduce a reduced version of this. On current master
starting emacs -Q I native compiled and loaded the following:
test.el =======================================
;;; -*- lexical-binding: t; -*-
(defun foo ())
(defun bar (fn &rest args)
(let ((process-exit-status-orig
(symbol-function 'process-exit-status)))
(cl-letf* (((symbol-function 'process-exit-status)
(lambda (proc)
(let ((code (funcall process-exit-status-orig proc)))
(if (= code 2) 0 code)))))
(apply fn args))))
=======================================
Then I've advised `foo' as follow
(advice-add #'foo :around #'bar)
After that running `foo' triggers the compilation of the trampoline for
`process-exit-status' but with no errors.
Robert could you try this reduced recipe and see if it works or not on
your setup?
If it works we need another a precise description on how to trigger this
bug starting from emacs -Q.
Thanks
Andrea
next prev parent reply other threads:[~2021-11-30 16:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 22:37 bug#51140: 28.0.50; cl-letf appears not to work with native-comp (at least for process-exit-status and other builtins) Robert Irelan
2021-10-12 2:30 ` Michael Heerdegen
2021-10-12 2:40 ` Robert Irelan
2021-10-12 2:50 ` Michael Heerdegen
2021-10-12 2:57 ` Robert Irelan
2021-10-12 22:35 ` Stefan Kangas
2021-10-13 5:13 ` Robert Irelan
2021-10-19 5:31 ` Stefan Kangas
2021-11-30 16:22 ` Andrea Corallo [this message]
2022-09-12 11:49 ` Lars Ingebrigtsen
2022-09-14 3:22 ` Robert Irelan
2022-09-14 12:41 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xjftuft1um8.fsf@ma.sdf.org \
--to=akrl@sdf.org \
--cc=51140@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
--cc=rirelan@gmail.com \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).