From: Lars Ingebrigtsen <larsi@gnus.org>
To: Robert Irelan <rirelan@gmail.com>
Cc: Michael Heerdegen <michael_heerdegen@web.de>,
51140@debbugs.gnu.org, Stefan Kangas <stefan@marxist.se>,
Andrea Corallo <akrl@sdf.org>
Subject: bug#51140: 28.0.50; cl-letf appears not to work with native-comp (at least for process-exit-status and other builtins)
Date: Mon, 12 Sep 2022 13:49:18 +0200 [thread overview]
Message-ID: <87y1uo7qyp.fsf@gnus.org> (raw)
In-Reply-To: <CAJUyYjotMKpDZ6qB2GbnKtKdqnvLhnDs9ZrUwpRX0=_rwWSQmg@mail.gmail.com> (Robert Irelan's message of "Tue, 12 Oct 2021 22:13:12 -0700")
Robert Irelan <rirelan@gmail.com> writes:
> (defun +ivy--always-return-zero-exit-code-a (fn &rest args)
> (let ((process-exit-status-orig
> (symbol-function 'process-exit-status)))
> (cl-letf* (((symbol-function 'process-exit-status)
> (lambda (_proc)
> (let ((code (funcall process-exit-status-orig _proc)))
> (if (= code 2) 0 code)))))
> (apply fn args)))
> (advice-add #'counsel-rg :around #'+ivy--always-return-zero-exit-code-a)
(I'm going through old bug reports that unfortunately weren't resolved
at the time.)
Andrea was apparently unable to reproduce the problem here on the
current "master" branch. Robert, would it be possible for you to test
this on that branch and see whether this works better there?
next prev parent reply other threads:[~2022-09-12 11:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 22:37 bug#51140: 28.0.50; cl-letf appears not to work with native-comp (at least for process-exit-status and other builtins) Robert Irelan
2021-10-12 2:30 ` Michael Heerdegen
2021-10-12 2:40 ` Robert Irelan
2021-10-12 2:50 ` Michael Heerdegen
2021-10-12 2:57 ` Robert Irelan
2021-10-12 22:35 ` Stefan Kangas
2021-10-13 5:13 ` Robert Irelan
2021-10-19 5:31 ` Stefan Kangas
2021-11-30 16:22 ` Andrea Corallo
2022-09-12 11:49 ` Lars Ingebrigtsen [this message]
2022-09-14 3:22 ` Robert Irelan
2022-09-14 12:41 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1uo7qyp.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=51140@debbugs.gnu.org \
--cc=akrl@sdf.org \
--cc=michael_heerdegen@web.de \
--cc=rirelan@gmail.com \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).