bug#50315: 28.0.50; Emacs with native-complication failed with latest commit (after 6767e556) in Windows

bug#50315: 28.0.50; Emacs with native-complication failed with latest commit (after 6767e556) in Windows

[Kiên Nguyễn Quang]

[-- Attachment #1.1: Type: text/plain, Size: 395 bytes --]

Build error failure:

C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.3.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
comp.o: in function `define_cast_from_to':
D:/a/emacs-build/emacs-build/git/master/src/comp.c:3159: undefined
reference to `gcc_jit_context_new_cast'
...

This is due to `gcc_jit_context_new_cast' is not loaded from dll.
The proposed fix is attached.

Best regards,
Kien

[-- Attachment #1.2: Type: text/html, Size: 614 bytes --]

[-- Attachment #2: 0001-comp.c-add-the-dll-loader-for-gcc_jit_context_new_ca.patch --]
[-- Type: application/octet-stream, Size: 2379 bytes --]

From d049c395f3039bf10a4cb493c50d18e34e32d737 Mon Sep 17 00:00:00 2001
From: Kien Nguyen <kien.n.quang@gmail.com>
Date: Wed, 1 Sep 2021 18:56:51 +0900
Subject: [PATCH] comp.c: add the dll loader for gcc_jit_context_new_cast

---
 src/comp.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/comp.c b/src/comp.c
index 3ea2836560..7e21331e66 100644
--- a/src/comp.c
+++ b/src/comp.c
@@ -71,6 +71,7 @@
 #undef gcc_jit_context_new_binary_op
 #undef gcc_jit_context_new_call
 #undef gcc_jit_context_new_call_through_ptr
+#undef gcc_jit_context_new_cast
 #undef gcc_jit_context_new_comparison
 #undef gcc_jit_context_new_field
 #undef gcc_jit_context_new_function
@@ -176,6 +177,9 @@ DEF_DLL_FN (gcc_jit_rvalue *, gcc_jit_context_new_call,
 DEF_DLL_FN (gcc_jit_rvalue *, gcc_jit_context_new_call_through_ptr,
             (gcc_jit_context *ctxt, gcc_jit_location *loc,
              gcc_jit_rvalue *fn_ptr, int numargs, gcc_jit_rvalue **args));
+DEF_DLL_FN (gcc_jit_rvalue *, gcc_jit_context_new_cast,
+            (gcc_jit_context *ctxt, gcc_jit_location *loc,
+             gcc_jit_rvalue *rvalue, gcc_jit_type *type));
 DEF_DLL_FN (gcc_jit_rvalue *, gcc_jit_context_new_comparison,
             (gcc_jit_context *ctxt, gcc_jit_location *loc,
              enum gcc_jit_comparison op, gcc_jit_rvalue *a, gcc_jit_rvalue *b));
@@ -288,6 +292,7 @@ init_gccjit_functions (void)
   LOAD_DLL_FN (library, gcc_jit_context_new_binary_op);
   LOAD_DLL_FN (library, gcc_jit_context_new_call);
   LOAD_DLL_FN (library, gcc_jit_context_new_call_through_ptr);
+  LOAD_DLL_FN (library, gcc_jit_context_new_cast);
   LOAD_DLL_FN (library, gcc_jit_context_new_comparison);
   LOAD_DLL_FN (library, gcc_jit_context_new_field);
   LOAD_DLL_FN (library, gcc_jit_context_new_function);
@@ -358,6 +363,7 @@ #define gcc_jit_context_new_array_type fn_gcc_jit_context_new_array_type
 #define gcc_jit_context_new_binary_op fn_gcc_jit_context_new_binary_op
 #define gcc_jit_context_new_call fn_gcc_jit_context_new_call
 #define gcc_jit_context_new_call_through_ptr fn_gcc_jit_context_new_call_through_ptr
+#define gcc_jit_context_new_cast fn_gcc_jit_context_new_cast
 #define gcc_jit_context_new_comparison fn_gcc_jit_context_new_comparison
 #define gcc_jit_context_new_field fn_gcc_jit_context_new_field
 #define gcc_jit_context_new_function fn_gcc_jit_context_new_function
-- 
2.32.0.windows.2

bug#50315: 28.0.50; Emacs with native-complication failed with latest commit (after 6767e556) in Windows

[Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Kiên Nguyễn Quang <kien.n.quang@gmail.com> writes:

> Build error failure:
>
> C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.3.0/../../../../x86_64-w64-mingw32/bin/ld.exe: comp.o: in function
> `define_cast_from_to':
> D:/a/emacs-build/emacs-build/git/master/src/comp.c:3159: undefined reference to `gcc_jit_context_new_cast'
> ...
>
> This is due to `gcc_jit_context_new_cast' is not loaded from dll.
> The proposed fix is attached.
>
> Best regards,
> Kien

Hi Kiên,

thanks for working on this!

Do you have the copyright assigment paperwork done?  Also paches should
come with a changelog entry (see the CONTRIBUTE file).

Thanks!

  Andrea

bug#50315: 28.0.50; Emacs with native-complication failed with latest commit (after 6767e556) in Windows

[Kiên Nguyễn Quang]

[-- Attachment #1.1: Type: text/plain, Size: 909 bytes --]

I have the copyright assignment paperwork done.
Here is the new patch with the changelog entry

On Wed, Sep 1, 2021 at 9:31 PM Andrea Corallo <akrl@sdf.org> wrote:

> Kiên Nguyễn Quang <kien.n.quang@gmail.com> writes:
>
> > Build error failure:
> >
> >
> C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.3.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
> comp.o: in function
> > `define_cast_from_to':
> > D:/a/emacs-build/emacs-build/git/master/src/comp.c:3159: undefined
> reference to `gcc_jit_context_new_cast'
> > ...
> >
> > This is due to `gcc_jit_context_new_cast' is not loaded from dll.
> > The proposed fix is attached.
> >
> > Best regards,
> > Kien
>
> Hi Kiên,
>
> thanks for working on this!
>
> Do you have the copyright assigment paperwork done?  Also paches should
> come with a changelog entry (see the CONTRIBUTE file).
>
> Thanks!
>
>   Andrea
>

[-- Attachment #1.2: Type: text/html, Size: 1372 bytes --]

[-- Attachment #2: 0001-comp.c-add-the-dll-loader-for-gcc_jit_context_new_ca.patch --]
[-- Type: application/octet-stream, Size: 2454 bytes --]

From d049c395f3039bf10a4cb493c50d18e34e32d737 Mon Sep 17 00:00:00 2001
From: Kien Nguyen <kien.n.quang@gmail.com>
Date: Wed, 1 Sep 2021 18:56:51 +0900
Subject: [PATCH] Add a dll loader entry for gcc_jit_context_new_cast

* src/comp.c: add a dll loader entry for gcc_jit_context_new_cast (bug#50315)

---
 src/comp.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/comp.c b/src/comp.c
index 3ea2836560..7e21331e66 100644
--- a/src/comp.c
+++ b/src/comp.c
@@ -71,6 +71,7 @@
 #undef gcc_jit_context_new_binary_op
 #undef gcc_jit_context_new_call
 #undef gcc_jit_context_new_call_through_ptr
+#undef gcc_jit_context_new_cast
 #undef gcc_jit_context_new_comparison
 #undef gcc_jit_context_new_field
 #undef gcc_jit_context_new_function
@@ -176,6 +177,9 @@ DEF_DLL_FN (gcc_jit_rvalue *, gcc_jit_context_new_call,
 DEF_DLL_FN (gcc_jit_rvalue *, gcc_jit_context_new_call_through_ptr,
             (gcc_jit_context *ctxt, gcc_jit_location *loc,
              gcc_jit_rvalue *fn_ptr, int numargs, gcc_jit_rvalue **args));
+DEF_DLL_FN (gcc_jit_rvalue *, gcc_jit_context_new_cast,
+            (gcc_jit_context *ctxt, gcc_jit_location *loc,
+             gcc_jit_rvalue *rvalue, gcc_jit_type *type));
 DEF_DLL_FN (gcc_jit_rvalue *, gcc_jit_context_new_comparison,
             (gcc_jit_context *ctxt, gcc_jit_location *loc,
              enum gcc_jit_comparison op, gcc_jit_rvalue *a, gcc_jit_rvalue *b));
@@ -288,6 +292,7 @@ init_gccjit_functions (void)
   LOAD_DLL_FN (library, gcc_jit_context_new_binary_op);
   LOAD_DLL_FN (library, gcc_jit_context_new_call);
   LOAD_DLL_FN (library, gcc_jit_context_new_call_through_ptr);
+  LOAD_DLL_FN (library, gcc_jit_context_new_cast);
   LOAD_DLL_FN (library, gcc_jit_context_new_comparison);
   LOAD_DLL_FN (library, gcc_jit_context_new_field);
   LOAD_DLL_FN (library, gcc_jit_context_new_function);
@@ -358,6 +363,7 @@ #define gcc_jit_context_new_array_type fn_gcc_jit_context_new_array_type
 #define gcc_jit_context_new_binary_op fn_gcc_jit_context_new_binary_op
 #define gcc_jit_context_new_call fn_gcc_jit_context_new_call
 #define gcc_jit_context_new_call_through_ptr fn_gcc_jit_context_new_call_through_ptr
+#define gcc_jit_context_new_cast fn_gcc_jit_context_new_cast
 #define gcc_jit_context_new_comparison fn_gcc_jit_context_new_comparison
 #define gcc_jit_context_new_field fn_gcc_jit_context_new_field
 #define gcc_jit_context_new_function fn_gcc_jit_context_new_function
-- 
2.32.0.windows.2

bug#50315: 28.0.50; Emacs with native-complication failed with latest commit (after 6767e556) in Windows

[Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Kiên Nguyễn Quang <kien.n.quang@gmail.com> writes:

> I have the copyright assignment paperwork done.
> Here is the new patch with the changelog entry

Great, into master as c0243d9e82.

Thanks (closing this bug)

  Andrea