bug#42944: [feature/native-comp] Build fails with Guix/Nix: Symbol's value as variable is void: auto-save-list-file-prefix

bug#42944: [feature/native-comp] Build fails with Guix/Nix: Symbol's value as variable is void: auto-save-list-file-prefix

[m.j.lbach]

As of commit 8a931a97b8dd19a38d6f719f810280a07ba76438 the build fails
on nix:

make[1]: Leaving directory '/build/source/lib-src'
/nix/store/gd3nl6hcc8mzq8fmxdvl6czh3l0n4la5-coreutils-8.31/bin/install
-c  src/emacs "/nix/store/bx0wjfyvjlx0zc99xlzwa0q76fgmy1rr-emacs-gcc-
20200819.0/bin/`echo emacs-28.0.50 | sed 's,x,x,'`"
/nix/store/gd3nl6hcc8mzq8fmxdvl6czh3l0n4la5-coreutils-8.31/bin/install
-c -m 644 src/emacs.pdmp "/nix/store/bx0wjfyvjlx0zc99xlzwa0q76fgmy1rr-
emacs-gcc-20200819.0/libexec/emacs/28.0.50/x86_64-pc-linux-
gnu"/emacs.pdmp
chmod 755 "/nix/store/bx0wjfyvjlx0zc99xlzwa0q76fgmy1rr-emacs-gcc-
20200819.0/bin/`echo emacs-28.0.50 | sed 's,x,x,'`"
rm -f "/nix/store/bx0wjfyvjlx0zc99xlzwa0q76fgmy1rr-emacs-gcc-
20200819.0/bin/`echo emacs | sed 's,x,x,'`"
cd "/nix/store/bx0wjfyvjlx0zc99xlzwa0q76fgmy1rr-emacs-gcc-
20200819.0/bin" && ln -s "`echo emacs-28.0.50 | sed 's,x,x,'`" "`echo
emacs | sed 's,x,x,'`"
make -C lib-src maybe-blessmail
make[1]: Entering directory '/build/source/lib-src'
make[1]: Nothing to be done for 'maybe-blessmail'.
make[1]: Leaving directory '/build/source/lib-src'
find eln-cache -type f -exec
/nix/store/gd3nl6hcc8mzq8fmxdvl6czh3l0n4la5-coreutils-8.31/bin/install
-c -m 644 -D "{}" ""/nix/store/bx0wjfyvjlx0zc99xlzwa0q76fgmy1rr-emacs-
gcc-20200819.0/libexec/emacs/28.0.50/x86_64-pc-linux-gnu/"{}" \;
Symbol's value as variable is void: auto-save-list-file-prefix
builder for '/nix/store/sg8b2y9zz2n9fj1gk2mzh71k18izcdyh-emacs-gcc-
20200819.0.drv' failed with exit code 255
cannot build derivation '/nix/store/w8sp6xr9qkkf9kwms77vz9v76wgrw3wl-
emacsGccWrapped.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/304qc313r1icpk1xp6908q8bidh4di60-
emacsGccWrapped-with-packages-.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/v3q747lpsbigmydg4dic5hd5nymirc9g-
home-manager-path.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/lckdw9lr4g3p15acd9540fnc0yn7s0mv-
home-manager-generation.drv': 1 dependencies couldn't be built
error: build of '/nix/store/lckdw9lr4g3p15acd9540fnc0yn7s0mv-home-
manager-generation.drv' failed


and on guix:

starting phase `install-site-start'
Symbol’s value as variable is void: auto-save-list-file-prefix
command "/gnu/store/dwbadnkpjkk5wibvy32hzq6zi96if2r4-emacs-native-comp-
28.0.50-0.8a931a9/bin/emacs" "--quick" "--batch" "--eval=(progn (setq
byte-compile-debug t) (byte-recompile-directory (file-name-as-directory 
\"/gnu/store/dwbadnkpjkk5wibvy32hzq6zi96if2r4-emacs-native-comp-
28.0.50-0.8a931a9/share/emacs/site-lisp\") 0 1))" failed with status
255

bug#42944: [feature/native-comp] Build fails with Guix/Nix: Symbol's value as variable is void: auto-save-list-file-prefix

[Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors]

m.j.lbach@gmail.com writes:

> As of commit 8a931a97b8dd19a38d6f719f810280a07ba76438 the build fails
> on nix:

Hi thanks for the report, I've reverted 8a931a97b8.

What's going on is that hashing the eln based on the last mod time
simply breaks make install as the last modification time is not
preserved precisely.

I think we could work out the makefile to try to preserve that but I
believe is worth trying to hash using the .el file content and see if it
has a performance impact or not.  If viable I believe would be a more
robust solution.

I propose we hash like filename-path_hash-content_hash.eln so we can
clean-up the eln-cache folders when recompiling or when we want.

Could you please check in the meanwhile that is back working for you?

Thanks!

  Andrea

-- 
akrl@sdf.org

bug#42944: [feature/native-comp] Build fails with Guix/Nix: Symbol's value as variable is void: auto-save-list-file-prefix

[m.j.lbach]

Hi Andrea,

Thank you for the quick fix (and the explanation, as to why the
modification time based hashing fails)! I can't comment onto the time
penalty for hashing based on content, but it seems like a good trade-
off. I was able to compile successfully with the commit reverted. 

Thank you for your work on native compilation!

Best,
Michael
 
On Thu, 2020-08-20 at 10:58 +0000, Andrea Corallo wrote:
> m.j.lbach@gmail.com writes:
> 
> > As of commit 8a931a97b8dd19a38d6f719f810280a07ba76438 the build
> > fails
> > on nix:
> 
> Hi thanks for the report, I've reverted 8a931a97b8.
> 
> What's going on is that hashing the eln based on the last mod time
> simply breaks make install as the last modification time is not
> preserved precisely.
> 
> I think we could work out the makefile to try to preserve that but I
> believe is worth trying to hash using the .el file content and see if
> it
> has a performance impact or not.  If viable I believe would be a more
> robust solution.
> 
> I propose we hash like filename-path_hash-content_hash.eln so we can
> clean-up the eln-cache folders when recompiling or when we want.
> 
> Could you please check in the meanwhile that is back working for you?
> 
> Thanks!
> 
>   Andrea
> 

bug#42944: [feature/native-comp] Build fails with Guix/Nix: Symbol's value as variable is void: auto-save-list-file-prefix

[Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors]

m.j.lbach@gmail.com writes:

> Hi Andrea,
>
> Thank you for the quick fix (and the explanation, as to why the
> modification time based hashing fails)! I can't comment onto the time
> penalty for hashing based on content, but it seems like a good trade-
> off. I was able to compile successfully with the commit reverted. 
>
> Thank you for your work on native compilation!

Thanks! closing

  Andrea

-- 
akrl@sdf.org