unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Andrea Corallo <akrl@sdf.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: kahatlen@gmail.com, Lars Ingebrigtsen <larsi@gnus.org>,
	54437@debbugs.gnu.org
Subject: bug#54437: 28.0.92; command-modes returns nil for native compiled functions
Date: Sat, 19 Mar 2022 17:54:59 +0000	[thread overview]
Message-ID: <xjfmthlbzf0.fsf@ma.sdf.org> (raw)
In-Reply-To: <83fsneezor.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 19 Mar 2022 17:20:52 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Lars Ingebrigtsen <larsi@gnus.org>
>> Date: Sat, 19 Mar 2022 15:13:07 +0100
>> Cc: 54437@debbugs.gnu.org
>> 
>> Lars Ingebrigtsen <larsi@gnus.org> writes:
>> 
>> > Hm.  I tried that now, and I can now reproduce the problem.  Weird.
>> > I'll debug further.
>> 
>> I've now pushed a fix for this to Emacs 29.  A less invasive fix for
>> Emacs 28 might be nice, but I couldn't think of one, so I think we might
>> just have to say that command-modes + nativecomp just doesn't work in
>> Emacs 28.1.
>
> Thanks.
>
> Andrea, any thoughts?

Just had a look, the fix LGTM (thanks Lars!).

I just have a question for Lars, couldn't we just use and hash table to
map function-name -> modes?  Maybe this way the fix would be
considerably less invasive?

Thanks

  Andrea





  reply	other threads:[~2022-03-19 17:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-17 14:53 bug#54437: 28.0.92; command-modes returns nil for native compiled functions Knut Anders Hatlen
2022-03-17 16:29 ` Lars Ingebrigtsen
2022-03-17 16:44   ` Lars Ingebrigtsen
2022-03-19 14:13     ` Lars Ingebrigtsen
2022-03-19 15:20       ` Eli Zaretskii
2022-03-19 17:54         ` Andrea Corallo [this message]
2022-03-19 18:05           ` Lars Ingebrigtsen
2022-03-20 10:40             ` Andrea Corallo
2022-03-20 15:18               ` Lars Ingebrigtsen
2022-03-21  9:56                 ` Andrea Corallo
2022-03-21 14:53                   ` Lars Ingebrigtsen
2022-03-19 18:49       ` Knut Anders Hatlen
2022-03-17 17:53 ` Eli Zaretskii
2022-03-17 17:56   ` Lars Ingebrigtsen
2022-03-17 17:58   ` Lars Ingebrigtsen
2022-03-17 18:21     ` Eli Zaretskii
2022-03-17 18:22       ` Lars Ingebrigtsen
2022-03-17 20:02         ` Lars Ingebrigtsen
2022-03-17 22:50   ` Andrea Corallo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xjfmthlbzf0.fsf@ma.sdf.org \
    --to=akrl@sdf.org \
    --cc=54437@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=kahatlen@gmail.com \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).