From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#54437: 28.0.92; command-modes returns nil for native compiled functions Date: Sat, 19 Mar 2022 17:54:59 +0000 Message-ID: References: <87y218pr4x.fsf@dell.mail-host-address-is-not-set> <87fsngsfto.fsf@gnus.org> <87a6dosf58.fsf@gnus.org> <87y216owss.fsf@gnus.org> <83fsneezor.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24319"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: kahatlen@gmail.com, Lars Ingebrigtsen , 54437@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 19 18:56:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVdJN-00069n-QB for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Mar 2022 18:56:21 +0100 Original-Received: from localhost ([::1]:53146 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVdJM-0007Sf-5p for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Mar 2022 13:56:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVdJ4-0007SW-EQ for bug-gnu-emacs@gnu.org; Sat, 19 Mar 2022 13:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38419) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVdJ4-00084Y-64 for bug-gnu-emacs@gnu.org; Sat, 19 Mar 2022 13:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVdJ4-0007rJ-11 for bug-gnu-emacs@gnu.org; Sat, 19 Mar 2022 13:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Mar 2022 17:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54437 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 54437-submit@debbugs.gnu.org id=B54437.164771250530128 (code B ref 54437); Sat, 19 Mar 2022 17:56:01 +0000 Original-Received: (at 54437) by debbugs.gnu.org; 19 Mar 2022 17:55:05 +0000 Original-Received: from localhost ([127.0.0.1]:60549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVdI8-0007ps-Sf for submit@debbugs.gnu.org; Sat, 19 Mar 2022 13:55:05 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:52788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVdI8-0007pK-2R for 54437@debbugs.gnu.org; Sat, 19 Mar 2022 13:55:04 -0400 Original-Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 22JHsxb9003934 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sat, 19 Mar 2022 17:55:00 GMT In-Reply-To: <83fsneezor.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 19 Mar 2022 17:20:52 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228603 Archived-At: Eli Zaretskii writes: >> From: Lars Ingebrigtsen >> Date: Sat, 19 Mar 2022 15:13:07 +0100 >> Cc: 54437@debbugs.gnu.org >> >> Lars Ingebrigtsen writes: >> >> > Hm. I tried that now, and I can now reproduce the problem. Weird. >> > I'll debug further. >> >> I've now pushed a fix for this to Emacs 29. A less invasive fix for >> Emacs 28 might be nice, but I couldn't think of one, so I think we might >> just have to say that command-modes + nativecomp just doesn't work in >> Emacs 28.1. > > Thanks. > > Andrea, any thoughts? Just had a look, the fix LGTM (thanks Lars!). I just have a question for Lars, couldn't we just use and hash table to map function-name -> modes? Maybe this way the fix would be considerably less invasive? Thanks Andrea