unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#45462: 28.0.50; [feature/native-comp] trailing backslashes in comp-eln-load-path are required but shouldn't
@ 2020-12-27 15:00 Mauricio Collares
  2020-12-27 17:23 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 9+ messages in thread
From: Mauricio Collares @ 2020-12-27 15:00 UTC (permalink / raw)
  To: 45462


Steps to reproduce

1) Add "~/test" to comp-eln-load-path.
2) Native-compile file.el.

Expected result: The file gets written to
~/test/28.0.50-arch-hash/filename.eln.

Actual result: The file gets written to
~/test28.0.50-arch-hash/filename.eln.

Arguably comp-eln-load-path should behave the same as load-path and
always treat its entries as directories.





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#45462: 28.0.50; [feature/native-comp] trailing backslashes in comp-eln-load-path are required but shouldn't
  2020-12-27 15:00 bug#45462: 28.0.50; [feature/native-comp] trailing backslashes in comp-eln-load-path are required but shouldn't Mauricio Collares
@ 2020-12-27 17:23 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2021-01-05  0:35   ` Mauricio Collares
  2021-01-14 13:56   ` Mauricio Collares
  0 siblings, 2 replies; 9+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2020-12-27 17:23 UTC (permalink / raw)
  To: Mauricio Collares; +Cc: 45462

Mauricio Collares <mauricio@collares.org> writes:

> Steps to reproduce
>
> 1) Add "~/test" to comp-eln-load-path.
> 2) Native-compile file.el.
>
> Expected result: The file gets written to
> ~/test/28.0.50-arch-hash/filename.eln.
>
> Actual result: The file gets written to
> ~/test28.0.50-arch-hash/filename.eln.
>
> Arguably comp-eln-load-path should behave the same as load-path and
> always treat its entries as directories.

Hi Mauricio,

ee53560c8c should fix this, please have a try.

Thanks for reporting.

  Andrea





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#45462: 28.0.50; [feature/native-comp] trailing backslashes in comp-eln-load-path are required but shouldn't
  2020-12-27 17:23 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-01-05  0:35   ` Mauricio Collares
  2021-01-05  9:34     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2021-01-14 13:56   ` Mauricio Collares
  1 sibling, 1 reply; 9+ messages in thread
From: Mauricio Collares @ 2021-01-05  0:35 UTC (permalink / raw)
  To: Andrea Corallo; +Cc: 45462


Andrea Corallo <akrl@sdf.org> writes:
> Hi Mauricio,
>
> ee53560c8c should fix this, please have a try.
>
> Thanks for reporting.
>
>   Andrea

Hi Andrea,

First of all, happy new year!

I tested it and your fix is working well. Many thanks for the prompt
response and sorry for the delay in verifying it.

Best,
Mauricio





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#45462: 28.0.50; [feature/native-comp] trailing backslashes in comp-eln-load-path are required but shouldn't
  2021-01-05  0:35   ` Mauricio Collares
@ 2021-01-05  9:34     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 0 replies; 9+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-01-05  9:34 UTC (permalink / raw)
  To: Mauricio Collares; +Cc: 45462-done

Mauricio Collares <mauricio@collares.org> writes:

> Andrea Corallo <akrl@sdf.org> writes:
>> Hi Mauricio,
>>
>> ee53560c8c should fix this, please have a try.
>>
>> Thanks for reporting.
>>
>>   Andrea
>
> Hi Andrea,
>
> First of all, happy new year!

happy new year! :)

> I tested it and your fix is working well. Many thanks for the prompt
> response and sorry for the delay in verifying it.

Nice, closing then.

Thanks!

  Andrea





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#45462: 28.0.50; [feature/native-comp] trailing backslashes in comp-eln-load-path are required but shouldn't
  2020-12-27 17:23 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2021-01-05  0:35   ` Mauricio Collares
@ 2021-01-14 13:56   ` Mauricio Collares
  2021-01-14 14:17     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
  1 sibling, 1 reply; 9+ messages in thread
From: Mauricio Collares @ 2021-01-14 13:56 UTC (permalink / raw)
  To: Andrea Corallo; +Cc: 45462


Andrea Corallo <akrl@sdf.org> writes:
> Hi Mauricio,
>
> ee53560c8c should fix this, please have a try.
>
> Thanks for reporting.
>
>   Andrea

Hi Andrea,

As I mentioned before, previous tests worked fine. However, while
debugging #45854, I saw this problem again today. A minimized testcase:

* file1.el:

(require 'file2)
(provide 'file1)

* file2.el:

(advice-add 'top-level :before 'identity)
(provide 'file2)

Then the command

emacs --batch -Q --eval "(add-to-list 'load-path \"~\")" --eval "(setq comp-eln-load-path '(\"~/eln\"))" -f batch-native-compile ~/file1.el

compiles file1 to ~/eln/28.0.50-host-arch/ (as expected) but compiles
the trampoline to ~/eln28.0.50-host-arch/.

Best,
Mauricio





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#45462: 28.0.50; [feature/native-comp] trailing backslashes in comp-eln-load-path are required but shouldn't
  2021-01-14 13:56   ` Mauricio Collares
@ 2021-01-14 14:17     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2021-01-14 21:43       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 9+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-01-14 14:17 UTC (permalink / raw)
  To: Mauricio Collares; +Cc: 45462

Mauricio Collares <mauricio@collares.org> writes:

> Andrea Corallo <akrl@sdf.org> writes:
>> Hi Mauricio,
>>
>> ee53560c8c should fix this, please have a try.
>>
>> Thanks for reporting.
>>
>>   Andrea
>
> Hi Andrea,
>
> As I mentioned before, previous tests worked fine. However, while
> debugging #45854, I saw this problem again today. A minimized testcase:

I see where the issue is, should be an easy fix, I'll look into it this
evening.

Reopening this.

  Andrea





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#45462: 28.0.50; [feature/native-comp] trailing backslashes in comp-eln-load-path are required but shouldn't
  2021-01-14 14:17     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-01-14 21:43       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2021-01-18 12:17         ` Mauricio Collares
  0 siblings, 1 reply; 9+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-01-14 21:43 UTC (permalink / raw)
  To: Mauricio Collares; +Cc: 45462

Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:

> Mauricio Collares <mauricio@collares.org> writes:
>
>> Andrea Corallo <akrl@sdf.org> writes:
>>> Hi Mauricio,
>>>
>>> ee53560c8c should fix this, please have a try.
>>>
>>> Thanks for reporting.
>>>
>>>   Andrea
>>
>> Hi Andrea,
>>
>> As I mentioned before, previous tests worked fine. However, while
>> debugging #45854, I saw this problem again today. A minimized testcase:
>
> I see where the issue is, should be an easy fix, I'll look into it this
> evening.
>
> Reopening this.

Hi Mauricio,

f1efac1f9e should fix this, could you give it a try?

Thanks

  Andrea





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#45462: 28.0.50; [feature/native-comp] trailing backslashes in comp-eln-load-path are required but shouldn't
  2021-01-14 21:43       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-01-18 12:17         ` Mauricio Collares
  2021-01-18 12:36           ` akrl--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 9+ messages in thread
From: Mauricio Collares @ 2021-01-18 12:17 UTC (permalink / raw)
  To: Andrea Corallo; +Cc: 45462


Andrea Corallo <akrl@sdf.org> writes:
>
> Hi Mauricio,
>
> f1efac1f9e should fix this, could you give it a try?
>
> Thanks
>
>   Andrea

I tested 883d937320 and I can confirm this bug is fixed. Thanks!

Best,
Mauricio





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#45462: 28.0.50; [feature/native-comp] trailing backslashes in comp-eln-load-path are required but shouldn't
  2021-01-18 12:17         ` Mauricio Collares
@ 2021-01-18 12:36           ` akrl--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 0 replies; 9+ messages in thread
From: akrl--- via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-01-18 12:36 UTC (permalink / raw)
  To: Mauricio Collares; +Cc: 45462-done

Mauricio Collares <mauricio@collares.org> writes:

> Andrea Corallo <akrl@sdf.org> writes:
>>
>> Hi Mauricio,
>>
>> f1efac1f9e should fix this, could you give it a try?
>>
>> Thanks
>>
>>   Andrea
>
> I tested 883d937320 and I can confirm this bug is fixed. Thanks!

closing

Thanks!

  Andrea





^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-01-18 12:36 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-27 15:00 bug#45462: 28.0.50; [feature/native-comp] trailing backslashes in comp-eln-load-path are required but shouldn't Mauricio Collares
2020-12-27 17:23 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-01-05  0:35   ` Mauricio Collares
2021-01-05  9:34     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-01-14 13:56   ` Mauricio Collares
2021-01-14 14:17     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-01-14 21:43       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-01-18 12:17         ` Mauricio Collares
2021-01-18 12:36           ` akrl--- via Bug reports for GNU Emacs, the Swiss army knife of text editors

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).