From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 46256@debbugs.gnu.org, andrewjmoreton@gmail.com, pipcet@gmail.com
Subject: bug#46256: [feature/native-comp] AOT eln files ignored if run from build tree
Date: Tue, 09 Mar 2021 19:38:15 +0000 [thread overview]
Message-ID: <xjfblbst8wo.fsf@sdf.org> (raw)
In-Reply-To: <83mtvcp4ac.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 09 Mar 2021 20:31:39 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Andrea Corallo <akrl@sdf.org>
>> Cc: pipcet@gmail.com, 46256@debbugs.gnu.org, andrewjmoreton@gmail.com
>> Date: Tue, 09 Mar 2021 14:55:40 +0000
>>
>> cc-*.el files for instance have more than one direct call to load. IIRC
>> one of the analyzed cases was cc-mode related (certanly one I observed).
>>
>> >> > What are the reasons for unloading a .eln file which was once loaded
>> >> > into a session?
>> >>
>> >> All the functions defined in it are not anymore reachable (read all
>> >> symbols functions are makunbound or defined to some other function).
>> >
>> > That means someone did unload-feature, right?
>>
>> Also loading for example a new version freshly compiled of the same file
>> should present the same scenario.
>
> I see a problem in this area. Consider this code in
> native-elisp-load:
>
> if (!NILP (Fgethash (filename, all_loaded_comp_units_h, Qnil))
> && !file_in_eln_sys_dir (filename)
> && !NILP (Ffile_writable_p (filename)))
> {
> /* If in this session there was ever a file loaded with this
> name, rename it before loading, to make sure we always get a
> new handle! */
> Lisp_Object tmp_filename =
> Fmake_temp_file_internal (filename, Qnil, build_string (".eln.tmp"),
> Qnil);
> if (NILP (Ffile_writable_p (tmp_filename)))
> comp_u->handle = dynlib_open (SSDATA (encoded_filename));
> else
> {
> Frename_file (filename, tmp_filename, Qt);
> comp_u->handle = dynlib_open (SSDATA (ENCODE_FILE (tmp_filename)));
> Frename_file (tmp_filename, filename, Qnil);
> }
>
> The last 'else' branch momentarily renames the .eln file, then loads
> it under the modified name, with the assumption that this would force
> dynlib_open to produce a new handle. But in the case that the same
> .eln file is loaded more than once, i.e. the .eln file was not
> modified since the previous load, dynlib_open returns the same handle
> regardless of the file name, at least on MS-Windows. (Does this work
> as intended on GNU/Linux?)
>
> The problem with returning the same handle is that the refcount of the
> handle is incremented, which means unload-feature will be unable to
> unload the library.
It works because the handle is stored into the new CU object and passed
to 'load_comp_unit'. 'load_comp_unit' will recognize the "re-load"
condition and discard the CU freshly allocated to use the original one
(that is stored in the .eln). As a consequence the discarded CU will be
GC'd end so the refcounf will be decremented.
> Is this renaming dance for the case that the .eln file was updated
> since the last load, or do we need it even if it wasn't updated?
The renaming dance is for cases like one changes `comp-speed' recompile
and load.
Andrea
next prev parent reply other threads:[~2021-03-09 19:38 UTC|newest]
Thread overview: 179+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 11:11 bug#46256: [feature/native-comp] AOT eln files ignored if run from build tree Andy Moreton
2021-02-03 20:51 ` akrl--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-04 0:03 ` Andy Moreton
2021-02-04 1:40 ` Andy Moreton
2021-02-05 14:42 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-05 20:59 ` Andy Moreton
2021-02-05 23:55 ` Andy Moreton
2021-02-17 22:39 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-18 20:48 ` Andy Moreton
2021-02-18 21:00 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-19 8:02 ` Eli Zaretskii
2021-02-19 14:49 ` Andy Moreton
2021-02-19 15:28 ` Eli Zaretskii
2021-02-19 16:01 ` Andrea Corallo
2021-02-26 20:34 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-26 20:45 ` Eli Zaretskii
2021-02-26 20:48 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-26 20:52 ` Eli Zaretskii
2021-02-27 6:58 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-27 7:55 ` Eli Zaretskii
2021-02-27 12:08 ` Andy Moreton
2021-02-27 19:14 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-27 19:20 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-27 19:46 ` Andy Moreton
2021-02-27 21:58 ` Andy Moreton
2021-02-28 17:35 ` Eli Zaretskii
2021-02-28 21:15 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-01 5:36 ` Eli Zaretskii
2021-03-01 6:34 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-01 9:48 ` Andy Moreton
2021-03-03 18:27 ` Eli Zaretskii
2021-03-03 18:43 ` Eli Zaretskii
2021-03-03 19:46 ` Eli Zaretskii
2021-03-03 20:04 ` Eli Zaretskii
2021-03-03 20:21 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-04 8:30 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-04 11:54 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-04 14:13 ` Eli Zaretskii
2021-03-04 14:24 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-04 14:49 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-04 17:24 ` Eli Zaretskii
2021-03-04 18:56 ` Eli Zaretskii
2021-03-04 20:11 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-04 21:33 ` Eli Zaretskii
2021-03-05 9:32 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-05 10:09 ` Pip Cet
2021-03-05 10:19 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-06 1:47 ` Andy Moreton
2021-03-06 9:54 ` Pip Cet
2021-03-06 10:30 ` Eli Zaretskii
2021-03-06 12:15 ` Andy Moreton
2021-03-06 13:10 ` Eli Zaretskii
2021-03-06 15:18 ` Andy Moreton
2021-03-06 18:37 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-07 9:22 ` Pip Cet
2021-03-05 11:55 ` Eli Zaretskii
2021-03-05 13:56 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-05 14:54 ` Eli Zaretskii
2021-03-05 15:18 ` Pip Cet
2021-03-05 15:22 ` Eli Zaretskii
2021-03-05 15:54 ` Pip Cet
2021-03-05 18:44 ` Eli Zaretskii
2021-03-05 15:26 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-04 21:30 ` Andy Moreton
2021-03-04 20:47 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-05 13:52 ` Eli Zaretskii
2021-03-05 14:04 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-05 15:00 ` Eli Zaretskii
2021-03-05 15:56 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-05 18:46 ` Eli Zaretskii
2021-03-05 19:22 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-05 20:31 ` Eli Zaretskii
2021-03-05 22:25 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-06 7:39 ` Eli Zaretskii
2021-03-06 14:38 ` Eli Zaretskii
2021-03-06 15:35 ` Eli Zaretskii
2021-03-06 17:47 ` Eli Zaretskii
2021-03-06 18:31 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-06 18:48 ` Eli Zaretskii
2021-03-06 19:19 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-06 19:40 ` Pip Cet
2021-03-06 19:48 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-06 20:24 ` Eli Zaretskii
2021-03-06 20:31 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-06 20:53 ` Eli Zaretskii
2021-03-06 21:02 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-07 5:55 ` Eli Zaretskii
2021-03-07 6:57 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-07 7:40 ` Eli Zaretskii
2021-03-07 19:05 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-07 18:56 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-07 19:08 ` Eli Zaretskii
2021-03-06 20:08 ` Eli Zaretskii
2021-03-06 20:19 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-06 18:30 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-06 18:44 ` Eli Zaretskii
2021-03-06 19:21 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-06 20:10 ` Eli Zaretskii
2021-03-06 20:26 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-06 0:33 ` Andy Moreton
2021-03-06 7:42 ` Eli Zaretskii
2021-03-06 12:09 ` Andy Moreton
2021-03-06 13:05 ` Eli Zaretskii
2021-03-06 15:46 ` Andy Moreton
2021-03-06 19:31 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-07 17:59 ` Eli Zaretskii
2021-03-07 18:53 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-07 19:15 ` Eli Zaretskii
2021-03-07 20:16 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-07 21:27 ` Pip Cet
2021-03-07 21:47 ` Pip Cet
2021-03-07 21:51 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-07 22:16 ` Pip Cet
2021-03-08 13:26 ` Eli Zaretskii
2021-03-08 13:52 ` Pip Cet
2021-03-08 14:39 ` Eli Zaretskii
2021-03-08 14:50 ` Pip Cet
2021-03-08 15:14 ` Eli Zaretskii
2021-03-08 17:40 ` Eli Zaretskii
2021-03-08 3:31 ` Eli Zaretskii
2021-03-08 5:54 ` Pip Cet
2021-03-08 6:48 ` Pip Cet
2021-03-08 10:14 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-08 10:45 ` Pip Cet
2021-03-08 15:02 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-08 15:09 ` Pip Cet
2021-03-08 15:38 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-09 12:36 ` Eli Zaretskii
2021-03-09 8:32 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-09 13:05 ` Eli Zaretskii
2021-03-09 13:58 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-09 16:36 ` Eli Zaretskii
2021-03-09 17:10 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-08 14:11 ` Eli Zaretskii
2021-03-08 14:27 ` Pip Cet
2021-03-08 18:06 ` Eli Zaretskii
2021-03-08 18:15 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-08 20:37 ` Eli Zaretskii
2021-03-09 7:03 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-09 12:55 ` Eli Zaretskii
2021-03-09 14:55 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-09 16:42 ` Eli Zaretskii
2021-03-09 18:31 ` Eli Zaretskii
2021-03-09 19:38 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-03-09 16:30 ` Eli Zaretskii
2021-03-10 13:14 ` Alan Mackenzie
2021-03-10 13:20 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-10 14:07 ` Eli Zaretskii
2021-03-10 15:24 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-10 16:56 ` Alan Mackenzie
2021-03-10 17:43 ` Eli Zaretskii
2021-03-08 18:18 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-08 18:32 ` Pip Cet
2021-03-08 20:47 ` Eli Zaretskii
2021-03-08 20:50 ` Pip Cet
2021-03-09 8:28 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-09 8:35 ` Pip Cet
2021-03-09 8:43 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-09 14:32 ` Eli Zaretskii
2021-03-08 20:49 ` Eli Zaretskii
2021-03-09 8:35 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-09 14:34 ` Eli Zaretskii
2021-03-09 15:38 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-09 16:51 ` Eli Zaretskii
2021-03-09 17:04 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-09 18:20 ` Eli Zaretskii
2021-03-09 19:23 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-08 18:13 ` Eli Zaretskii
2021-03-08 20:53 ` Pip Cet
2021-03-08 15:07 ` Eli Zaretskii
2021-03-03 18:48 ` Eli Zaretskii
2021-03-03 19:28 ` Eli Zaretskii
2021-03-03 19:50 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-03 20:08 ` Eli Zaretskii
2021-03-03 19:37 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-03 20:13 ` Eli Zaretskii
2021-02-28 21:04 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-05 14:39 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-05 15:08 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xjfblbst8wo.fsf@sdf.org \
--to=bug-gnu-emacs@gnu.org \
--cc=46256@debbugs.gnu.org \
--cc=akrl@sdf.org \
--cc=andrewjmoreton@gmail.com \
--cc=eliz@gnu.org \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).