unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Andy Moreton <andrewjmoreton@gmail.com>
To: 46256@debbugs.gnu.org
Subject: bug#46256: [feature/native-comp] AOT eln files ignored if run from build tree
Date: Fri, 19 Feb 2021 14:49:25 +0000	[thread overview]
Message-ID: <86v9ao5czu.fsf@gmail.com> (raw)
In-Reply-To: <e62633ce-2fb1-e943-55a5-03142b708697@gmail.com>

On Fri 19 Feb 2021, Eli Zaretskii wrote:

>> Cc: 46256@debbugs.gnu.org
>> Date: Thu, 18 Feb 2021 21:00:29 +0000
>> From:  Andrea Corallo via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>> 
>> >> Last queston: do reverse slashes '\' appear somewhere in those
>> >> filenames?  This was issue I tried to fix with the blind patch I've
>> >> sent.
>> >
>> > As Eli pointed out, that is not the problem: forward slashes are ok.
>> 
>> I understand they are handled, but here as we do a substitution we must
>> substitute what's coming in.
>> 
>> As you have the possibility to debug this piece of code on Windows
>> please have a look at this (or try my blind patch if you haven't).
>
> If the problem is with hashing file names, you will have to
> canonicalize them first, including resolving the letter-case issue,
> the forward/back-slashes issue, and also the issue with those pesky
> numerical tails Windows sometimes produces.  We have a function
> Fw32_long_file_name for that purpose, I think you should use it (if
> you need it for C strings, we could add a wrapper around
> w32_get_long_filename to do that instead).  This assumes that you are
> talking about existing files; if that assumption is not true, we will
> need a slightly different strategy.

The problem is with the file names used to generate the hashes, where
comparison of file names.

As an experiment, I changed epaths.h from:
#define PATH_DUMPLOADSEARCH "C:/emacs/git/emacs/native/lisp"

to:
#define PATH_DUMPLOADSEARCH "c:/emacs/git/emacs/native/lisp"

and then ran make (to build without regenerating the header).
The resulting emacs did not complain about mismatched filenames.

Thus the fix outlined by Eli above looks like it will solve the problem.

    AndyM






  reply	other threads:[~2021-02-19 14:49 UTC|newest]

Thread overview: 179+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-02 11:11 bug#46256: [feature/native-comp] AOT eln files ignored if run from build tree Andy Moreton
2021-02-03 20:51 ` akrl--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-04  0:03   ` Andy Moreton
2021-02-04  1:40     ` Andy Moreton
2021-02-05 14:42       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-05 20:59         ` Andy Moreton
2021-02-05 23:55       ` Andy Moreton
2021-02-17 22:39         ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-18 20:48           ` Andy Moreton
2021-02-18 21:00             ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-19  8:02               ` Eli Zaretskii
2021-02-19 14:49                 ` Andy Moreton [this message]
2021-02-19 15:28                   ` Eli Zaretskii
2021-02-19 16:01                   ` Andrea Corallo
2021-02-26 20:34                   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-26 20:45                     ` Eli Zaretskii
2021-02-26 20:48                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-26 20:52                         ` Eli Zaretskii
2021-02-27  6:58                           ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-27  7:55                             ` Eli Zaretskii
2021-02-27 12:08                     ` Andy Moreton
2021-02-27 19:14                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-27 19:20                         ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-27 19:46                         ` Andy Moreton
2021-02-27 21:58                           ` Andy Moreton
2021-02-28 17:35                             ` Eli Zaretskii
2021-02-28 21:15                               ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-01  5:36                                 ` Eli Zaretskii
2021-03-01  6:34                                   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-01  9:48                               ` Andy Moreton
2021-03-03 18:27                                 ` Eli Zaretskii
2021-03-03 18:43                                   ` Eli Zaretskii
2021-03-03 19:46                                     ` Eli Zaretskii
2021-03-03 20:04                                       ` Eli Zaretskii
2021-03-03 20:21                                         ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-04  8:30                                           ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-04 11:54                                             ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-04 14:13                                               ` Eli Zaretskii
2021-03-04 14:24                                                 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-04 14:49                                                   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-04 17:24                                                     ` Eli Zaretskii
2021-03-04 18:56                                                       ` Eli Zaretskii
2021-03-04 20:11                                                         ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-04 21:33                                                           ` Eli Zaretskii
2021-03-05  9:32                                                             ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-05 10:09                                                               ` Pip Cet
2021-03-05 10:19                                                                 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-06  1:47                                                                   ` Andy Moreton
2021-03-06  9:54                                                                     ` Pip Cet
2021-03-06 10:30                                                                       ` Eli Zaretskii
2021-03-06 12:15                                                                       ` Andy Moreton
2021-03-06 13:10                                                                         ` Eli Zaretskii
2021-03-06 15:18                                                                           ` Andy Moreton
2021-03-06 18:37                                                                             ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-07  9:22                                                                         ` Pip Cet
2021-03-05 11:55                                                               ` Eli Zaretskii
2021-03-05 13:56                                                                 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-05 14:54                                                                   ` Eli Zaretskii
2021-03-05 15:18                                                                     ` Pip Cet
2021-03-05 15:22                                                                       ` Eli Zaretskii
2021-03-05 15:54                                                                         ` Pip Cet
2021-03-05 18:44                                                                           ` Eli Zaretskii
2021-03-05 15:26                                                                     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-04 21:30                                                         ` Andy Moreton
2021-03-04 20:47                                                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-05 13:52                                                     ` Eli Zaretskii
2021-03-05 14:04                                                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-05 15:00                                                         ` Eli Zaretskii
2021-03-05 15:56                                                           ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-05 18:46                                                             ` Eli Zaretskii
2021-03-05 19:22                                                               ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-05 20:31                                                                 ` Eli Zaretskii
2021-03-05 22:25                                                                   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-06  7:39                                                                     ` Eli Zaretskii
2021-03-06 14:38                                                                 ` Eli Zaretskii
2021-03-06 15:35                                                                   ` Eli Zaretskii
2021-03-06 17:47                                                                     ` Eli Zaretskii
2021-03-06 18:31                                                                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-06 18:48                                                                         ` Eli Zaretskii
2021-03-06 19:19                                                                           ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-06 19:40                                                                             ` Pip Cet
2021-03-06 19:48                                                                               ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-06 20:24                                                                                 ` Eli Zaretskii
2021-03-06 20:31                                                                                   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-06 20:53                                                                                     ` Eli Zaretskii
2021-03-06 21:02                                                                                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-07  5:55                                                                                         ` Eli Zaretskii
2021-03-07  6:57                                                                                           ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-07  7:40                                                                                             ` Eli Zaretskii
2021-03-07 19:05                                                                                               ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-07 18:56                                                                                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-07 19:08                                                                                         ` Eli Zaretskii
2021-03-06 20:08                                                                             ` Eli Zaretskii
2021-03-06 20:19                                                                               ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-06 18:30                                                                   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-06 18:44                                                                     ` Eli Zaretskii
2021-03-06 19:21                                                                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-06 20:10                                                                         ` Eli Zaretskii
2021-03-06 20:26                                                                           ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-06  0:33                                             ` Andy Moreton
2021-03-06  7:42                                               ` Eli Zaretskii
2021-03-06 12:09                                                 ` Andy Moreton
2021-03-06 13:05                                                   ` Eli Zaretskii
2021-03-06 15:46                                                     ` Andy Moreton
2021-03-06 19:31                                                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-07 17:59                                     ` Eli Zaretskii
2021-03-07 18:53                                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-07 19:15                                         ` Eli Zaretskii
2021-03-07 20:16                                           ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-07 21:27                                             ` Pip Cet
2021-03-07 21:47                                               ` Pip Cet
2021-03-07 21:51                                               ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-07 22:16                                                 ` Pip Cet
2021-03-08 13:26                                                   ` Eli Zaretskii
2021-03-08 13:52                                                     ` Pip Cet
2021-03-08 14:39                                                       ` Eli Zaretskii
2021-03-08 14:50                                                         ` Pip Cet
2021-03-08 15:14                                                           ` Eli Zaretskii
2021-03-08 17:40                                                           ` Eli Zaretskii
2021-03-08  3:31                                                 ` Eli Zaretskii
2021-03-08  5:54                                                   ` Pip Cet
2021-03-08  6:48                                                     ` Pip Cet
2021-03-08 10:14                                                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-08 10:45                                                         ` Pip Cet
2021-03-08 15:02                                                           ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-08 15:09                                                             ` Pip Cet
2021-03-08 15:38                                                               ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-09 12:36                                                           ` Eli Zaretskii
2021-03-09  8:32                                                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-09 13:05                                                         ` Eli Zaretskii
2021-03-09 13:58                                                           ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-09 16:36                                                             ` Eli Zaretskii
2021-03-09 17:10                                                               ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-08 14:11                                                     ` Eli Zaretskii
2021-03-08 14:27                                                       ` Pip Cet
2021-03-08 18:06                                                         ` Eli Zaretskii
2021-03-08 18:15                                                           ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-08 20:37                                                             ` Eli Zaretskii
2021-03-09  7:03                                                               ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-09 12:55                                                                 ` Eli Zaretskii
2021-03-09 14:55                                                                   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-09 16:42                                                                     ` Eli Zaretskii
2021-03-09 18:31                                                                     ` Eli Zaretskii
2021-03-09 19:38                                                                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-09 16:30                                                                   ` Eli Zaretskii
2021-03-10 13:14                                                                     ` Alan Mackenzie
2021-03-10 13:20                                                                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-10 14:07                                                                       ` Eli Zaretskii
2021-03-10 15:24                                                                         ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-10 16:56                                                                         ` Alan Mackenzie
2021-03-10 17:43                                                                           ` Eli Zaretskii
2021-03-08 18:18                                                           ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-08 18:32                                                             ` Pip Cet
2021-03-08 20:47                                                               ` Eli Zaretskii
2021-03-08 20:50                                                                 ` Pip Cet
2021-03-09  8:28                                                                   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-09  8:35                                                                     ` Pip Cet
2021-03-09  8:43                                                                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-09 14:32                                                                       ` Eli Zaretskii
2021-03-08 20:49                                                             ` Eli Zaretskii
2021-03-09  8:35                                                               ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-09 14:34                                                                 ` Eli Zaretskii
2021-03-09 15:38                                                                   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-09 16:51                                                                     ` Eli Zaretskii
2021-03-09 17:04                                                                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-09 18:20                                                                         ` Eli Zaretskii
2021-03-09 19:23                                                                           ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-08 18:13                                                         ` Eli Zaretskii
2021-03-08 20:53                                                           ` Pip Cet
2021-03-08 15:07                                             ` Eli Zaretskii
2021-03-03 18:48                                   ` Eli Zaretskii
2021-03-03 19:28                                     ` Eli Zaretskii
2021-03-03 19:50                                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-03 20:08                                         ` Eli Zaretskii
2021-03-03 19:37                                     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-03 20:13                                       ` Eli Zaretskii
2021-02-28 21:04                             ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-05 14:39     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-05 15:08       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86v9ao5czu.fsf@gmail.com \
    --to=andrewjmoreton@gmail.com \
    --cc=46256@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).