unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#42909: feature/native-comp; comp.el: Pass comp-eln-load-path to child
@ 2020-08-18  2:19 Andrew Whatson
  2020-08-18  7:36 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 4+ messages in thread
From: Andrew Whatson @ 2020-08-18  2:19 UTC (permalink / raw)
  To: 42909; +Cc: Andrew Whatson

The `comp-eln-load-path' must be passed to the child to ensure that .eln
files are written to the correct location.

Without this, when a custom `comp-eln-load-path' is used, Emacs will
crash with "Native elisp load failed: file does not exist".

---
 lisp/emacs-lisp/comp.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
index 85b5562f28..3176351b37 100644
--- a/lisp/emacs-lisp/comp.el
+++ b/lisp/emacs-lisp/comp.el
@@ -2580,6 +2580,7 @@ comp-run-async-workers
                             (setf comp-speed ,comp-speed
                                   comp-debug ,comp-debug
                                   comp-verbose ,comp-verbose
+                                  comp-eln-load-path ',comp-eln-load-path
                                   load-path ',load-path)
                             ,comp-async-env-modifier-form
                             (message "Compiling %s..." ,source-file)
-- 
2.28.0






^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#42909: feature/native-comp; comp.el: Pass comp-eln-load-path to child
  2020-08-18  2:19 bug#42909: feature/native-comp; comp.el: Pass comp-eln-load-path to child Andrew Whatson
@ 2020-08-18  7:36 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2020-08-18  9:16   ` Andrew Whatson
  0 siblings, 1 reply; 4+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2020-08-18  7:36 UTC (permalink / raw)
  To: Andrew Whatson; +Cc: 42909

Hi Andrew,

oops, thanks for catching that!

Have you already done the copyright paperwork?  This is small enough
that it should be exempt, but is for annotating it correctly.

Thanks

  Andrea

-- 
akrl@sdf.org





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#42909: feature/native-comp; comp.el: Pass comp-eln-load-path to child
  2020-08-18  7:36 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2020-08-18  9:16   ` Andrew Whatson
  2020-08-18  9:44     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 4+ messages in thread
From: Andrew Whatson @ 2020-08-18  9:16 UTC (permalink / raw)
  To: Andrea Corallo; +Cc: 42909

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

Hi Andrea,

Yes, I've already done copyright assignment to the FSF for Emacs.

Cheers


On Tue, 18 Aug 2020, 5:36 pm Andrea Corallo, <akrl@sdf.org> wrote:

> Hi Andrew,
>
> oops, thanks for catching that!
>
> Have you already done the copyright paperwork?  This is small enough
> that it should be exempt, but is for annotating it correctly.
>
> Thanks
>
>   Andrea
>
> --
> akrl@sdf.org
>

[-- Attachment #2: Type: text/html, Size: 866 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#42909: feature/native-comp; comp.el: Pass comp-eln-load-path to child
  2020-08-18  9:16   ` Andrew Whatson
@ 2020-08-18  9:44     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 0 replies; 4+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2020-08-18  9:44 UTC (permalink / raw)
  To: Andrew Whatson; +Cc: 42909-done

Andrew Whatson <whatson@gmail.com> writes:

> Hi Andrea,
>
> Yes, I've already done copyright assignment to the FSF for Emacs.
>
> Cheers

Great, I've added a ChangeLog and committed fc9b68636b at your name.

Closing it.

Thanks!

  Andrea

-- 
akrl@sdf.org





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-08-18  9:44 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-18  2:19 bug#42909: feature/native-comp; comp.el: Pass comp-eln-load-path to child Andrew Whatson
2020-08-18  7:36 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-18  9:16   ` Andrew Whatson
2020-08-18  9:44     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).