bug#43536: 28.0.50; [feature/native-comp] Recursive infinite hook call when normal elisp didn't

bug#43536: 28.0.50; [feature/native-comp] Recursive infinite hook call when normal elisp didn't

[Kadir Can Çetin]

[-- Attachment #1: Type: text/plain, Size: 6431 bytes --]

* Reproduce Bug
- start emacs with corresponding init.el
- after async native compile has done, close emacs
- start emacs again
- run 'org-roam-db-build-cache'

It creates an infinite loop of hook calling which discussed on
https://github.com/org-roam/org-roam/issues/1078 . This is bad
configured emacs but it works perfectly on without native
compilation.

========================================================================
;;;;;;;;;;;;;;;;;;;;;;;;;;
;; .emacs.d/ structure ;;;
;;;;;;;;;;;;;;;;;;;;;;;;;
- .init.el
- roams/
    - test.org    # empty org file

========================================================================
;;;;;;;;;;;;;
;; init.el ;;;
;;;;;;;;;;;;;;

(setq comp-deferred-compilation nil)
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
(require 'package)
(add-to-list 'package-archives '("melpa" . "https://melpa.org/packages/") t)
(package-initialize)

(add-to-list 'package-archives
             '("melpa-stable" . "https://stable.melpa.org/packages/") t)
(package-refresh-contents)
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
(package-install 'org-roam)
(setq org-roam-directory "~/.emacs.d/roams/")

(require 'org-roam)
(add-hook 'org-mode-hook #'org-roam-mode)
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
(native-compile-async "~/.emacs.d/elpa/"t)


========================================================================
========================================================================
========================================================================

In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.23,
cairo version 1.17.3)
 of 2020-09-20 built on kadir-linux
Repository revision: 5b41545f1be367837d9ac717ea67fba19a4c24d4
Repository branch: makepkg
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Manjaro Linux

Configured using:
 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
 --localstatedir=/var --mandir=/usr/share/man --with-gameuser=:games
 --with-sound=alsa --with-modules --without-gconf --without-gsettings
 --with-nativecomp --with-x-toolkit=gtk3 --without-xaw3d
 --without-m17n-flt --with-cairo --without-compress-install
 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong
 -fno-plt -g -fuse-ld=gold' CPPFLAGS=-D_FORTIFY_SOURCE=2
 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now'

Configured features:
XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GLIB NOTIFY INOTIFY ACL
GNUTLS LIBXML2 FREETYPE HARFBUZZ LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3
X11 XDBE XIM MODULES NATIVE_COMP THREADS LIBSYSTEMD JSON PDUMPER LCMS2

Important settings:
  value of $LC_MONETARY: tr_TR.UTF-8
  value of $LC_NUMERIC: tr_TR.UTF-8
  value of $LC_TIME: tr_TR.UTF-8
  value of $LANG: en_US.utf8
  locale-coding-system: utf-8-unix

Major mode: ELisp/d

Minor modes in effect:
  org-roam-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug sendmail help-fns radix-tree cl-print
debug backtrace ol-eww ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect
nnir gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum shr
kinsoku svg dom gnus-group gnus-undo gnus-start gnus-dbus dbus
gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo parse-time iso8601
gnus-spec gnus-int gnus-range gnus-win gnus nnheader ol-docview doc-view
jka-compr image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m cus-edit
wid-edit cus-start cus-load org-roam org-roam-graph xml org-roam-doctor
org-roam-db emacsql-sqlite3 emacsql emacsql-compiler org-roam-dailies
org-roam-capture org-capture org-roam-completion org-roam-buffer
org-roam-faces org-roam-macs org-roam-compat f s dash org-id org-element
avl-tree generator org ob ob-tangle ob-ref ob-lob ob-table ob-exp
org-macro org-footnote org-src ob-comint org-pcomplete pcomplete comint
ansi-color ring org-list org-faces org-entities noutline outline
easy-mmode org-version ob-emacs-lisp ob-core ob-eval org-table ol
org-keys org-compat advice org-macs org-loaddefs format-spec find-func
cal-menu calendar cal-loaddefs mm-archive message dired dired-loaddefs
rfc822 mml mml-sec epa derived gnus-util rmail rmail-loaddefs
text-property-search time-date mailabbrev gmm-utils mailheader mm-decode
mm-bodies mm-encode mail-utils gnutls network-stream url-http mail-parse
rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr url-gw nsm rmc
puny url-cache url-auth url url-proxy url-privacy url-expand url-methods
url-history url-cookie url-domsuf url-util mailcap epg epg-config
finder-inf info package browse-url url-handlers url-parse auth-source
eieio eieio-core eieio-loaddefs password-cache json map url-vars comp
warnings subr-x rx cl-seq cl-macs cl-extra help-mode easymenu seq
byte-opt gv cl-loaddefs cl-lib bytecomp byte-compile cconv tooltip eldoc
electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win
x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face pcase macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting font-render-setting cairo move-toolbar gtk x-toolkit x
multi-tty make-network-process emacs)

Memory information:
((conses 16 528796 67692)
 (symbols 48 28720 1)
 (strings 32 149182 14250)
 (string-bytes 1 4331050)
 (vectors 16 51113)
 (vector-slots 8 780295 47891)
 (floats 8 270 321)
 (intervals 56 5672 77)
 (buffers 992 221))

[-- Attachment #2: Type: text/html, Size: 7300 bytes --]

bug#43536: 28.0.50; [feature/native-comp] Recursive infinite hook call when normal elisp didn't

[Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Kadir Can Çetin <kadircancetin@gmail.com> writes:

> * Reproduce Bug
> - start emacs with corresponding init.el
> - after async native compile has done, close emacs
> - start emacs again
> - run 'org-roam-db-build-cache'

Hi Kadir,

I tried your reproducer but I could not reproduce it with the current
branch.

I see roam is advicing some primitive functions, this would have not
worked without the recent development of this week.

It may be this or some other fix we did, but unless I'm doing something
different from what you have done I guess the bug should be fixed.

Please let me know if you like to double check or we are fine to close
it.

Thanks!

  Andrea

bug#43536: 28.0.50; [feature/native-comp] Recursive infinite hook call when normal elisp didn't

[Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:

> Kadir Can Çetin <kadircancetin@gmail.com> writes:
>
>> * Reproduce Bug
>> - start emacs with corresponding init.el
>> - after async native compile has done, close emacs
>> - start emacs again
>> - run 'org-roam-db-build-cache'
>
> Hi Kadir,
>
> I tried your reproducer but I could not reproduce it with the current
> branch.
>
> I see roam is advicing some primitive functions, this would have not
> worked without the recent development of this week.
>
> It may be this or some other fix we did, but unless I'm doing something
> different from what you have done I guess the bug should be fixed.
>
> Please let me know if you like to double check or we are fine to close
> it.
>
> Thanks!
>
>   Andrea

Hi all,  I'm closing this.  Happy to reopen if the issue shows up again
ona recent state of the branch.

Thanks

  Andrea