unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michal Nazarewicz <mina86@mina86.com>
To: Eli Zaretskii <eliz@gnu.org>, Marcin Borkowski <mbork@mbork.pl>
Cc: 20871@debbugs.gnu.org
Subject: bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren
Date: Fri, 02 Feb 2018 10:18:37 +0100	[thread overview]
Message-ID: <xa1tshajda1e.fsf@mina86.com> (raw)
In-Reply-To: <8337qkb7v7.fsf@gnu.org>

On Sun, Apr 17 2016, Eli Zaretskii wrote:
> Could you please elaborate on the bug itself?
>
> See, the function in question, fill-single-char-nobreak-p, is
> documented as a possible value to use in the fill hook, for a very
> specific purpose.  If you are saying that it doesn't fulfill that
> purpose well enough, please show a use case where it fails to do that.
> At least the situation you described, with " (a", doesn't seem to fit
> the use cases which this function is supposed to cover, since the
> parenthesis makes a 2-character sequence, whereas
> fill-single-char-nobreak-p aims to support isolated one-character
> words.

As person who wrote ‘fill-single-char-nobreak-p’ I can say that its
intention was to work for Polish and Czech typography.  In other words,
what Marcin reported is a genuine defect in the function.

In particular, function’s documentation mentions *one-letter* sequences,
not *one-character* sequences:

	Return non-nil if a one-letter word is before point.

(Admittedly, the name of the function is misleading).

As such, I would suggest applying the fix to
‘fill-single-char-nobreak-p’ rather than introducing a new function.

(And perhaps adding an alias and deprecating the old name if misleading
name is too big of a problem).

As another point of context, ideally, ‘tildify-mode’ and
‘fill-single-char-nobreak-p’ would use the exact same logic since they
both work to address the same underlying typographic conventions.

-- 
Best regards
ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ
«If at first you don’t succeed, give up skydiving»





  parent reply	other threads:[~2018-02-02  9:18 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-22 10:19 bug#20871: 25.0.50; fill-single-char-nobreak-p does not recognize a single-letter word when it is preceded by an open paren Marcin Borkowski
2015-06-22 10:28 ` Marcin Borkowski
2016-04-17  6:34   ` Marcin Borkowski
2016-04-17 14:57     ` Eli Zaretskii
2016-04-17 15:34       ` Marcin Borkowski
2016-04-17 16:49         ` Eli Zaretskii
2016-04-17 17:41           ` Marcin Borkowski
2016-04-27  7:02           ` Marcin Borkowski
2016-04-27  7:20             ` Eli Zaretskii
2016-04-29 12:18               ` Marcin Borkowski
2016-04-30 11:21                 ` Eli Zaretskii
2016-04-30 12:26                   ` Marcin Borkowski
2016-04-30 12:38                     ` Eli Zaretskii
2016-04-30 16:41                       ` Marcin Borkowski
2016-04-30 17:01                         ` Eli Zaretskii
2016-04-30 18:42                           ` Marcin Borkowski
2016-04-30 19:01                             ` Eli Zaretskii
2017-12-07 13:28                               ` Marcin Borkowski
2017-12-09 11:52                                 ` Eli Zaretskii
2017-12-09 15:45                                   ` Marcin Borkowski
2017-12-19 11:44                                     ` Marcin Borkowski
2017-12-19 16:15                                       ` Eli Zaretskii
2018-01-02  8:55                                         ` Marcin Borkowski
2018-01-13  8:46                                           ` Eli Zaretskii
2018-01-13 16:01                                             ` Marcin Borkowski
2018-01-13 16:53                                               ` Eli Zaretskii
2018-01-13 17:02                                                 ` Eli Zaretskii
2018-01-15  5:13                                                   ` Marcin Borkowski
2018-01-15  5:13                                                 ` Marcin Borkowski
2018-01-15  5:30                                                   ` Marcin Borkowski
2018-01-15 13:07                                                     ` Eli Zaretskii
2018-01-24  9:34                                                       ` Marcin Borkowski
2018-01-24 19:16                                                         ` Eli Zaretskii
2016-04-30 17:42                         ` Drew Adams
2016-04-30 18:24                           ` Eli Zaretskii
2016-04-30 18:41                             ` Marcin Borkowski
2018-02-02  9:18       ` Michal Nazarewicz [this message]
     [not found] <9A9C6F59-CB27-42D1-911E-F027B443B9BE@acm.org>
     [not found] ` <8336i1p8zd.fsf@gnu.org>
     [not found]   ` <CA+pa1O3rcDznoR0u8i_AN5iHe9mM+FHqkAO=yVM2Gu5_Gc40jQ@mail.gmail.com>
2019-08-17  6:57     ` Eli Zaretskii
2019-08-17 14:17       ` Marcin Borkowski
2019-08-17 15:04         ` Eli Zaretskii
2019-08-17 15:58           ` Marcin Borkowski
2019-08-19 14:07       ` Michał Nazarewicz
2019-08-19 15:01         ` Eli Zaretskii
2019-08-19 15:36           ` Michał Nazarewicz
2019-08-19 16:16             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xa1tshajda1e.fsf@mina86.com \
    --to=mina86@mina86.com \
    --cc=20871@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=mbork@mbork.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).