* bug#5374: vc-find-file-hook in batch?
@ 2010-01-13 10:28 Lennart Borgman
2011-07-12 0:15 ` Glenn Morris
0 siblings, 1 reply; 7+ messages in thread
From: Lennart Borgman @ 2010-01-13 10:28 UTC (permalink / raw)
To: emacs-pretest-bug
Should really vc-find-file-hook be in find-file-hook when Emacs is run
in batch? Could not that create problems?
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#5374: vc-find-file-hook in batch?
2010-01-13 10:28 bug#5374: vc-find-file-hook in batch? Lennart Borgman
@ 2011-07-12 0:15 ` Glenn Morris
2011-07-12 11:08 ` Lennart Borgman
0 siblings, 1 reply; 7+ messages in thread
From: Glenn Morris @ 2011-07-12 0:15 UTC (permalink / raw)
To: Lennart Borgman; +Cc: 5374
Lennart Borgman wrote:
> Should really vc-find-file-hook be in find-file-hook when Emacs is run
> in batch? Could not that create problems?
Can you give an example of a problem?
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#5374: vc-find-file-hook in batch?
2011-07-12 0:15 ` Glenn Morris
@ 2011-07-12 11:08 ` Lennart Borgman
2011-07-12 16:03 ` Chong Yidong
0 siblings, 1 reply; 7+ messages in thread
From: Lennart Borgman @ 2011-07-12 11:08 UTC (permalink / raw)
To: Glenn Morris; +Cc: 5374
On Tue, Jul 12, 2011 at 02:15, Glenn Morris <rgm@gnu.org> wrote:
> Lennart Borgman wrote:
>
>> Should really vc-find-file-hook be in find-file-hook when Emacs is run
>> in batch? Could not that create problems?
>
> Can you give an example of a problem?
In some cases I run a lot of batch jobs from Emacs (to be sure about
what is loaded in Emacs).
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#5374: vc-find-file-hook in batch?
2011-07-12 11:08 ` Lennart Borgman
@ 2011-07-12 16:03 ` Chong Yidong
2011-07-12 16:17 ` Lennart Borgman
0 siblings, 1 reply; 7+ messages in thread
From: Chong Yidong @ 2011-07-12 16:03 UTC (permalink / raw)
To: Lennart Borgman; +Cc: 5374
Lennart Borgman <lennart.borgman@gmail.com> writes:
> On Tue, Jul 12, 2011 at 02:15, Glenn Morris <rgm@gnu.org> wrote:
>> Lennart Borgman wrote:
>>
>>> Should really vc-find-file-hook be in find-file-hook when Emacs is run
>>> in batch? Could not that create problems?
>>
>> Can you give an example of a problem?
>
> In some cases I run a lot of batch jobs from Emacs (to be sure about
> what is loaded in Emacs).
This is not an example of problem. Can you give an example of a problem
that vc-find-file-hook causes?
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#5374: vc-find-file-hook in batch?
2011-07-12 16:03 ` Chong Yidong
@ 2011-07-12 16:17 ` Lennart Borgman
2011-07-15 22:05 ` Glenn Morris
0 siblings, 1 reply; 7+ messages in thread
From: Lennart Borgman @ 2011-07-12 16:17 UTC (permalink / raw)
To: Chong Yidong; +Cc: 5374
On Tue, Jul 12, 2011 at 18:03, Chong Yidong <cyd@stupidchicken.com> wrote:
> Lennart Borgman <lennart.borgman@gmail.com> writes:
>
>> On Tue, Jul 12, 2011 at 02:15, Glenn Morris <rgm@gnu.org> wrote:
>>> Lennart Borgman wrote:
>>>
>>>> Should really vc-find-file-hook be in find-file-hook when Emacs is run
>>>> in batch? Could not that create problems?
>>>
>>> Can you give an example of a problem?
>>
>> In some cases I run a lot of batch jobs from Emacs (to be sure about
>> what is loaded in Emacs).
>
> This is not an example of problem. Can you give an example of a problem
> that vc-find-file-hook causes?
It takes a lot of time to run the hook in this case, but other than
that I see no problem.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#5374: vc-find-file-hook in batch?
2011-07-12 16:17 ` Lennart Borgman
@ 2011-07-15 22:05 ` Glenn Morris
2011-07-18 14:44 ` Stefan Monnier
0 siblings, 1 reply; 7+ messages in thread
From: Glenn Morris @ 2011-07-15 22:05 UTC (permalink / raw)
To: 5374-done
Lennart Borgman wrote:
> It takes a lot of time to run the hook in this case, but other than
> that I see no problem.
OK. I don't think is reason enough to remove vc-find-file-hook in batch
mode though. You can always remove it in your own personal use if you
feel it necessary.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#5374: vc-find-file-hook in batch?
2011-07-15 22:05 ` Glenn Morris
@ 2011-07-18 14:44 ` Stefan Monnier
0 siblings, 0 replies; 7+ messages in thread
From: Stefan Monnier @ 2011-07-18 14:44 UTC (permalink / raw)
To: 5374
>> It takes a lot of time to run the hook in this case, but other than
>> that I see no problem.
> OK. I don't think is reason enough to remove vc-find-file-hook in batch
> mode though. You can always remove it in your own personal use if you
> feel it necessary.
If it's a performance problem, the right fix is to profile it, find the
culprit and fix it. Disabling vc-find-file-hook would just workaround
the problem.
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-07-18 14:44 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-01-13 10:28 bug#5374: vc-find-file-hook in batch? Lennart Borgman
2011-07-12 0:15 ` Glenn Morris
2011-07-12 11:08 ` Lennart Borgman
2011-07-12 16:03 ` Chong Yidong
2011-07-12 16:17 ` Lennart Borgman
2011-07-15 22:05 ` Glenn Morris
2011-07-18 14:44 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).