* bug#30060: mh-send-letter coding-system selection
@ 2018-01-10 6:50 Glenn Morris
0 siblings, 0 replies; 2+ messages in thread
From: Glenn Morris @ 2018-01-10 6:50 UTC (permalink / raw)
To: 30060
Package: emacs,mh-e
Version: 26.0.90
Severity: minor
mh-send-letter contains the following for selecting a coding system:
(coding-system-for-write
(if (and (local-variable-p 'buffer-file-coding-system
(current-buffer)) ;XEmacs needs two args
;; We're not sure why, but buffer-file-coding-system
;; tends to get set to undecided-unix.
(not (memq buffer-file-coding-system
'(undecided undecided-unix undecided-dos))))
buffer-file-coding-system
(or (and (boundp 'sendmail-coding-system) sendmail-coding-system)
(and (default-boundp 'buffer-file-coding-system)
(default-value 'buffer-file-coding-system))
'iso-latin-1))))
This is similar to, but not quite the same as, the standard Emacs
function select-message-coding-system that exists specifically for this
purpose. Eg the mh-e version does not consult default-sendmail-coding-system.
It would be great if mh-e could use the standard function, or if not
have some comments added to the code explaining the reason(s) for the
difference(s).
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#30060: mh-send-letter coding-system selection
[not found] <x2efmy6wc2.fsf@fencepost.gnu.org>
@ 2018-01-10 15:28 ` Eli Zaretskii
0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2018-01-10 15:28 UTC (permalink / raw)
To: Glenn Morris; +Cc: 30060
> From: Glenn Morris <rgm@gnu.org>
> Date: Wed, 10 Jan 2018 01:50:53 -0500
>
> (coding-system-for-write
> (if (and (local-variable-p 'buffer-file-coding-system
> (current-buffer)) ;XEmacs needs two args
> ;; We're not sure why, but buffer-file-coding-system
> ;; tends to get set to undecided-unix.
> (not (memq buffer-file-coding-system
> '(undecided undecided-unix undecided-dos))))
> buffer-file-coding-system
> (or (and (boundp 'sendmail-coding-system) sendmail-coding-system)
> (and (default-boundp 'buffer-file-coding-system)
> (default-value 'buffer-file-coding-system))
> 'iso-latin-1))))
>
> This is similar to, but not quite the same as, the standard Emacs
> function select-message-coding-system that exists specifically for this
> purpose. Eg the mh-e version does not consult default-sendmail-coding-system.
>
> It would be great if mh-e could use the standard function
Indeed.
> or if not have some comments added to the code explaining the
> reason(s) for the difference(s).
I'd be surprised to hear there are any reasons except some historical
accident.
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-10 15:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-10 6:50 bug#30060: mh-send-letter coding-system selection Glenn Morris
[not found] <x2efmy6wc2.fsf@fencepost.gnu.org>
2018-01-10 15:28 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).