Apple event opens file at wrong line; patch included

Apple event opens file at wrong line; patch included

[Dan Knapp]

[-- Attachment #1: Type: text/plain, Size: 3409 bytes --]

(This is a re-send; the original was, perhaps, caught by the spam trap
because I wasn't subscribed to the list?)

Go to XCode and configure it to use Emacs.app as an external editor.
 Compile a file which produces errors or warnings.  Double-click one of them
in the build window.  Emacs.app comes to the foreground and activates a
buffer with that file, going to the line immediately preceding the one it
should be on.

I took the liberty of fixing this on my copy, and am hoping the fix can be
rolled into upstream:

diff  /tmp/mac-win.old.el /tmp/mac-win.el
1742c1742
<                  (goto-line line)
---
>                  (goto-line (+ 1 line))
Diff finished.  Thu Apr 10 14:48:21 2008


This should be applied against the file
/Applications/Emacs.app/Contents/Resources/lisp/term/mac-win.el

Thanks in advance.



In GNU Emacs 22.1.50.1 (i386-apple-darwin8.10.1, Carbon Version 1.6.0)
of 2007-11-06 on seijiz.local
Windowing system distributor `Apple Inc.', version 10.5.2
configured using `configure
 '--prefix=/Applications/Emacs.app/Contents/Resources' '--with-carbon'
'--without-x' '--libexecdir=/Volumes/Emacs/Emacs.app/Contents/MacOS/libexec'
'CFLAGS=-arch i386 -arch ppc -isysroot /Developer/SDKs/MacOSX10.4u.sdk
-DUSE_ATSUI -DUSE_MAC_TSM''

Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: nil
locale-coding-system: iso-8859-1
default-enable-multibyte-characters: t

Major mode: Diff

Minor modes in effect:
encoded-kbd-mode: t
iswitchb-mode: t
desktop-save-mode: t
mac-print-mode: t
tooltip-mode: t
mouse-wheel-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
unify-8859-on-encoding-mode: t
utf-translate-cjk-mode: t
auto-compression-mode: t
line-number-mode: t

Recent input:
C-n C-p <tab> <return> C-x 1 C-n C-n C-n M-f M-f M-f
M-f M-b M-b C-a M-< C-s l i n e C-s C-s C-s C-s C-s
C-r C-r C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s
C-s C-s C-s C-s C-s C-s C-s C-s C-s C-s C-a C-p C-l
C-p C-l C-p C-l C-n C-n C-n C-e M-b ( + SPC 1 SPC C-e
) C-n C-n C-n C-n C-n C-n C-n C-n C-e C-M-b C-M-f C-x
C-e M-x c o m p i l e - f i <tab> <backspace> <backspace>
e <tab> <backspace> <tab> <tab> <M-backspace> b y t
e - c o n m p <backspace> <backspace> <backspace> m
p <tab> <tab> <tab> <return> m a c <tab> w <tab> <return>
y C-x b <return> C-M-b C-n C-n C-l C-x 1 C-p C-x C-w
/ t m p / m a c - w i n . e l <return> C-x C-f / t
m p / C-g C-x C-f / t m p / m a c - w i n <tab> <return>
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n
C-n C-n C-n M-f M-f C-k SPC l i n e ) C-_ C-_ C-k SPC
i n e ) <backspace> <backspace> <backspace> <backspace>
l i n e ) C-x C-w m a c - w i n . o l d . e l <return>
C-x b e s h <return> p u s h d SPC / t m p <return>
l s <return> d i f SPC m a c <backspace> <backspace>
<backspace> <backspace> f SPC m a c - w i n <tab> SPC
m a c <tab> <return> M-x r e p o <tab> r t - e m <tab>
<return>

Recent messages:
Saving file /tmp/mac-win.el...
Wrote /tmp/mac-win.el
Quit
Undo! [2 times]
Saving file /tmp/mac-win.old.el...
Wrote /tmp/mac-win.old.el
Loading diff...done
Loading diff-mode...done
Making completion list...
Loading emacsbug...done



-- 
Dan Knapp
"An infallible method of conciliating a tiger is to allow oneself to be
devoured." (Konrad Adenauer)

[-- Attachment #2: Type: text/html, Size: 4336 bytes --]

Re: Apple event opens file at wrong line; patch included

[YAMAMOTO Mitsuharu]

>>>>> On Fri, 11 Apr 2008 06:59:57 -0400, "Dan Knapp" <dankna@gmail.com> said:

> Go to XCode and configure it to use Emacs.app as an external editor.
> Compile a file which produces errors or warnings.  Double-click one
> of them in the build window.  Emacs.app comes to the foreground and
> activates a buffer with that file, going to the line immediately
> preceding the one it should be on.

Thanks for reporting this.  I've installed the fix (with adjustments
for other parameters) to the CVS, EMACS_22_BASE branch.

> (This is a re-send; the original was, perhaps, caught by the spam
> trap because I wasn't subscribed to the list?)

I don't know about the spam trap, but I think the subscription is
supposed to be unnecessary to post here.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp