unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: rms@gnu.org
Cc: monnier@IRO.UMontreal.CA, 2137@emacsbugs.donarmstrong.com
Subject: bug#2137: 23.0.60; Saving Rmail buffer does not show the "Saving file ..." message
Date: Wed, 04 Feb 2009 22:12:47 +0200	[thread overview]
Message-ID: <uzlh2t0zk.fsf@gnu.org> (raw)
In-Reply-To: <E1LUmTV-0000Gb-QB@fencepost.gnu.org>

> From: Richard M Stallman <rms@gnu.org>
> CC: eliz@gnu.org, rgm@gnu.org, 2137@emacsbugs.donarmstrong.com
> Date: Wed, 04 Feb 2009 13:27:49 -0500
> 
>     > IMO, using annotations for the job of saving the mailbox is also a
>     > horrible kludge.  All that just to avoid defining an Rmail-specific
>     > binding for C-x C-s ...
> 
>     Thanks for your support,
> 
> An Rmail-specific binding for C-x C-s is not enough to make saving
> work correctly.  Users can save the file through C-x s also, and other
> commands too.  The common mechanism for these commands is
> `save-buffer'; whatever makes them save the right text has to work
> inside there.

So we could introduce some mechanism specific for such situation, like
some hook that save-buffer would call or something.  Annotations just
aren't that mechanism, they exist to add text to the buffer before it
is written.

>      we could add to
>     rmail-write-region-annotate another hack: a call to buffer-size
>     followed by the same message "Saving file ..." that should have been
>     displayed by save-buffer.
> 
> The difficulty here is to display that message only in the case
> where the hook was ultimately called from `save-buffer'.

rmail-write-region-annotate uses its first argument to deduce that it
is being called to write the entire buffer.  Why couldn't the same
logic be used for the message?






  parent reply	other threads:[~2009-02-04 20:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <ud4dutuhg.fsf@gnu.org>
2009-01-31 19:13 ` bug#2137: 23.0.60; Saving Rmail buffer does not show the "Saving file ..." message Eli Zaretskii
     [not found]   ` <E1LTl7F-00057o-7k@fencepost.gnu.org>
2009-02-02  1:35     ` Stefan Monnier
     [not found]     ` <jwv3aex62t7.fsf-monnier+emacsbugreports@gnu.org>
2009-02-02 21:05       ` Eli Zaretskii
     [not found]       ` <umyd4v9bs.fsf@gnu.org>
2009-02-03  4:12         ` Glenn Morris
2009-02-03 19:31           ` Eli Zaretskii
2009-02-03 21:26             ` Stefan Monnier
2009-02-04  4:23               ` Eli Zaretskii
2009-02-04 18:29                 ` Eli Zaretskii
2009-02-04 18:27               ` Richard M Stallman
2009-02-04 19:49                 ` Stefan Monnier
2009-02-04 20:14                   ` Eli Zaretskii
2009-02-04 23:21                     ` Stefan Monnier
2009-02-05 16:39                   ` Richard M Stallman
2009-02-04 20:12                 ` Eli Zaretskii [this message]
2009-02-03 21:29         ` Stefan Monnier
     [not found]         ` <jwvk587p5y5.fsf-monnier+emacsbugreports@gnu.org>
2009-02-04  4:16           ` Eli Zaretskii
     [not found]           ` <u7i46vnun.fsf@gnu.org>
2009-02-04 19:46             ` Stefan Monnier
2009-02-03  9:59       ` Richard M Stallman
     [not found]       ` <E1LUI48-0004DQ-9b@fencepost.gnu.org>
2009-02-03 19:39         ` Eli Zaretskii
2009-02-07 10:35   ` bug#2137: marked as done (23.0.60; Saving Rmail buffer does not show the "Saving file ..." message) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=uzlh2t0zk.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=2137@emacsbugs.donarmstrong.com \
    --cc=monnier@IRO.UMontreal.CA \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).