unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org, rms@gnu.org, 2137@emacsbugs.donarmstrong.com
Subject: bug#2137: 23.0.60; Saving Rmail buffer does not show the "Saving file ..." message
Date: Tue, 03 Feb 2009 16:29:08 -0500	[thread overview]
Message-ID: <jwvk587p5y5.fsf-monnier+emacsbugreports__22359.1278576807$1233697863$gmane$org@gnu.org> (raw)
In-Reply-To: <umyd4v9bs.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 02 Feb 2009 23:05:11 +0200")

>> This problem at least simply points to a current bug in save-buffer.
> Which bug is that?

The bug is that is uses buffer-size to determine the size of the file,
without taking into account the fact that
write-region-annotate-functions can add lot of stuff to the file that's
not in the buffer's text.

The simplest fix is to simply always output the message rather than only
for files larger than 50KB.
The more difficult one is to move the message from save-buffer to
write-region.


        Stefan






  parent reply	other threads:[~2009-02-03 21:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <ud4dutuhg.fsf@gnu.org>
2009-01-31 19:13 ` bug#2137: 23.0.60; Saving Rmail buffer does not show the "Saving file ..." message Eli Zaretskii
     [not found]   ` <E1LTl7F-00057o-7k@fencepost.gnu.org>
2009-02-02  1:35     ` Stefan Monnier
     [not found]     ` <jwv3aex62t7.fsf-monnier+emacsbugreports@gnu.org>
2009-02-02 21:05       ` Eli Zaretskii
     [not found]       ` <umyd4v9bs.fsf@gnu.org>
2009-02-03  4:12         ` Glenn Morris
2009-02-03 19:31           ` Eli Zaretskii
2009-02-03 21:26             ` Stefan Monnier
2009-02-04  4:23               ` Eli Zaretskii
2009-02-04 18:29                 ` Eli Zaretskii
2009-02-04 18:27               ` Richard M Stallman
2009-02-04 19:49                 ` Stefan Monnier
2009-02-04 20:14                   ` Eli Zaretskii
2009-02-04 23:21                     ` Stefan Monnier
2009-02-05 16:39                   ` Richard M Stallman
2009-02-04 20:12                 ` Eli Zaretskii
2009-02-03 21:29         ` Stefan Monnier [this message]
     [not found]         ` <jwvk587p5y5.fsf-monnier+emacsbugreports@gnu.org>
2009-02-04  4:16           ` Eli Zaretskii
     [not found]           ` <u7i46vnun.fsf@gnu.org>
2009-02-04 19:46             ` Stefan Monnier
2009-02-03  9:59       ` Richard M Stallman
     [not found]       ` <E1LUI48-0004DQ-9b@fencepost.gnu.org>
2009-02-03 19:39         ` Eli Zaretskii
2009-02-07 10:35   ` bug#2137: marked as done (23.0.60; Saving Rmail buffer does not show the "Saving file ..." message) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='jwvk587p5y5.fsf-monnier+emacsbugreports__22359.1278576807$1233697863$gmane$org@gnu.org' \
    --to=monnier@iro.umontreal.ca \
    --cc=2137@emacsbugs.donarmstrong.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).