* bug#56549: 28.1; Compilation failure for lib-src/seccomp-filter.c on x86_64 with 32 bit userspace
@ 2022-07-14 6:46 Ulrich Mueller
2022-07-15 15:42 ` Philipp Stephani
0 siblings, 1 reply; 6+ messages in thread
From: Ulrich Mueller @ 2022-07-14 6:46 UTC (permalink / raw)
To: 56549
Forwarding Gentoo bug https://bugs.gentoo.org/857906:
i686-pc-linux-gnu-gcc -I. -I../src -I../lib -I. -I./../src -I./../lib -Wl,-O1 -Wl,--as-needed -mtune=i686 -O2 -pipe seccomp-filter.c \
-lseccomp -o seccomp-filter
In file included from seccomp-filter.c:62:
seccomp-filter.c: In function 'main':
../lib/verify.h:213:41: error: static assertion failed: "verify (sizeof (long) == 8 && LONG_MIN == INT64_MIN && LONG_MAX == INT64_MAX)"
213 | # define _GL_VERIFY(R, DIAGNOSTIC, ...) _Static_assert (R, DIAGNOSTIC)
| ^~~~~~~~~~~~~~
../lib/verify.h:273:20: note: in expansion of macro '_GL_VERIFY'
273 | # define verify(R) _GL_VERIFY (R, "verify (" #R ")", -)
| ^~~~~~~~~~
seccomp-filter.c:173:3: note: in expansion of macro 'verify'
173 | verify (sizeof (long) == 8 && LONG_MIN == INT64_MIN
| ^~~~~~
../lib/verify.h:213:41: error: static assertion failed: "verify (sizeof (void *) == 8)"
213 | # define _GL_VERIFY(R, DIAGNOSTIC, ...) _Static_assert (R, DIAGNOSTIC)
| ^~~~~~~~~~~~~~
...
seccomp-filter.c:175:3: note: in expansion of macro 'verify'
175 | verify (sizeof (void *) == 8);
| ^~~~~~
make[1]: *** [Makefile:435: seccomp-filter] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/var/tmp/portage/app-editors/emacs-28.1/work/emacs-28.1/lib-src'
make: *** [Makefile:436: lib-src] Error 2
This is on an x86_64 machine with 32 bit userspace.
AFAICS, the problem is that lib-src/seccomp-filter.c (line 173) tests
for a 64 bit userspace:
verify (sizeof (long) == 8 && LONG_MIN == INT64_MIN
&& LONG_MAX == INT64_MAX);
However, lib_src/Makefile.in (line 203) tests for 64 bit hardware:
ifeq ($(shell uname -m),x86_64)
[...]
SECCOMP_FILTER=1
endif
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#56549: 28.1; Compilation failure for lib-src/seccomp-filter.c on x86_64 with 32 bit userspace
2022-07-14 6:46 bug#56549: 28.1; Compilation failure for lib-src/seccomp-filter.c on x86_64 with 32 bit userspace Ulrich Mueller
@ 2022-07-15 15:42 ` Philipp Stephani
2022-07-15 15:58 ` Philipp Stephani
2022-07-15 16:02 ` Ulrich Mueller
0 siblings, 2 replies; 6+ messages in thread
From: Philipp Stephani @ 2022-07-15 15:42 UTC (permalink / raw)
To: Ulrich Mueller; +Cc: 56549
Am Do., 14. Juli 2022 um 08:47 Uhr schrieb Ulrich Mueller <ulm@gentoo.org>:
>
> Forwarding Gentoo bug https://bugs.gentoo.org/857906:
>
> i686-pc-linux-gnu-gcc -I. -I../src -I../lib -I. -I./../src -I./../lib -Wl,-O1 -Wl,--as-needed -mtune=i686 -O2 -pipe seccomp-filter.c \
> -lseccomp -o seccomp-filter
> In file included from seccomp-filter.c:62:
> seccomp-filter.c: In function 'main':
> ../lib/verify.h:213:41: error: static assertion failed: "verify (sizeof (long) == 8 && LONG_MIN == INT64_MIN && LONG_MAX == INT64_MAX)"
> 213 | # define _GL_VERIFY(R, DIAGNOSTIC, ...) _Static_assert (R, DIAGNOSTIC)
> | ^~~~~~~~~~~~~~
> ../lib/verify.h:273:20: note: in expansion of macro '_GL_VERIFY'
> 273 | # define verify(R) _GL_VERIFY (R, "verify (" #R ")", -)
> | ^~~~~~~~~~
> seccomp-filter.c:173:3: note: in expansion of macro 'verify'
> 173 | verify (sizeof (long) == 8 && LONG_MIN == INT64_MIN
> | ^~~~~~
> ../lib/verify.h:213:41: error: static assertion failed: "verify (sizeof (void *) == 8)"
> 213 | # define _GL_VERIFY(R, DIAGNOSTIC, ...) _Static_assert (R, DIAGNOSTIC)
> | ^~~~~~~~~~~~~~
> ...
> seccomp-filter.c:175:3: note: in expansion of macro 'verify'
> 175 | verify (sizeof (void *) == 8);
> | ^~~~~~
> make[1]: *** [Makefile:435: seccomp-filter] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make[1]: Leaving directory '/var/tmp/portage/app-editors/emacs-28.1/work/emacs-28.1/lib-src'
> make: *** [Makefile:436: lib-src] Error 2
>
> This is on an x86_64 machine with 32 bit userspace.
>
>
> AFAICS, the problem is that lib-src/seccomp-filter.c (line 173) tests
> for a 64 bit userspace:
>
> verify (sizeof (long) == 8 && LONG_MIN == INT64_MIN
> && LONG_MAX == INT64_MAX);
>
> However, lib_src/Makefile.in (line 203) tests for 64 bit hardware:
>
> ifeq ($(shell uname -m),x86_64)
> [...]
> SECCOMP_FILTER=1
> endif
Thanks for the report. Is there a good way to test for a 64-bit
userspace? Probably we want both tests.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#56549: 28.1; Compilation failure for lib-src/seccomp-filter.c on x86_64 with 32 bit userspace
2022-07-15 15:42 ` Philipp Stephani
@ 2022-07-15 15:58 ` Philipp Stephani
2022-07-15 19:42 ` Ulrich Mueller
2022-07-15 16:02 ` Ulrich Mueller
1 sibling, 1 reply; 6+ messages in thread
From: Philipp Stephani @ 2022-07-15 15:58 UTC (permalink / raw)
To: Ulrich Mueller; +Cc: 56549
Am Fr., 15. Juli 2022 um 17:42 Uhr schrieb Philipp Stephani
<p.stephani2@gmail.com>:
>
> Am Do., 14. Juli 2022 um 08:47 Uhr schrieb Ulrich Mueller <ulm@gentoo.org>:
> >
> > Forwarding Gentoo bug https://bugs.gentoo.org/857906:
> >
> > i686-pc-linux-gnu-gcc -I. -I../src -I../lib -I. -I./../src -I./../lib -Wl,-O1 -Wl,--as-needed -mtune=i686 -O2 -pipe seccomp-filter.c \
> > -lseccomp -o seccomp-filter
> > In file included from seccomp-filter.c:62:
> > seccomp-filter.c: In function 'main':
> > ../lib/verify.h:213:41: error: static assertion failed: "verify (sizeof (long) == 8 && LONG_MIN == INT64_MIN && LONG_MAX == INT64_MAX)"
> > 213 | # define _GL_VERIFY(R, DIAGNOSTIC, ...) _Static_assert (R, DIAGNOSTIC)
> > | ^~~~~~~~~~~~~~
> > ../lib/verify.h:273:20: note: in expansion of macro '_GL_VERIFY'
> > 273 | # define verify(R) _GL_VERIFY (R, "verify (" #R ")", -)
> > | ^~~~~~~~~~
> > seccomp-filter.c:173:3: note: in expansion of macro 'verify'
> > 173 | verify (sizeof (long) == 8 && LONG_MIN == INT64_MIN
> > | ^~~~~~
> > ../lib/verify.h:213:41: error: static assertion failed: "verify (sizeof (void *) == 8)"
> > 213 | # define _GL_VERIFY(R, DIAGNOSTIC, ...) _Static_assert (R, DIAGNOSTIC)
> > | ^~~~~~~~~~~~~~
> > ...
> > seccomp-filter.c:175:3: note: in expansion of macro 'verify'
> > 175 | verify (sizeof (void *) == 8);
> > | ^~~~~~
> > make[1]: *** [Makefile:435: seccomp-filter] Error 1
> > make[1]: *** Waiting for unfinished jobs....
> > make[1]: Leaving directory '/var/tmp/portage/app-editors/emacs-28.1/work/emacs-28.1/lib-src'
> > make: *** [Makefile:436: lib-src] Error 2
> >
> > This is on an x86_64 machine with 32 bit userspace.
> >
> >
> > AFAICS, the problem is that lib-src/seccomp-filter.c (line 173) tests
> > for a 64 bit userspace:
> >
> > verify (sizeof (long) == 8 && LONG_MIN == INT64_MIN
> > && LONG_MAX == INT64_MAX);
> >
> > However, lib_src/Makefile.in (line 203) tests for 64 bit hardware:
> >
> > ifeq ($(shell uname -m),x86_64)
> > [...]
> > SECCOMP_FILTER=1
> > endif
>
> Thanks for the report. Is there a good way to test for a 64-bit
> userspace? Probably we want both tests.
I've now tried fixing this with commit db259d8fd369e6036df782d5fe51723a68220074.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#56549: 28.1; Compilation failure for lib-src/seccomp-filter.c on x86_64 with 32 bit userspace
2022-07-15 15:42 ` Philipp Stephani
2022-07-15 15:58 ` Philipp Stephani
@ 2022-07-15 16:02 ` Ulrich Mueller
1 sibling, 0 replies; 6+ messages in thread
From: Ulrich Mueller @ 2022-07-15 16:02 UTC (permalink / raw)
To: Philipp Stephani; +Cc: 56549
>>>>> On Fri, 15 Jul 2022, Philipp Stephani wrote:
> Thanks for the report. Is there a good way to test for a 64-bit
> userspace? Probably we want both tests.
Autoconf has AC_CHECK_SIZEOF, so you could check for the size of either
long or void *.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#56549: 28.1; Compilation failure for lib-src/seccomp-filter.c on x86_64 with 32 bit userspace
2022-07-15 15:58 ` Philipp Stephani
@ 2022-07-15 19:42 ` Ulrich Mueller
2022-07-16 10:50 ` Philipp Stephani
0 siblings, 1 reply; 6+ messages in thread
From: Ulrich Mueller @ 2022-07-15 19:42 UTC (permalink / raw)
To: Philipp Stephani; +Cc: 56549
>>>>> On Fri, 15 Jul 2022, Philipp Stephani wrote:
> I've now tried fixing this with commit db259d8fd369e6036df782d5fe51723a68220074.
Thank you, this fixes the problem for me.
I have tested it on the same system where the bug was originally seen.
This is an amd64 system with 64 bit kernel but 32 bit userspace:
In GNU Emacs 28.1.90 (build 1, i686-pc-linux-gnu)
of 2022-07-15 built on woodpecker
Repository revision: db259d8fd369e6036df782d5fe51723a68220074
Repository branch: emacs-28
System Description: Gentoo/Linux
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#56549: 28.1; Compilation failure for lib-src/seccomp-filter.c on x86_64 with 32 bit userspace
2022-07-15 19:42 ` Ulrich Mueller
@ 2022-07-16 10:50 ` Philipp Stephani
0 siblings, 0 replies; 6+ messages in thread
From: Philipp Stephani @ 2022-07-16 10:50 UTC (permalink / raw)
To: Ulrich Mueller; +Cc: 56549-done
> Am 15.07.2022 um 21:42 schrieb Ulrich Mueller <ulm@gentoo.org>:
>
>>>>>> On Fri, 15 Jul 2022, Philipp Stephani wrote:
>
>> I've now tried fixing this with commit db259d8fd369e6036df782d5fe51723a68220074.
>
> Thank you, this fixes the problem for me.
Thanks, closing this bug then.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-07-16 10:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-14 6:46 bug#56549: 28.1; Compilation failure for lib-src/seccomp-filter.c on x86_64 with 32 bit userspace Ulrich Mueller
2022-07-15 15:42 ` Philipp Stephani
2022-07-15 15:58 ` Philipp Stephani
2022-07-15 19:42 ` Ulrich Mueller
2022-07-16 10:50 ` Philipp Stephani
2022-07-15 16:02 ` Ulrich Mueller
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).