From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>,
2631@emacsbugs.donarmstrong.com
Cc: user42@zip.com.au
Subject: bug#2631: get-free-disk-space when default-directory doesn't exist
Date: Wed, 11 Mar 2009 06:23:49 +0200 [thread overview]
Message-ID: <u3adklmay.fsf@gnu.org> (raw)
In-Reply-To: <jwvhc20g6bj.fsf-monnier+emacsbugreports@gnu.org>
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Tue, 10 Mar 2009 22:10:13 -0400
> Cc: bug-gnu-emacs@gnu.org, 2631@emacsbugs.donarmstrong.com
>
> > *** files.el 11 Mar 2009 08:46:04 +1100 1.1038
> > --- files.el 11 Mar 2009 09:14:14 +1100
> > ***************
> > *** 5336,5345 ****
> > (save-match-data
> > (with-temp-buffer
> > (when (and directory-free-space-program
> > ! (eq 0 (call-process directory-free-space-program
> > ! nil t nil
> > ! directory-free-space-args
> > ! dir)))
> > ;; Usual format is a header line followed by a line of
> > ;; numbers.
> > (goto-char (point-min))
> > --- 5336,5346 ----
> > (save-match-data
> > (with-temp-buffer
> > (when (and directory-free-space-program
> > ! (let ((default-directory "/"))
> > ! (eq 0 (call-process directory-free-space-program
> > ! nil t nil
> > ! directory-free-space-args
> > ! dir))))
> > ;; Usual format is a header line followed by a line of
> > ;; numbers.
> > (goto-char (point-min))
>
> That would probably work OK, but why not bind default-directory to dir?
Yes, this is much better, since "/" is not guaranteed to work
(accessibility and stuff).
> And even use process-file, while we're at it, so it has a chance to work
> on Tramp.
Even better.
next prev parent reply other threads:[~2009-03-11 4:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87d4cjzf89.fsf@cyd.mit.edu>
2009-03-10 22:24 ` bug#2631: get-free-disk-space when default-directory doesn't exist Kevin Ryde
2009-03-11 2:10 ` Stefan Monnier
2009-03-11 4:23 ` Eli Zaretskii [this message]
2009-03-11 21:00 ` Kevin Ryde
2009-03-15 2:40 ` bug#2631: marked as done (get-free-disk-space when default-directory doesn't exist) Emacs bug Tracking System
2009-08-16 0:40 ` bug#2631: marked as done (get-free-disk-space when home dir also " Emacs bug Tracking System
2009-03-17 0:02 ` bug#2631: get-free-disk-space when default-directory doesn't exist Kevin Ryde
2009-03-17 4:05 ` Eli Zaretskii
2009-03-27 23:32 ` Kevin Ryde
2009-03-27 23:17 ` Kevin Ryde
2009-03-27 23:25 ` Processed: " Emacs bug Tracking System
[not found] <871vnclhoz.fsf@cyd.mit.edu>
2009-07-23 22:19 ` bug#3911: 23.1.50; get-free-disk-space relative to non-existent default-directory Kevin Ryde
2009-08-16 0:40 ` bug#3911: marked as done (23.1.50; get-free-disk-space relative to non-existent default-directory) Emacs bug Tracking System
2009-10-02 0:35 ` bug#3911: marked as done (get-free-disk-space race condition on default-directory test) Emacs bug Tracking System
2009-08-18 0:23 ` bug#3911: get-free-disk-space when default-directory doesn't exist Kevin Ryde
2009-08-18 1:02 ` Chong Yidong
2009-08-19 21:43 ` Kevin Ryde
2009-08-19 22:03 ` Kevin Ryde
2009-08-22 3:57 ` Stefan Monnier
2009-08-24 23:45 ` Kevin Ryde
2009-08-25 18:29 ` Stefan Monnier
2009-08-29 1:32 ` Kevin Ryde
2009-08-29 3:37 ` Stefan Monnier
2009-09-01 1:37 ` Kevin Ryde
2009-09-01 6:05 ` Stefan Monnier
2009-09-07 0:28 ` Kevin Ryde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=u3adklmay.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=2631@emacsbugs.donarmstrong.com \
--cc=monnier@iro.umontreal.ca \
--cc=user42@zip.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).