From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#2631: get-free-disk-space when default-directory doesn't exist Date: Wed, 11 Mar 2009 06:23:49 +0200 Message-ID: References: <87wsaxhv97.fsf@blah.blah> Reply-To: Eli Zaretskii , 2631@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1236746664 1721 80.91.229.12 (11 Mar 2009 04:44:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 11 Mar 2009 04:44:24 +0000 (UTC) Cc: user42@zip.com.au To: Stefan Monnier , 2631@emacsbugs.donarmstrong.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 11 05:45:40 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LhGK2-0001d4-Dr for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Mar 2009 05:45:38 +0100 Original-Received: from localhost ([127.0.0.1]:33406 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LhGIg-0000Fc-GK for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Mar 2009 00:44:14 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LhGIE-0008Sd-I2 for bug-gnu-emacs@gnu.org; Wed, 11 Mar 2009 00:43:46 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LhGID-0008S3-41 for bug-gnu-emacs@gnu.org; Wed, 11 Mar 2009 00:43:45 -0400 Original-Received: from [199.232.76.173] (port=37088 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LhGIC-0008S0-UU for bug-gnu-emacs@gnu.org; Wed, 11 Mar 2009 00:43:44 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:37654) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LhGIC-0003EJ-Cf for bug-gnu-emacs@gnu.org; Wed, 11 Mar 2009 00:43:44 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2B4hfPa028480; Tue, 10 Mar 2009 21:43:41 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n2B4U5gn025041; Tue, 10 Mar 2009 21:30:05 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Eli Zaretskii Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 11 Mar 2009 04:30:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2631 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 2631-submit@emacsbugs.donarmstrong.com id=B2631.123674544223591 (code B ref 2631); Wed, 11 Mar 2009 04:30:05 +0000 Original-Received: (at 2631) by emacsbugs.donarmstrong.com; 11 Mar 2009 04:24:02 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mtaout6.012.net.il (mtaout6.012.net.il [84.95.2.16]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2B4Nw7v023584 for <2631@emacsbugs.donarmstrong.com>; Tue, 10 Mar 2009 21:23:59 -0700 Original-Received: from conversion-daemon.i-mtaout6.012.net.il by i-mtaout6.012.net.il (HyperSendmail v2007.08) id <0KGB00C00QNZ9Y00@i-mtaout6.012.net.il> for 2631@emacsbugs.donarmstrong.com; Wed, 11 Mar 2009 06:24:35 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.127.228.91]) by i-mtaout6.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KGB00KT1QWZMOA0@i-mtaout6.012.net.il>; Wed, 11 Mar 2009 06:24:35 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Wed, 11 Mar 2009 00:43:45 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:26228 Archived-At: > From: Stefan Monnier > Date: Tue, 10 Mar 2009 22:10:13 -0400 > Cc: bug-gnu-emacs@gnu.org, 2631@emacsbugs.donarmstrong.com > > > *** files.el 11 Mar 2009 08:46:04 +1100 1.1038 > > --- files.el 11 Mar 2009 09:14:14 +1100 > > *************** > > *** 5336,5345 **** > > (save-match-data > > (with-temp-buffer > > (when (and directory-free-space-program > > ! (eq 0 (call-process directory-free-space-program > > ! nil t nil > > ! directory-free-space-args > > ! dir))) > > ;; Usual format is a header line followed by a line of > > ;; numbers. > > (goto-char (point-min)) > > --- 5336,5346 ---- > > (save-match-data > > (with-temp-buffer > > (when (and directory-free-space-program > > ! (let ((default-directory "/")) > > ! (eq 0 (call-process directory-free-space-program > > ! nil t nil > > ! directory-free-space-args > > ! dir)))) > > ;; Usual format is a header line followed by a line of > > ;; numbers. > > (goto-char (point-min)) > > That would probably work OK, but why not bind default-directory to dir? Yes, this is much better, since "/" is not guaranteed to work (accessibility and stuff). > And even use process-file, while we're at it, so it has a chance to work > on Tramp. Even better.