unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#7165: 24.0.50; rmail error "Invalid base64 data"
@ 2010-10-06  7:26 Kenichi Handa
  2010-10-09  1:15 ` Glenn Morris
  0 siblings, 1 reply; 3+ messages in thread
From: Kenichi Handa @ 2010-10-06  7:26 UTC (permalink / raw)
  To: 7165

While reading mails by rmail, I encountered "Invalid base64
data" error, and couldn't delete the message causing that
error.

This bug is very similar to bug#5441.  But unlike
mail-unquote-printable-region, base64-decode-region doesn't
have NOERROR arg and we have to use condition-case.  I
suggest this patch (to emacs-23).

=== modified file 'lisp/mail/rmail.el'
--- lisp/mail/rmail.el	2010-08-20 07:11:35 +0000
+++ lisp/mail/rmail.el	2010-10-06 07:22:53 +0000
@@ -2742,7 +2742,9 @@
 						 nil t 'unibyte)
 		  (message "Malformed MIME quoted-printable message")))
 	     ((and (string= character-coding "base64") is-text-message)
-	      (base64-decode-region (point-min) (point-max)))
+	      (condition-case err
+		  (base64-decode-region (point-min) (point-max))
+		(error (message "%s" (cdr err)))))
 	     ((eq character-coding 'uuencode)
 	      (error "uuencoded messages are not supported yet"))
 	     (t))

---
Kenichi Handa
handa@m17n.org





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#7165: 24.0.50; rmail error "Invalid base64 data"
  2010-10-06  7:26 bug#7165: 24.0.50; rmail error "Invalid base64 data" Kenichi Handa
@ 2010-10-09  1:15 ` Glenn Morris
  2010-10-14  4:28   ` Kenichi Handa
  0 siblings, 1 reply; 3+ messages in thread
From: Glenn Morris @ 2010-10-09  1:15 UTC (permalink / raw)
  To: Kenichi Handa; +Cc: 7165

Kenichi Handa wrote:

> I suggest this patch (to emacs-23).

If you are looking for feedback, this looks good to me.

> === modified file 'lisp/mail/rmail.el'
> --- lisp/mail/rmail.el	2010-08-20 07:11:35 +0000
> +++ lisp/mail/rmail.el	2010-10-06 07:22:53 +0000
> @@ -2742,7 +2742,9 @@
>  						 nil t 'unibyte)
>  		  (message "Malformed MIME quoted-printable message")))
>  	     ((and (string= character-coding "base64") is-text-message)
> -	      (base64-decode-region (point-min) (point-max)))
> +	      (condition-case err
> +		  (base64-decode-region (point-min) (point-max))
> +		(error (message "%s" (cdr err)))))
>  	     ((eq character-coding 'uuencode)
>  	      (error "uuencoded messages are not supported yet"))
>  	     (t))





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#7165: 24.0.50; rmail error "Invalid base64 data"
  2010-10-09  1:15 ` Glenn Morris
@ 2010-10-14  4:28   ` Kenichi Handa
  0 siblings, 0 replies; 3+ messages in thread
From: Kenichi Handa @ 2010-10-14  4:28 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 7165-done

In article <1c62xcgo8l.fsf@fencepost.gnu.org>, Glenn Morris <rgm@gnu.org> writes:

> Kenichi Handa wrote:
> > I suggest this patch (to emacs-23).

> If you are looking for feedback, this looks good to me.

Thank you for verifying it.  I've just committed it to emacs-23.

> > === modified file 'lisp/mail/rmail.el'
> > --- lisp/mail/rmail.el	2010-08-20 07:11:35 +0000
> > +++ lisp/mail/rmail.el	2010-10-06 07:22:53 +0000
> > @@ -2742,7 +2742,9 @@
> >  						 nil t 'unibyte)
> >  		  (message "Malformed MIME quoted-printable message")))
> >  	     ((and (string= character-coding "base64") is-text-message)
> > -	      (base64-decode-region (point-min) (point-max)))
> > +	      (condition-case err
> > +		  (base64-decode-region (point-min) (point-max))
> > +		(error (message "%s" (cdr err)))))
> >  	     ((eq character-coding 'uuencode)
> >  	      (error "uuencoded messages are not supported yet"))
> >  	     (t))

---
Kenichi Handa
handa@m17n.org





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-10-14  4:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-06  7:26 bug#7165: 24.0.50; rmail error "Invalid base64 data" Kenichi Handa
2010-10-09  1:15 ` Glenn Morris
2010-10-14  4:28   ` Kenichi Handa

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).