From: Kenichi Handa <handa@m17n.org>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: 8992@debbugs.gnu.org
Subject: bug#8992: 23.3.50; Wrong mouse highlight background ascent and height
Date: Thu, 15 Dec 2011 11:15:53 +0900 [thread overview]
Message-ID: <tl7k45yh95y.fsf@m17n.org> (raw)
In-Reply-To: <wlliwf0w42.wl%mituharu@math.s.chiba-u.ac.jp> (message from YAMAMOTO Mitsuharu on Mon, 04 Jul 2011 08:42:37 +0900)
In article <wlliwf0w42.wl%mituharu@math.s.chiba-u.ac.jp>, YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> writes:
> Steps to reproduce:
> 1. $ emacs -q -fn courier
> 2. Move the mouse pointer over "Emacs Tutorial" in the splash screen.
> Result:
> Mouse highlight does not fill the whole background (see the first
> attachment).
> The patch below seems to work (see the second attachment). I think
> colors should be extracted from s->face, but font metrics should be
> obtained from s->font.
You are right. Thank you for the report and the patch.
I've just installed it. I checked the other XXX_draw
functions and it seems that they are doing the right thing.
---
Kenichi Handa
handa@m17n.org
> === modified file 'src/xftfont.c'
> *** src/xftfont.c 2011-02-02 02:15:29 +0000
> --- src/xftfont.c 2011-07-03 07:03:15 +0000
> ***************
> *** 689,695 ****
> if (with_background)
> XftDrawRect (xft_draw, &bg,
> ! x, y - face->font->ascent, s->width, face->font->height);
> code = alloca (sizeof (FT_UInt) * len);
> for (i = 0; i < len; i++)
> code[i] = ((XCHAR2B_BYTE1 (s->char2b + from + i) << 8)
> --- 689,695 ----
> if (with_background)
> XftDrawRect (xft_draw, &bg,
> ! x, y - s->font->ascent, s->width, s->font->height);
> code = alloca (sizeof (FT_UInt) * len);
> for (i = 0; i < len; i++)
> code[i] = ((XCHAR2B_BYTE1 (s->char2b + from + i) << 8)
prev parent reply other threads:[~2011-12-15 2:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-03 23:42 bug#8992: 23.3.50; Wrong mouse highlight background ascent and height YAMAMOTO Mitsuharu
2011-12-15 2:15 ` Kenichi Handa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tl7k45yh95y.fsf@m17n.org \
--to=handa@m17n.org \
--cc=8992@debbugs.gnu.org \
--cc=mituharu@math.s.chiba-u.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).