From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.bugs Subject: bug#8992: 23.3.50; Wrong mouse highlight background ascent and height Date: Thu, 15 Dec 2011 11:15:53 +0900 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1323915404 6461 80.91.229.12 (15 Dec 2011 02:16:44 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 15 Dec 2011 02:16:44 +0000 (UTC) Cc: 8992@debbugs.gnu.org To: YAMAMOTO Mitsuharu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 15 03:16:40 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Rb0sC-0006rs-5D for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Dec 2011 03:16:40 +0100 Original-Received: from localhost ([::1]:40263 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rb0sB-0000jr-AN for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Dec 2011 21:16:39 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:37492) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rb0s9-0000jj-Ft for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2011 21:16:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rb0s8-000334-4q for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2011 21:16:37 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37836) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rb0s8-000330-22 for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2011 21:16:36 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Rb0tW-0007NI-2L for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2011 21:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Kenichi Handa Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Dec 2011 02:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8992-submit@debbugs.gnu.org id=B8992.132391544828308 (code B ref 8992); Thu, 15 Dec 2011 02:18:02 +0000 Original-Received: (at 8992) by debbugs.gnu.org; 15 Dec 2011 02:17:28 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Rb0sy-0007MX-AM for submit@debbugs.gnu.org; Wed, 14 Dec 2011 21:17:28 -0500 Original-Received: from mx1.aist.go.jp ([150.29.246.133]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Rb0st-0007MK-SP for 8992@debbugs.gnu.org; Wed, 14 Dec 2011 21:17:26 -0500 Original-Received: from rqsmtp2.aist.go.jp (rqsmtp2.aist.go.jp [150.29.254.123]) by mx1.aist.go.jp with ESMTP id pBF2FssE000008; Thu, 15 Dec 2011 11:15:54 +0900 (JST) env-from (handa@m17n.org) Original-Received: from smtp4.aist.go.jp by rqsmtp2.aist.go.jp with ESMTP id pBF2Fs68002469; Thu, 15 Dec 2011 11:15:54 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp4.aist.go.jp with ESMTP id pBF2FrHU014854; Thu, 15 Dec 2011 11:15:53 +0900 (JST) env-from (handa@m17n.org) In-Reply-To: (message from YAMAMOTO Mitsuharu on Mon, 04 Jul 2011 08:42:37 +0900) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 14 Dec 2011 21:18:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:54971 Archived-At: In article , YAMAMOTO Mitsuharu writes: > Steps to reproduce: > 1. $ emacs -q -fn courier > 2. Move the mouse pointer over "Emacs Tutorial" in the splash screen. > Result: > Mouse highlight does not fill the whole background (see the first > attachment). > The patch below seems to work (see the second attachment). I think > colors should be extracted from s->face, but font metrics should be > obtained from s->font. You are right. Thank you for the report and the patch. I've just installed it. I checked the other XXX_draw functions and it seems that they are doing the right thing. --- Kenichi Handa handa@m17n.org > === modified file 'src/xftfont.c' > *** src/xftfont.c 2011-02-02 02:15:29 +0000 > --- src/xftfont.c 2011-07-03 07:03:15 +0000 > *************** > *** 689,695 **** > if (with_background) > XftDrawRect (xft_draw, &bg, > ! x, y - face->font->ascent, s->width, face->font->height); > code = alloca (sizeof (FT_UInt) * len); > for (i = 0; i < len; i++) > code[i] = ((XCHAR2B_BYTE1 (s->char2b + from + i) << 8) > --- 689,695 ---- > if (with_background) > XftDrawRect (xft_draw, &bg, > ! x, y - s->font->ascent, s->width, s->font->height); > code = alloca (sizeof (FT_UInt) * len); > for (i = 0; i < len; i++) > code[i] = ((XCHAR2B_BYTE1 (s->char2b + from + i) << 8)