unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#15622: eww: url-retrieve-internal: Wrong type argument: char-or-string-p, author
@ 2013-10-15 15:56 Svend Sorensen
  2013-10-15 20:50 ` Glenn Morris
  0 siblings, 1 reply; 3+ messages in thread
From: Svend Sorensen @ 2013-10-15 15:56 UTC (permalink / raw)
  To: 15622

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

eww-current-url is set to 'author when visiting a URL of a web page with no
title. This causes reload to fail.

To reproduce:

emacs -q

M-x eww
http://www.gnu.org/software/emacs/news/NEWS.24.3

M-x eww-reload
url-retrieve-internal: Wrong type argument: char-or-string-p, author

M-: eww-current-url
author

Emacs version:

GNU Emacs 24.3.50.1 (i386-apple-darwin12.5.0, NS apple-appkit-1187.40)
 of 2013-10-14 on ****

[-- Attachment #2: Type: text/html, Size: 747 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#15622: eww: url-retrieve-internal: Wrong type argument: char-or-string-p, author
  2013-10-15 15:56 bug#15622: eww: url-retrieve-internal: Wrong type argument: char-or-string-p, author Svend Sorensen
@ 2013-10-15 20:50 ` Glenn Morris
  2013-10-16  1:31   ` Glenn Morris
  0 siblings, 1 reply; 3+ messages in thread
From: Glenn Morris @ 2013-10-15 20:50 UTC (permalink / raw)
  To: Svend Sorensen; +Cc: 15622

Svend Sorensen wrote:

> eww-current-url is set to 'author when visiting a URL of a web page with no
> title. 

Actually I believe it is whenever it visits anything that is not of type
"text/html". This should fix it:

*** lisp/net/eww.el	2013-09-18 04:48:55 +0000
--- lisp/net/eww.el	2013-10-15 20:45:47 +0000
***************
*** 157,165 ****
  	   ((equal (car content-type) "text/html")
  	    (eww-display-html charset url))
  	   ((string-match "^image/" (car content-type))
! 	    (eww-display-image))
  	   (t
! 	    (eww-display-raw)))
  	  (setq eww-history-position 0)
  	  (cond
  	   (point
--- 157,167 ----
  	   ((equal (car content-type) "text/html")
  	    (eww-display-html charset url))
  	   ((string-match "^image/" (car content-type))
! 	    (eww-display-image)
! 	    (setq eww-current-url url))
  	   (t
! 	    (eww-display-raw)
! 	    (setq eww-current-url url)))
  	  (setq eww-history-position 0)
  	  (cond
  	   (point





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#15622: eww: url-retrieve-internal: Wrong type argument: char-or-string-p, author
  2013-10-15 20:50 ` Glenn Morris
@ 2013-10-16  1:31   ` Glenn Morris
  0 siblings, 0 replies; 3+ messages in thread
From: Glenn Morris @ 2013-10-16  1:31 UTC (permalink / raw)
  To: 15622-done

Version: 24.4

Fixed.





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-10-16  1:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-15 15:56 bug#15622: eww: url-retrieve-internal: Wrong type argument: char-or-string-p, author Svend Sorensen
2013-10-15 20:50 ` Glenn Morris
2013-10-16  1:31   ` Glenn Morris

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).