* bug#27024: 25.2: gud.el: wrong menu :visible for pdb
@ 2017-05-22 18:33 Charles A. Roelli
2017-05-27 12:17 ` Eli Zaretskii
0 siblings, 1 reply; 2+ messages in thread
From: Charles A. Roelli @ 2017-05-22 18:33 UTC (permalink / raw)
To: 27024
The "stop" entry in `gud-menu-map' (line 158):
([stop] menu-item "Stop" gud-stop-subjob
:visible (or (not (memq gud-minor-mode '(gdbmi pdb)))
(gdb-show-stop-p)))
has a :visible entry that calls `gdb-show-stop-p' if `gud-minor-mode' is
either
`gdbmi' or `pdb'. This function is only related to gdb and isn't loaded
by running
just pdb, so it can cause an error during redisplay (but interestingly,
it doesn't seem to happen all the time while running pdb -- or maybe the
error is
caught somehow).
Does anyone understand why this check for pdb is here? It seems to be a
mistake,
but it has been there for more than 7 years...
Otherwise, could someone please remove the check for pdb? Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#27024: 25.2: gud.el: wrong menu :visible for pdb
2017-05-22 18:33 bug#27024: 25.2: gud.el: wrong menu :visible for pdb Charles A. Roelli
@ 2017-05-27 12:17 ` Eli Zaretskii
0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2017-05-27 12:17 UTC (permalink / raw)
To: Charles A. Roelli; +Cc: 27024-done
> From: "Charles A. Roelli" <charles@aurox.ch>
> Date: Mon, 22 May 2017 20:33:26 +0200
>
> The "stop" entry in `gud-menu-map' (line 158):
>
> ([stop] menu-item "Stop" gud-stop-subjob
> :visible (or (not (memq gud-minor-mode '(gdbmi pdb)))
> (gdb-show-stop-p)))
>
> has a :visible entry that calls `gdb-show-stop-p' if `gud-minor-mode' is
> either
> `gdbmi' or `pdb'. This function is only related to gdb and isn't loaded
> by running
> just pdb, so it can cause an error during redisplay (but interestingly,
> it doesn't seem to happen all the time while running pdb -- or maybe the
> error is
> caught somehow).
>
> Does anyone understand why this check for pdb is here? It seems to be a
> mistake,
> but it has been there for more than 7 years...
>
> Otherwise, could someone please remove the check for pdb? Thanks.
Thanks, I've modified the test to not call gdb-show-stop-p in pdb
mode.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-27 12:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-22 18:33 bug#27024: 25.2: gud.el: wrong menu :visible for pdb Charles A. Roelli
2017-05-27 12:17 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).