* bug#16622: Flymake uses message-box, not standard warning infrastructure
@ 2014-02-02 2:13 Daniel Colascione
2014-02-04 3:27 ` Leo Liu
2014-02-04 3:33 ` Glenn Morris
0 siblings, 2 replies; 4+ messages in thread
From: Daniel Colascione @ 2014-02-02 2:13 UTC (permalink / raw)
To: 16622
flymake-display-warning looks like this:
(defun flymake-display-warning (warning)
"Display a warning to user."
(message-box warning))
Shouldn't we be using the built-in warning function? Seeing a GUI
message box for a lisp error is very surprising.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#16622: Flymake uses message-box, not standard warning infrastructure
2014-02-02 2:13 bug#16622: Flymake uses message-box, not standard warning infrastructure Daniel Colascione
@ 2014-02-04 3:27 ` Leo Liu
2014-02-04 3:33 ` Glenn Morris
1 sibling, 0 replies; 4+ messages in thread
From: Leo Liu @ 2014-02-04 3:27 UTC (permalink / raw)
To: Daniel Colascione; +Cc: 16622
On 2014-02-02 10:13 +0800, Daniel Colascione wrote:
> (defun flymake-display-warning (warning)
> "Display a warning to user."
> (message-box warning))
>
> Shouldn't we be using the built-in warning function? Seeing a GUI
> message box for a lisp error is very surprising.
This might have something to do with flymake uses mouse to bring up the
error messages i.e. the help-echo. I will take a closer look in a few
days (due to Chinese new year break).
Leo
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#16622: Flymake uses message-box, not standard warning infrastructure
2014-02-02 2:13 bug#16622: Flymake uses message-box, not standard warning infrastructure Daniel Colascione
2014-02-04 3:27 ` Leo Liu
@ 2014-02-04 3:33 ` Glenn Morris
2016-12-04 2:02 ` Glenn Morris
1 sibling, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2014-02-04 3:33 UTC (permalink / raw)
To: Daniel Colascione; +Cc: 16622
Daniel Colascione wrote:
> flymake-display-warning looks like this:
AFAICS it's used in precisely one place, behind a
flymake-gui-warnings-enabled option.
I'd probably dump function and option post 24.4.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#16622: Flymake uses message-box, not standard warning infrastructure
2014-02-04 3:33 ` Glenn Morris
@ 2016-12-04 2:02 ` Glenn Morris
0 siblings, 0 replies; 4+ messages in thread
From: Glenn Morris @ 2016-12-04 2:02 UTC (permalink / raw)
To: 16622-done
Version: 26.1
Glenn Morris wrote:
>> flymake-display-warning looks like this:
>
> AFAICS it's used in precisely one place, behind a
> flymake-gui-warnings-enabled option.
>
> I'd probably dump function and option post 24.4.
I finally did so in 041afb2.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-04 2:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-02 2:13 bug#16622: Flymake uses message-box, not standard warning infrastructure Daniel Colascione
2014-02-04 3:27 ` Leo Liu
2014-02-04 3:33 ` Glenn Morris
2016-12-04 2:02 ` Glenn Morris
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).