unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#4328: ediff chokes on `No newline at end of file'
@ 2009-09-03 11:27 Werner LEMBERG
  2009-09-03 18:47 ` Glenn Morris
  0 siblings, 1 reply; 3+ messages in thread
From: Werner LEMBERG @ 2009-09-03 11:27 UTC (permalink / raw)
  To: bug-gnu-emacs


[CVS of 2009-06-11]

If I compare two files, and the second of them misses a newline at its
end, I get

  ediff-prepare-error-list: Errors in diff output.
  Diff output is in #<buffer *ediff-diff<2>*>

in the echo area, and

  \ No newline at end of file

is displayed.

IMHO, this is a bit harsh, and ediff should be able to cope with this
situation.


    Werner






^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#4328: ediff chokes on `No newline at end of file'
  2009-09-03 11:27 bug#4328: ediff chokes on `No newline at end of file' Werner LEMBERG
@ 2009-09-03 18:47 ` Glenn Morris
  2009-09-04  7:31   ` Werner LEMBERG
  0 siblings, 1 reply; 3+ messages in thread
From: Glenn Morris @ 2009-09-03 18:47 UTC (permalink / raw)
  To: Werner LEMBERG; +Cc: 4328

Werner LEMBERG wrote:

> [CVS of 2009-06-11]
>
> If I compare two files, and the second of them misses a newline at its
> end, I get
>
>   ediff-prepare-error-list: Errors in diff output.
>   Diff output is in #<buffer *ediff-diff<2>*>
>
> in the echo area, and
>
>   \ No newline at end of file
>
> is displayed.


Ediff has code to handle this (see ediff-diff-ok-lines-regexp), and it
works fine for me, both with 23.1 and the current trunk, from emacs -Q.





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#4328: ediff chokes on `No newline at end of file'
  2009-09-03 18:47 ` Glenn Morris
@ 2009-09-04  7:31   ` Werner LEMBERG
  0 siblings, 0 replies; 3+ messages in thread
From: Werner LEMBERG @ 2009-09-04  7:31 UTC (permalink / raw)
  To: rgm; +Cc: 4328


> Ediff has code to handle this (see ediff-diff-ok-lines-regexp), and
> it works fine for me, both with 23.1 and the current trunk, from
> emacs -Q.

OK.  I've just updated to the current CVS, and I no longer can repeat
it.  Thanks for testing.


    Werner





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-09-04  7:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-09-03 11:27 bug#4328: ediff chokes on `No newline at end of file' Werner LEMBERG
2009-09-03 18:47 ` Glenn Morris
2009-09-04  7:31   ` Werner LEMBERG

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).