From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 36490@debbugs.gnu.org, erik_hahn@gmx.de
Subject: bug#36490: 26.1; directory-files-recursively breaks when it encounters a directory named "~"
Date: Tue, 09 Jul 2019 19:00:13 +0200 [thread overview]
Message-ID: <m3zhln5ejm.fsf@gnus.org> (raw)
In-Reply-To: <83v9wb40bf.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 09 Jul 2019 19:52:52 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> Sorry, that's not what I meant to say. I meant to say how would a
> Lisp program know whether (expand-file-name "~/") means the home
> directory or a directory whose name is literally "~"?
Well, we have documented that in expand-file-name "~/" means the home
directory, and I have no problems with that.
"~/" isn't something you'll ever get from functions like
directory-files, so it's not something you'd feed to expand-file-name in
these situations...
> Btw, stuff like (expand-file-name "foo/~/") already does what you
> want, so the problem is only with the leading '~', and can be avoided
> if we avoid that situation. IOW, why should this example:
>
> (expand-file-name "~" "/tmp/")
> => "/home/larsi"
>
> determine how directory-files-recursively behaves?
expand-file-name's use case is to (basically) concatenate a directory
name and a file name, but it's used instead of concat because nobody
wants to care about whether the directory name has a trailing slash or
not.
(concat "/tmp/" "foo")
=> "/tmp/foo" ; Good
(concat "/tmp" "foo")
=> "/tmpfoo" ; Bad.
(expand-file-name "foo" "/tmp")
=> "/tmp/foo" ; Yay
That's basically the use case for expand-file-name, and using it has
avoided a lot of basic concatenation problems over the years (because
Emacs allows sloppy handling of directory file names in most
situations).
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-07-09 17:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 18:07 bug#36490: 26.1; directory-files-recursively breaks when it encounters a directory named "~" Erik Hahn
2019-07-08 20:59 ` Lars Ingebrigtsen
2019-07-08 21:08 ` Lars Ingebrigtsen
2019-07-08 21:30 ` Erik Hahn
2019-07-08 21:56 ` Lars Ingebrigtsen
2019-07-09 15:39 ` Eli Zaretskii
2019-07-09 15:35 ` Eli Zaretskii
2019-07-09 15:50 ` Lars Ingebrigtsen
2019-07-09 16:12 ` Eli Zaretskii
2019-07-09 16:27 ` Lars Ingebrigtsen
2019-07-09 16:44 ` Eli Zaretskii
2019-07-09 16:50 ` Lars Ingebrigtsen
2019-07-09 16:52 ` Eli Zaretskii
2019-07-09 17:00 ` Lars Ingebrigtsen [this message]
2019-07-09 17:23 ` Eli Zaretskii
2019-07-09 18:16 ` Michael Albinus
2019-07-10 11:55 ` Lars Ingebrigtsen
2019-07-10 14:56 ` Eli Zaretskii
2019-07-11 15:05 ` Lars Ingebrigtsen
2019-07-09 18:58 ` Basil L. Contovounesios
2019-07-09 19:19 ` Eli Zaretskii
2019-07-09 16:17 ` Andreas Schwab
2019-07-10 12:04 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3zhln5ejm.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=36490@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=erik_hahn@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).