* bug#6337: 24.0.50; doc of define-minor-mode incomplete wrt mode hooks
@ 2010-06-03 0:03 Drew Adams
2010-06-03 1:56 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Drew Adams @ 2010-06-03 0:03 UTC (permalink / raw)
To: 6337
The doc for `define-minor-mode' is incomplete regarding the mode
hooks, and it has apparently been like this since the beginning
(Emacs 21).
The doc (doc string and Elisp manual) speaks about the MODE-hook, where
MODE is the name of the minor mode. But it does not mention that there
is also a `MODE-on-hook' and a `MODE-off-hook'. That is, if you define
those hook variables they to will be processed by the mode command.
The exact behavior should be defined: The MODE-hook, if any, is run
first, then the MODE-on-hook or MODE-off-hook is run, depending on
whether the mode is being turned on or off.
In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
of 2010-05-23 on G41R2F1
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/xpm/include'
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#6337: 24.0.50; doc of define-minor-mode incomplete wrt mode hooks
2010-06-03 0:03 bug#6337: 24.0.50; doc of define-minor-mode incomplete wrt mode hooks Drew Adams
@ 2010-06-03 1:56 ` Stefan Monnier
2011-07-13 22:10 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2010-06-03 1:56 UTC (permalink / raw)
To: Drew Adams; +Cc: 6337
> The doc (doc string and Elisp manual) speaks about the MODE-hook, where
> MODE is the name of the minor mode. But it does not mention that there
> is also a `MODE-on-hook' and a `MODE-off-hook'. That is, if you define
> those hook variables they to will be processed by the mode command.
They're only supported for historical reasons. We could/should probably
get rid of them.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#6337: 24.0.50; doc of define-minor-mode incomplete wrt mode hooks
2010-06-03 1:56 ` Stefan Monnier
@ 2011-07-13 22:10 ` Lars Magne Ingebrigtsen
0 siblings, 0 replies; 3+ messages in thread
From: Lars Magne Ingebrigtsen @ 2011-07-13 22:10 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 6337
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> The doc (doc string and Elisp manual) speaks about the MODE-hook, where
>> MODE is the name of the minor mode. But it does not mention that there
>> is also a `MODE-on-hook' and a `MODE-off-hook'. That is, if you define
>> those hook variables they to will be processed by the mode command.
>
> They're only supported for historical reasons. We could/should probably
> get rid of them.
This doesn't seem like a bug, then, so I'm closing this report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-07-13 22:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-03 0:03 bug#6337: 24.0.50; doc of define-minor-mode incomplete wrt mode hooks Drew Adams
2010-06-03 1:56 ` Stefan Monnier
2011-07-13 22:10 ` Lars Magne Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).