unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#30707: describe-variable misses linking linkable changed items
@ 2018-03-05  2:17 積丹尼 Dan Jacobson
  2019-07-14 14:28 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: 積丹尼 Dan Jacobson @ 2018-03-05  2:17 UTC (permalink / raw)
  To: 30707

I do
(describe-variable (quote browse-url-browser-function))
and see in *Help*:

   browse-url-browser-function is a variable defined in ‘browse-url.el’.
   Its value is ‘browse-url-chromium’
   Original value was
   browse-url-default-browser

The problem is browse-url-default-browser should be a blue link, but was
not detected as linkable.

So the user has to do
(describe-function (quote browse-url-default-browser))
to learn about it, instead of just being able to click it!

See, it really exists:
browse-url-default-browser is a compiled Lisp function in
‘browse-url.el’.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#30707: describe-variable misses linking linkable changed items
  2018-03-05  2:17 bug#30707: describe-variable misses linking linkable changed items 積丹尼 Dan Jacobson
@ 2019-07-14 14:28 ` Lars Ingebrigtsen
  2019-07-14 14:56   ` Noam Postavsky
  0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2019-07-14 14:28 UTC (permalink / raw)
  To: 積丹尼 Dan Jacobson; +Cc: 30707

積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:

> I do
> (describe-variable (quote browse-url-browser-function))
> and see in *Help*:
>
>    browse-url-browser-function is a variable defined in ‘browse-url.el’.
>    Its value is ‘browse-url-chromium’
>    Original value was
>    browse-url-default-browser
>
> The problem is browse-url-default-browser should be a blue link, but was
> not detected as linkable.
>
> So the user has to do
> (describe-function (quote browse-url-default-browser))
> to learn about it, instead of just being able to click it!

This sounds reasonable, but I don't think it is.  :-)
`browse-url-default-browser' is just a symbol that that variable had as
a value.  Yes, it's a symbol that refers to a function, but in general,
the doc machinery doesn't know that that's how it's going to be used; it
might be a total coincidence.  (Especially with shorter symbols.)

So I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#30707: describe-variable misses linking linkable changed items
  2019-07-14 14:28 ` Lars Ingebrigtsen
@ 2019-07-14 14:56   ` Noam Postavsky
  2019-07-14 15:03     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Noam Postavsky @ 2019-07-14 14:56 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 30707, 積丹尼 Dan Jacobson

Lars Ingebrigtsen <larsi@gnus.org> writes:

> 積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:
>
>>    browse-url-browser-function is a variable defined in ‘browse-url.el’.
>>    Its value is ‘browse-url-chromium’

>> The problem is browse-url-default-browser should be a blue link, but was
>> not detected as linkable.

> This sounds reasonable, but I don't think it is.  :-)
> `browse-url-default-browser' is just a symbol that that variable had as
> a value.  Yes, it's a symbol that refers to a function, but in general,
> the doc machinery doesn't know that that's how it's going to be used; it
> might be a total coincidence.  (Especially with shorter symbols.)

Even if it is just a coincidence, would it hurt to linkify it?





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#30707: describe-variable misses linking linkable changed items
  2019-07-14 14:56   ` Noam Postavsky
@ 2019-07-14 15:03     ` Lars Ingebrigtsen
  0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2019-07-14 15:03 UTC (permalink / raw)
  To: Noam Postavsky; +Cc: 30707, 積丹尼 Dan Jacobson

Noam Postavsky <npostavs@gmail.com> writes:

> Even if it is just a coincidence, would it hurt to linkify it?

Yes, I think so.  It is confusing if you see a link, hit it, and it
takes you to someplace completely irrelevant.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-07-14 15:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-05  2:17 bug#30707: describe-variable misses linking linkable changed items 積丹尼 Dan Jacobson
2019-07-14 14:28 ` Lars Ingebrigtsen
2019-07-14 14:56   ` Noam Postavsky
2019-07-14 15:03     ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).