unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: "William Xu" <william.xwl@gmail.com>,
	"Jeffrey Haug" <jthaug@gmail.com>,
	43566-done@debbugs.gnu.org,
	"Domingo Gómez Pérez" <domingo.gomez@unican.es>
Subject: bug#43566: 27.1; url-http and excorporate does not authenticate
Date: Fri, 19 Feb 2021 17:26:28 -0500	[thread overview]
Message-ID: <m3pn0vlmnf.fsf@fitzsim.org> (raw)
In-Reply-To: <m3czwwm2wn.fsf@fitzsim.org> (Thomas Fitzsimmons's message of "Fri, 19 Feb 2021 11:35:20 -0500")

Thomas Fitzsimmons <fitzsim@fitzsim.org> writes:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> Thomas Fitzsimmons <fitzsim@fitzsim.org> writes:
>>
>>> The tests will fail if web-server.el is present but out-of-date, which I
>>> think is unavoidable.  But...
>>
>> Would it be possible to check the web-server.el version to make this
>> more robust?
>
> Michael also asked about this on emacs-devel.  I looked but I can't see
> a simple way to do it.  package.el functionality isn't available in this
> context.

Michael wanted a general approach to requiring specific GNU ELPA package
versions; he suggested an implementation which I adapted and pushed to
master.  You can try it by alternating between revisions
a1c767fe56acfed6627682fadc337203f3b8678c and
4edcba28826869b07f622fd83f6aab96fd8e4d19 of web-server.el and confirming
that for the former commit the tests are skipped and for the latter,
they're run.

I also tested how url-retrieve-synchronously behaves with NTLM
authentication when the authinfo password is wrong.  It doesn't
infinite-loop -- it tries once with the authinfo credentials and if they
fail, it prompts the user for a username and password.  Therefore, the
patch that caused the regression isn't needed for NTLM and the
workaround patch I pushed is fine as-is.

I'm marking this bug done.

Thanks,
Thomas





  reply	other threads:[~2021-02-19 22:26 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22 11:20 bug#43566: 27.1; url-http and excorporate does not authenticate Domingo Gómez Pérez
2020-09-24 15:22 ` Lars Ingebrigtsen
2020-09-25 11:38   ` Domingo Gómez Pérez
2020-09-25 11:41     ` Lars Ingebrigtsen
2020-12-04 23:29       ` Thomas Fitzsimmons
2020-12-05 12:40         ` William Xu
2020-12-06 13:14         ` Lars Ingebrigtsen
2021-01-31 15:03           ` Thomas Fitzsimmons
2021-01-31 15:13             ` Eli Zaretskii
2021-02-01  8:43             ` Lars Ingebrigtsen
2021-02-01 13:28               ` Thomas Fitzsimmons
2021-02-19  1:58                 ` Thomas Fitzsimmons
2021-02-19 12:31                   ` Lars Ingebrigtsen
2021-02-19 14:18                     ` Thomas Fitzsimmons
2021-02-19 15:00                       ` Lars Ingebrigtsen
2021-02-19 16:35                         ` Thomas Fitzsimmons
2021-02-19 22:26                           ` Thomas Fitzsimmons [this message]
2020-09-29 22:19   ` Thomas Fitzsimmons
2020-09-29 22:42 ` Thomas Fitzsimmons
2020-09-30 17:00   ` Domingo Gómez Pérez
     [not found] <a84cfa50-5e21-4d75-a0bd-c6dc4d8763bc@email.android.com>
2020-09-26 13:15 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3pn0vlmnf.fsf@fitzsim.org \
    --to=fitzsim@fitzsim.org \
    --cc=43566-done@debbugs.gnu.org \
    --cc=domingo.gomez@unican.es \
    --cc=jthaug@gmail.com \
    --cc=larsi@gnus.org \
    --cc=william.xwl@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).