bug#43566: 27.1; url-http and excorporate does not authenticate

[Thomas Fitzsimmons <fitzsim@fitzsim.org>]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Thomas Fitzsimmons <fitzsim@fitzsim.org> writes:
>
>> I pushed to master the new tests, and some build logic to load
>> dependencies from GNU ELPA.
>>
>> Lars, can you confirm this works for you:
>>
>>     make -C test ntlm-tests
>
> Yup, works for me after:

OK, thanks.

>> (Maybe revert my NTLM workaround in url-http.el, and confirm that the
>> two new tests fail for you like in this original bug report?)
>>
>> By default this looks for dependencies in test/../../elpa, but you can
>> use:
>>
>>     make -C test ntlm-tests GNU_ELPA_DIRECTORY=/path/to/elpa
>>
>> if you have it checked out somewhere else.  You'll probably need to
>> "make externals" to pull my recent web-server.el change.
>
> My ELPA is in that location, but I had to update it in this way before
> the tests succeed -- so they fail unless you have ELPA installed.

The tests will fail if web-server.el is present but out-of-date, which I
think is unavoidable.  But...

> So the tests should check for that first, otherwise most people are
> going to see failing tests.

... I did implement that; can you try moving your elpa checkout
somewhere else, or try:

    make -C test ntlm-tests GNU_ELPA_DIRECTORY=/nonexistent

and confirm you see the tests being skipped?

Thanks,
Thomas