bug#4263: 23.1; initial point for vc-dir on wrong line

bug#4263: 23.1; initial point for vc-dir on wrong line

[Tom Tromey]

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:


I typed C-x v d to enter vc-dir.
Point is initially at the beginning of the buffer.
If I type "n", it confusingly moves to the second file in the listing.
I think vc-dir would be less confusing if point started on the
line corresponding to the first file.


If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/share/emacs/23.1/etc/DEBUG for instructions.


In GNU Emacs 23.1.1 (i386-redhat-linux-gnu, GTK+ Version 2.16.5)
 of 2009-08-24 on x86-2.fedora.phx.redhat.com
Windowing system distributor `The X.Org Foundation', version 11.0.10601901
configured using `configure  '--build=i386-redhat-linux-gnu' '--host=i386-redhat-linux-gnu' '--target=i586-redhat-linux-gnu' '--program-prefix=' '--prefix=/usr' '--exec-prefix=/usr' '--bindir=/usr/bin' '--sbindir=/usr/sbin' '--sysconfdir=/etc' '--datadir=/usr/share' '--includedir=/usr/include' '--libdir=/usr/lib' '--libexecdir=/usr/libexec' '--localstatedir=/var' '--sharedstatedir=/var/lib' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--with-dbus' '--with-gif' '--with-jpeg' '--with-png' '--with-rsvg' '--with-tiff' '--with-xft' '--with-xpm' '--with-x-toolkit=gtk' 'build_alias=i386-redhat-linux-gnu' 'host_alias=i386-redhat-linux-gnu' 'target_alias=i586-redhat-linux-gnu' 'CFLAGS=-DMAIL_USE_LOCKF -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-bu
 ffer-size=4 -m32 -march=i586 -mtune=generic -fasynchronous-unwind-tables''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: VC dir

Minor modes in effect:
  shell-dirtrack-mode: t
  diff-auto-refine-mode: t
  erc-list-mode: t
  erc-menu-mode: t
  erc-autojoin-mode: t
  erc-ring-mode: t
  erc-pcomplete-mode: t
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-match-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-netsplit-mode: t
  erc-spelling-mode: t
  erc-truncate-mode: t
  erc-status-mode: t
  erc-services-mode: t
  erc-networks-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
a k e - v a r i a b l e - f r a m e RET RET RET ESC 
[ 2 0 ~ C-x 1 ESC [ 2 1 ~ C-c b C-a C-v ESC v C-l C-p 
C-f C-u C-n C-p C-p C-f C-l ESC [ 2 1 ~ ESC [ 2 1 ~ 
ESC [ 2 1 ~ C-u C-u C-n C-l ESC [ 2 1 ~ C-c b ESC [ 
2 1 ~ ESC [ 2 1 ~ ESC [ 2 1 ~ C-v ESC v ESC v C-v C-n 
C-f C-u C-n C-f C-p C-f ESC } ESC } C-v C-v ESC v C-v 
C-v ESC v ESC v ESC v ESC v ESC v ESC v C-v C-l C-s 
m a k e - v C-s C-a C-v C-u C-n C-u C-n C-p C-f C-u 
C-n C-p C-p C-f C-u C-n C-n C-p C-f C-u C-n C-u C-n 
C-p C-p C-f C-v C-v ESC v ESC v ESC [ 5 ~ C-s m a k 
e - v a r C-s i C-w C-w C-s C-a C-s C-s C-s C-s C-a 
C-v C-s n e w v a l C-a C-s v a l c o n t e n t s C-a 
C-x C-g ESC [ 2 1 ~ ESC [ 2 1 ~ C-v C-v C-s Q u n b 
o u n d C-s C-s C-s C-s C-s C-s C-s C-s SPC = C-s C-g 
C-g C-g C-f C-v C-v C-v C-v C-v C-v C-x v d ESC DEL 
RET = C-x 1 C-v C-v C-v C-v C-v C-v C-v C-v C-v C-v 
C-v C-v C-v C-v C-v C-v C-x v d RET ESC x r e p o r 
t - e m TAB RET b TAB RET

Recent messages:
Saving /home/tromey/.newsrc.eld...done
Completing command name...
Type space to flush; repeat completion command to scroll
Mark saved where search started [3 times]
Grep finished (matches found)
Mark saved where search started [5 times]
Quit [2 times]
Finding changes in /home/tromey/gnu/Emacs/git-emacs/emacs/...done
call-interactively: End of buffer [2 times]
Making completion list...

Tom

bug#4263: 23.1; initial point for vc-dir on wrong line

[Lars Magne Ingebrigtsen]

Tom Tromey <tromey@redhat.com> writes:

> I typed C-x v d to enter vc-dir.
> Point is initially at the beginning of the buffer.
> If I type "n", it confusingly moves to the second file in the listing.
> I think vc-dir would be less confusing if point started on the
> line corresponding to the first file.

Starting on any of the lines would be inconvenient, because subsequent
commands (like `v') would then work on that file only, which usually
isn't what you want.

I think the right fix here is to change `n' to go to the first line if
you're before the first line.  Does anybody have any objections to that
change? 

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#4263: 23.1; initial point for vc-dir on wrong line

[Tom Tromey]

Tom> I typed C-x v d to enter vc-dir.
Tom> Point is initially at the beginning of the buffer.
Tom> If I type "n", it confusingly moves to the second file in the listing.
Tom> I think vc-dir would be less confusing if point started on the
Tom> line corresponding to the first file.

Lars> Starting on any of the lines would be inconvenient, because subsequent
Lars> commands (like `v') would then work on that file only, which usually
Lars> isn't what you want.

I meant point should start on the line for './'.  This would still do
the right thing for commands like 'v'.

Right now it starts at the beginning of the buffer.  Then 'n' acts
strangely.

Tom

bug#4263: 23.1; initial point for vc-dir on wrong line

[Lars Magne Ingebrigtsen]

Tom Tromey <tromey@redhat.com> writes:

> I meant point should start on the line for './'.  This would still do
> the right thing for commands like 'v'.

Actually, when I do `M-x vc-dir' now, it seems to do the right thing.
It puts point at point-min, and `n' goes to the first file.

So I don't think there's a bug here.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#4263: 23.1; initial point for vc-dir on wrong line

[Tom Tromey]

>>>>> "Lars" == Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

Lars> Actually, when I do `M-x vc-dir' now, it seems to do the right thing.
Lars> It puts point at point-min, and `n' goes to the first file.

But that's the behavior I think is weird.
I think it better for point to start on "./".

Lars> So I don't think there's a bug here.

"n" then "p" leaves you in a different place.

Tom

bug#4263: 23.1; initial point for vc-dir on wrong line

[Lars Magne Ingebrigtsen]

Tom Tromey <tromey@redhat.com> writes:

>>>>>> "Lars" == Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>
> Lars> Actually, when I do `M-x vc-dir' now, it seems to do the right thing.
> Lars> It puts point at point-min, and `n' goes to the first file.
>
> But that's the behavior I think is weird.
> I think it better for point to start on "./".

The commands work just the same if you do them at `point-min' or on that
line, so it's just a matter of aesthetics where to put it.  I think
leaving it at the beginning of the buffer is fine.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/