* bug#9066: cleanup: remove conditional preprocessor code that depends on __STDC__
@ 2011-07-13 15:03 Dan Nicolaescu
2011-07-14 18:27 ` Lars Magne Ingebrigtsen
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Dan Nicolaescu @ 2011-07-13 15:03 UTC (permalink / raw)
To: 9066
The source now assumes standard C, there are a few places that test __STDC__,
those tests are not needed anymore.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#9066: cleanup: remove conditional preprocessor code that depends on __STDC__
2011-07-13 15:03 bug#9066: cleanup: remove conditional preprocessor code that depends on __STDC__ Dan Nicolaescu
@ 2011-07-14 18:27 ` Lars Magne Ingebrigtsen
2011-07-14 18:57 ` Glenn Morris
2011-07-17 0:36 ` Lars Magne Ingebrigtsen
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Lars Magne Ingebrigtsen @ 2011-07-14 18:27 UTC (permalink / raw)
To: Dan Nicolaescu; +Cc: 9066
Dan Nicolaescu <dann@gnu.org> writes:
> The source now assumes standard C, there are a few places that test __STDC__,
> those tests are not needed anymore.
This was marked "notabug" by... somebody... so I'm closing the report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#9066: cleanup: remove conditional preprocessor code that depends on __STDC__
2011-07-14 18:27 ` Lars Magne Ingebrigtsen
@ 2011-07-14 18:57 ` Glenn Morris
2011-07-14 19:06 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 10+ messages in thread
From: Glenn Morris @ 2011-07-14 18:57 UTC (permalink / raw)
To: Lars Magne Ingebrigtsen; +Cc: Dan Nicolaescu, 9066
Lars Magne Ingebrigtsen wrote:
> Dan Nicolaescu <dann@gnu.org> writes:
>
>> The source now assumes standard C, there are a few places that test __STDC__,
>> those tests are not needed anymore.
>
> This was marked "notabug" by... somebody... so I'm closing the report.
Closing is not appropriate. I marked it as notabug, because it isn't an
actual "bug", IMO. But it is a TODO item, and this tracker is used for
keeping track of those as well. So it should stay open, and actually get
fixed after the feature freeze ends.
I mean personally I wouldn't file this kind of trivia as a tracker item,
but if people want to...
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#9066: cleanup: remove conditional preprocessor code that depends on __STDC__
2011-07-14 18:57 ` Glenn Morris
@ 2011-07-14 19:06 ` Lars Magne Ingebrigtsen
2011-07-14 19:27 ` Glenn Morris
0 siblings, 1 reply; 10+ messages in thread
From: Lars Magne Ingebrigtsen @ 2011-07-14 19:06 UTC (permalink / raw)
To: Glenn Morris; +Cc: Dan Nicolaescu, 9066
Glenn Morris <rgm@gnu.org> writes:
> Closing is not appropriate. I marked it as notabug, because it isn't an
> actual "bug", IMO. But it is a TODO item, and this tracker is used for
> keeping track of those as well. So it should stay open, and actually get
> fixed after the feature freeze ends.
I'm thinking "notabug" is what other bug tracking systems say is
"invalid". That is, the report talks of something that is the way it
should be, a la, "doctor, when I poke a finger in my eye it hurts".
I'll reopen the bug.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#9066: cleanup: remove conditional preprocessor code that depends on __STDC__
2011-07-14 19:06 ` Lars Magne Ingebrigtsen
@ 2011-07-14 19:27 ` Glenn Morris
2011-07-14 19:29 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 10+ messages in thread
From: Glenn Morris @ 2011-07-14 19:27 UTC (permalink / raw)
To: Lars Magne Ingebrigtsen; +Cc: Dan Nicolaescu, 9066
Lars Magne Ingebrigtsen wrote:
> I'm thinking "notabug" is what other bug tracking systems say is
> "invalid".
To me, notabug means... "this is not a bug".
Maybe "wontfix" + "notabug" = "invalid".
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#9066: cleanup: remove conditional preprocessor code that depends on __STDC__
2011-07-14 19:27 ` Glenn Morris
@ 2011-07-14 19:29 ` Lars Magne Ingebrigtsen
0 siblings, 0 replies; 10+ messages in thread
From: Lars Magne Ingebrigtsen @ 2011-07-14 19:29 UTC (permalink / raw)
To: Glenn Morris; +Cc: Dan Nicolaescu, 9066
Glenn Morris <rgm@gnu.org> writes:
> To me, notabug means... "this is not a bug".
>
> Maybe "wontfix" + "notabug" = "invalid".
It's not a bug, but we won't fix it anyway? Yes, that sounds pretty
invalid. :-)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#9066: cleanup: remove conditional preprocessor code that depends on __STDC__
2011-07-13 15:03 bug#9066: cleanup: remove conditional preprocessor code that depends on __STDC__ Dan Nicolaescu
2011-07-14 18:27 ` Lars Magne Ingebrigtsen
@ 2011-07-17 0:36 ` Lars Magne Ingebrigtsen
[not found] ` <m3d3h9d9pn.fsf@quimbies.gnus.org>
2013-02-14 8:10 ` Glenn Morris
3 siblings, 0 replies; 10+ messages in thread
From: Lars Magne Ingebrigtsen @ 2011-07-17 0:36 UTC (permalink / raw)
To: Dan Nicolaescu; +Cc: 9066, emacs-devel
Dan Nicolaescu <dann@gnu.org> writes:
> The source now assumes standard C, there are a few places that test __STDC__,
> those tests are not needed anymore.
I've had a peek at these, and they seem pretty trivial.
But is the time for cleanups like this now, or should they wait until
after the next release?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#9066: cleanup: remove conditional preprocessor code that depends on __STDC__
[not found] ` <m3d3h9d9pn.fsf@quimbies.gnus.org>
@ 2011-07-18 5:56 ` Dan Nicolaescu
0 siblings, 0 replies; 10+ messages in thread
From: Dan Nicolaescu @ 2011-07-18 5:56 UTC (permalink / raw)
To: Lars Magne Ingebrigtsen; +Cc: 9066, emacs-devel
Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> Dan Nicolaescu <dann@gnu.org> writes:
>
>> The source now assumes standard C, there are a few places that test __STDC__,
>> those tests are not needed anymore.
>
> I've had a peek at these, and they seem pretty trivial.
>
> But is the time for cleanups like this now, or should they wait until
> after the next release?
IMO, just wait until the next release, they are not worth the risk.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#9066: cleanup: remove conditional preprocessor code that depends on __STDC__
2011-07-13 15:03 bug#9066: cleanup: remove conditional preprocessor code that depends on __STDC__ Dan Nicolaescu
` (2 preceding siblings ...)
[not found] ` <m3d3h9d9pn.fsf@quimbies.gnus.org>
@ 2013-02-14 8:10 ` Glenn Morris
2013-02-16 14:01 ` Eli Zaretskii
3 siblings, 1 reply; 10+ messages in thread
From: Glenn Morris @ 2013-02-14 8:10 UTC (permalink / raw)
To: 9066
Dan Nicolaescu wrote:
> The source now assumes standard C, there are a few places that test
> __STDC__, those tests are not needed anymore.
The only ones left are in
src/w32term.c
nt/inc/ms-w32.h
OK to remove, or still needed?
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#9066: cleanup: remove conditional preprocessor code that depends on __STDC__
2013-02-14 8:10 ` Glenn Morris
@ 2013-02-16 14:01 ` Eli Zaretskii
0 siblings, 0 replies; 10+ messages in thread
From: Eli Zaretskii @ 2013-02-16 14:01 UTC (permalink / raw)
To: Glenn Morris; +Cc: 9066
> From: Glenn Morris <rgm@gnu.org>
> Date: Thu, 14 Feb 2013 03:10:44 -0500
>
> Dan Nicolaescu wrote:
>
> > The source now assumes standard C, there are a few places that test
> > __STDC__, those tests are not needed anymore.
>
> The only ones left are in
>
> src/w32term.c
> nt/inc/ms-w32.h
>
> OK to remove, or still needed?
I removed the first one, but the 2nd one has to stay. I made it clear
it is only used for the MS compiler, though; GCC doesn't need it.
Trunk revision 111805.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-02-16 14:01 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-13 15:03 bug#9066: cleanup: remove conditional preprocessor code that depends on __STDC__ Dan Nicolaescu
2011-07-14 18:27 ` Lars Magne Ingebrigtsen
2011-07-14 18:57 ` Glenn Morris
2011-07-14 19:06 ` Lars Magne Ingebrigtsen
2011-07-14 19:27 ` Glenn Morris
2011-07-14 19:29 ` Lars Magne Ingebrigtsen
2011-07-17 0:36 ` Lars Magne Ingebrigtsen
[not found] ` <m3d3h9d9pn.fsf@quimbies.gnus.org>
2011-07-18 5:56 ` Dan Nicolaescu
2013-02-14 8:10 ` Glenn Morris
2013-02-16 14:01 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).