bug#458: [PATCH] Restrain the load message when emacs running with --script option

bug#458: [PATCH] Restrain the load message when emacs running with --script option

[Kazuo YAGI]

[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]

Hi guys,

This is a very simple patch for "src/lread.c" to restrain emacs
to printing the load message when running with --script option.

I also attached the test script(cat.el) to reproduce this bug,
and show how emacs works before/after applying this patch below.

/// BEFORE PATCHED ///////////////////////////////////////////////////
$ ./cat.el cat.el
Loading subst-ksc...
Loading subst-gb2312...
Loading subst-big5...
Loading subst-jis...
#!/usr/local/bin/emacs --script

(dolist (file command-line-args-left)
	(with-current-buffer (find-file-noselect file)
		(send-string-to-terminal (buffer-string))))

/// AFTER  PATCHED ///////////////////////////////////////////////////
$ ./cat.el cat.el
#!/usr/local/bin/emacs --script

(dolist (file command-line-args-left)
	(with-current-buffer (find-file-noselect file)
		(send-string-to-terminal (buffer-string))))

Thanks,
- Kazuo YAGI

; In GNU Emacs 22.2.2 (i686-pc-linux-gnu)
;  of 2008-06-21 on teresa
; Windowing system distributor `The X.Org Foundation', version 11.0.10400090

[-- Attachment #2: restrain-load-message.patch --]
[-- Type: text/x-diff, Size: 471 bytes --]

--- emacs-22.2/src/lread.c	2008-01-10 21:16:15.000000000 +0900
+++ emacs-22.2tmp/src/lread.c	2008-06-21 22:20:52.000000000 +0900
@@ -1003,7 +1003,7 @@ Return t if the file exists and loads su
   if (! NILP (Vpurify_flag))
     Vpreloaded_file_list = Fcons (file, Vpreloaded_file_list);
 
-  if (NILP (nomessage))
+  if (!noninteractive && NILP (nomessage))
     {
       if (!safe_p)
 	message_with_string ("Loading %s (compiled; note unsafe, not compiled in Emacs)...",

[-- Attachment #3: cat.el --]
[-- Type: text/plain, Size: 166 bytes --]

#!/usr/local/bin/emacs --script 

(dolist (file command-line-args-left)
	(with-current-buffer (find-file-noselect file)
		(send-string-to-terminal (buffer-string))))

bug#458: [PATCH] Restrain the load message when emacs running with --script option

[Joe Wells]

Kazuo YAGI <kyagi@miraclelinux.com> writes:

> This is a very simple patch for "src/lread.c" to restrain emacs
> to printing the load message when running with --script option.

Hurray!  Yes, please install this patch!  This will help silence a lot
of my cron jobs that spew out these loading messages.

-- 
Joe Wells


-- 
Heriot-Watt University is a Scottish charity
registered under charity number SC000278.

bug#458: [PATCH] Restrain the load message when emacs running with --script option

[Chong Yidong]

> This is a very simple patch for "src/lread.c" to restrain emacs to
> printing the load message when running with --script option.

Could you explain why this is a good thing?  If the load message is not
desired, the lisp code should call `load' with a NOERROR argument, or
use `require'.

bug#458: [PATCH] Restrain the load message when emacs running with --script option

[Joe Wells]

Chong Yidong <cyd@stupidchicken.com> writes:

>> This is a very simple patch for "src/lread.c" to restrain emacs to
>> printing the load message when running with --script option.
>
> Could you explain why this is a good thing?  If the load message is not
> desired, the lisp code should call `load' with a NOERROR argument, or
> use `require'.

For example, I have an Emacs script that prints these messages in the
middle of its run:

  Loading subst-ksc...
  Loading subst-gb2312...
  Loading subst-big5...
  Loading subst-jis...

These are not files I loaded directly.  Some package which is not
under the control of ordinary users is loading them.

It is this kind of message that needs to be silenced.

I hope this helps.

-- 
Joe

P.S.  I'm not entirely sure why I got CC-ed on this message, but I'm
happy to comment on it!


-- 
Heriot-Watt University is a Scottish charity
registered under charity number SC000278.

bug#458: [PATCH] Restrain the load message when emacs running with --script option

[Chong Yidong]

Joe Wells <jbw@macs.hw.ac.uk> writes:

> For example, I have an Emacs script that prints these messages in the
> middle of its run:
>
>   Loading subst-ksc...
>   Loading subst-gb2312...
>   Loading subst-big5...
>   Loading subst-jis...
>
> These are not files I loaded directly.  Some package which is not
> under the control of ordinary users is loading them.

Could you find out which package is performing this noisy loading?
Normally, packages should use `require', which does not emit messages
when loading.

bug#458: [PATCH] Restrain the load message when emacs running with --script option

[Joe Wells]

Chong Yidong <cyd@stupidchicken.com> writes:

> Joe Wells <jbw@macs.hw.ac.uk> writes:
>
>> For example, I have an Emacs script that prints these messages in the
>> middle of its run:
>>
>>   Loading subst-ksc...
>>   Loading subst-gb2312...
>>   Loading subst-big5...
>>   Loading subst-jis...
>>
>> These are not files I loaded directly.  Some package which is not
>> under the control of ordinary users is loading them.
>
> Could you find out which package is performing this noisy loading?
> Normally, packages should use `require', which does not emit messages
> when loading.

Sorry, don't have time to track this down.  Other packages have other
problems.  For example, on another system, I have a Emacs script that
emits these messages:

  Loading /usr/share/emacs/site-lisp/site-start.d/auctex-init.el (source)...
  Loading /usr/share/emacs/site-lisp/site-start.d/auctex.el (source)...
  Loading /usr/share/emacs/site-lisp/site-start.d/ess-init.el (source)...
  Loading /usr/share/emacs/site-lisp/site-start.d/focus-init.el (source)...
  Loading /usr/share/emacs/site-lisp/site-start.d/igrep-init.el (source)...
  Loading /usr/share/emacs/site-lisp/site-start.d/logo-mode.el (source)...
  Loading /usr/share/emacs/site-lisp/site-start.d/php-mode-init.el (source)...
  Loading /usr/share/emacs/site-lisp/site-start.d/po-mode-init.el (source)...
  Loading /usr/share/emacs/site-lisp/site-start.d/preview-latex.el (source)...
  Loading /usr/share/emacs/site-lisp/site-start.d/psgml-init.el (source)...
  Loading /usr/share/emacs/site-lisp/site-start.d/rpm-spec-mode-init.el (source)...
  Loading /usr/local/share/emacs/site-lisp/sml-mode/sml-mode-startup.el (source)...
  Loading subst-ksc...
  Loading subst-gb2312...
  Loading subst-big5...
  Loading subst-jis...
  Loading quail/latin-ltx...
  
  
  
  Loading vc-cvs...

In this case, a bunch of extra loading messages get printed by
site-specific initialization files that come with extra packages (from
Fedora).

(By the way, I don't know what is printing the 3 blank lines in the
middle of the messages above.)

In general, it would be nice if there was a global variable which when
non-nil means “don't print any loading messages at all right now” and
if using the --script command-line option set this variable to t.

I hope this message helps.

-- 
Joe


-- 
Heriot-Watt University is a Scottish charity
registered under charity number SC000278.

bug#458: [PATCH] Restrain the load message when emacs running with --script option

[Dan Nicolaescu]

Joe Wells <jbw@macs.hw.ac.uk> writes:

  > Chong Yidong <cyd@stupidchicken.com> writes:
  > 
  > > Joe Wells <jbw@macs.hw.ac.uk> writes:
  > >
  > >> For example, I have an Emacs script that prints these messages in the
  > >> middle of its run:
  > >>
  > >>   Loading subst-ksc...
  > >>   Loading subst-gb2312...
  > >>   Loading subst-big5...
  > >>   Loading subst-jis...
  > >>
  > >> These are not files I loaded directly.  Some package which is not
  > >> under the control of ordinary users is loading them.
  > >
  > > Could you find out which package is performing this noisy loading?
  > > Normally, packages should use `require', which does not emit messages
  > > when loading.
  > 
  > Sorry, don't have time to track this down.  Other packages have other
  > problems.  For example, on another system, I have a Emacs script that
  > emits these messages:
  > 
  >   Loading /usr/share/emacs/site-lisp/site-start.d/auctex-init.el (source)...
  >   Loading /usr/share/emacs/site-lisp/site-start.d/auctex.el (source)...
  >   Loading /usr/share/emacs/site-lisp/site-start.d/ess-init.el (source)...
  >   Loading /usr/share/emacs/site-lisp/site-start.d/focus-init.el (source)...
  >   Loading /usr/share/emacs/site-lisp/site-start.d/igrep-init.el (source)...
  >   Loading /usr/share/emacs/site-lisp/site-start.d/logo-mode.el (source)...
  >   Loading /usr/share/emacs/site-lisp/site-start.d/php-mode-init.el (source)...
  >   Loading /usr/share/emacs/site-lisp/site-start.d/po-mode-init.el (source)...
  >   Loading /usr/share/emacs/site-lisp/site-start.d/preview-latex.el (source)...
  >   Loading /usr/share/emacs/site-lisp/site-start.d/psgml-init.el (source)...
  >   Loading /usr/share/emacs/site-lisp/site-start.d/rpm-spec-mode-init.el (source)...
  >   Loading /usr/local/share/emacs/site-lisp/sml-mode/sml-mode-startup.el (source)...

These looks like a Fedora (or RedHat system) system, site-start.el loads
these files.
site-start.el is not provided by emacs, but by the distribution.
You can ask them to use the NOMESSAGE argument to `load' ...

bug#458: [PATCH] Restrain the load message when emacs running with --script option

[Lars Magne Ingebrigtsen]

Dan Nicolaescu <dann@ics.uci.edu> writes:

> site-start.el is not provided by emacs, but by the distribution.
> You can ask them to use the NOMESSAGE argument to `load' ...

Yeah, this seems like a bug in the Fedora setup, and not something that
needs fixing in Emacs, so I'm closing this report.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/