From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 24050@debbugs.gnu.org, olejorgenb@gmail.com
Subject: bug#24050: 24.5; ispell-change-dictionary suggests non-existent dicts (aspell)
Date: Tue, 30 Jul 2019 13:22:18 +0200 [thread overview]
Message-ID: <m336invkb9.fsf@gnus.org> (raw)
In-Reply-To: <83o91ckhib.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 29 Jul 2019 18:06:04 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> Not necessarily, because the dictionary can be specified as a full
> absolute file name. Also, ispell-dictionary-alist provides for
> specifying command-line options for the speller, and some of those
> could instruct the speller to look for the dictionary in a
> non-standard directory, where the speller doesn't look when we query
> it about installed dictionaries.
OK; I see now that this is more complicated than I assumed. Thanks for
explaining. I've now reverted the patch and reopened the bug.
>> With the patch, ispell-change-directory (on this system) seems to list
>> all the dictionaries it can use. This is quite useful, because now that
>> command allows me to actually choose the dictionary variant I most want
>> to use, which was impossible before when they were hidden among all the
>> dictionaries Emacs was claiming I could use (but can't).
>
> I see your point and agree with the convenience part, but
> unfortunately things are not as simple as they seem.
>
> First, if this kind of filtering of the potentially available
> dictionaries should happen, its place is in
> ispell-valid-dictionary-list, not where the proposed change was made.
Right.
> So all of this is ... complicated. And since the original complaint
> is about the completion candidates shown by ispell-change-directory, I
> think we should solve that problem by tweaking only the completion,
> not the data structures it uses. If you agree, maybe you or someone
> else could come up with an alternative patch which only modified how
> the collection of completion candidates is calculated.
A different option might be to use the current way of doing the
completion candidates, but mark (for instance in bold) the ones that
aspell/hunspell has said are available on the system.
> (And btw, I think it is a mistake to call completing-read with
> MUST-MATCH argument non-nil here, because it prevents users from
> typing a full absolute file name of the dictionary, an entirely valid
> and useful response.)
Yup.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-07-30 11:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 19:49 bug#24050: 24.5; ispell-change-dictionary suggests non-existent dicts (aspell) Ole Jørgen Brønner
2019-07-28 10:25 ` Lars Ingebrigtsen
2019-07-28 14:17 ` Eli Zaretskii
2019-07-28 14:25 ` Lars Ingebrigtsen
2019-07-28 14:51 ` Eli Zaretskii
2019-07-28 15:08 ` Lars Ingebrigtsen
2019-07-28 16:22 ` Eli Zaretskii
2019-07-29 11:12 ` Lars Ingebrigtsen
2019-07-29 15:06 ` Eli Zaretskii
2019-07-30 11:22 ` Lars Ingebrigtsen [this message]
2019-07-30 14:42 ` Eli Zaretskii
2019-07-29 14:32 ` Agustin Martin
2022-02-21 16:01 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m336invkb9.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=24050@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=olejorgenb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).