From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#24050: 24.5; ispell-change-dictionary suggests non-existent dicts (aspell) Date: Tue, 30 Jul 2019 13:22:18 +0200 Message-ID: References: <87k1c2cv77.fsf@mouse.gnus.org> <83h876kzv1.fsf@gnu.org> <83d0hukya1.fsf@gnu.org> <83a7cyku2k.fsf@gnu.org> <83o91ckhib.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="137791"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 24050@debbugs.gnu.org, olejorgenb@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 30 13:23:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hsQDl-000Zfu-HV for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Jul 2019 13:23:09 +0200 Original-Received: from localhost ([::1]:59798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsQDk-0002Nr-JP for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Jul 2019 07:23:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51905) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsQDf-0002Ni-DZ for bug-gnu-emacs@gnu.org; Tue, 30 Jul 2019 07:23:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hsQDe-00060Q-6x for bug-gnu-emacs@gnu.org; Tue, 30 Jul 2019 07:23:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40818) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hsQDe-00060J-3e for bug-gnu-emacs@gnu.org; Tue, 30 Jul 2019 07:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hsQDd-0006yr-U2 for bug-gnu-emacs@gnu.org; Tue, 30 Jul 2019 07:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Jul 2019 11:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24050 X-GNU-PR-Package: emacs Original-Received: via spool by 24050-submit@debbugs.gnu.org id=B24050.156448574326768 (code B ref 24050); Tue, 30 Jul 2019 11:23:01 +0000 Original-Received: (at 24050) by debbugs.gnu.org; 30 Jul 2019 11:22:23 +0000 Original-Received: from localhost ([127.0.0.1]:49639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsQD1-0006xg-06 for submit@debbugs.gnu.org; Tue, 30 Jul 2019 07:22:23 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:59666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsQCz-0006xZ-On for 24050@debbugs.gnu.org; Tue, 30 Jul 2019 07:22:22 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hsQCw-00075p-8V; Tue, 30 Jul 2019 13:22:20 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEUrCQWDGAQOAwPJIwLV JgLXXz9b40YKAAACVElEQVQ4jV2US3IjIQyGJTqzl1DPXsgXAIsDuAuyT01N7n+VEZ3Y8Ri7qwwf evyS2pBwn/fVH7+aAYDKz8F9ZYNkBvpKRlEgs2L7/DzXezx/F0kGsyqnVzACcNKa+ngBEcOgj9br i6tqgGe06+djnWAk2L5A/1/HzLDfQXz8Gcw7GP1ZDX8D2t39GTj0SassDMKnJ7+DpdIsoZW0yZzH d9ARFkzItlGxLVK/GT5czSGxdYIeZ4fqV9DTsnJWQV/mB4J8gZXKESEk8k37oIufkhPsI2y8WZ8N EzfSxuuqwdsCM1OvKzsAk+XqyAGW4mx7Xc3EaizuqyThcb/1atK9qqGEXNOxX8+y35gMnJLa5sJK pSEtMGqOVno2tcLYkBlguRq2wuI4CDUSc9JeS10xrnE1kUeOnAp5Yzm2CtyjPiWXjH4zpkLDWVoh SG/RYM1m0toSyN3z3lABl4qSAQMgMW0yaB9QoMwptWTFzVnZXbxGmQSg9AaAtXBxTtsCDcJVgsuc yCrKpVHo8zCIYRM9wUgbEbToe/dhLZluvJRvBwq3xpGnt6aerEiDqL4E8Ijt65tQspXm0GK4jnRp 0tb1HlBq49HDYkStpY5jwxpDyuC3JrMDMcaN5j7Yr6tDuoo1J5Sr+tVCwW2rV/FxMIeLGLgLMUcn MCrKY83ngT3CTVDVKPvvnxfns07Z6w6WlEzenwjFa2kIRl7F3/HJAldDozD7Ebtf9+OPeGxNmOnO a/vxBPIJ8Mhr++cb/InfJwA0DVoSrkEFu684L5zsIrnwiL+JB/gHNzzIbvr5IfcAAAAASUVORK5C YII= In-Reply-To: <83o91ckhib.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 29 Jul 2019 18:06:04 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164104 Archived-At: Eli Zaretskii writes: > Not necessarily, because the dictionary can be specified as a full > absolute file name. Also, ispell-dictionary-alist provides for > specifying command-line options for the speller, and some of those > could instruct the speller to look for the dictionary in a > non-standard directory, where the speller doesn't look when we query > it about installed dictionaries. OK; I see now that this is more complicated than I assumed. Thanks for explaining. I've now reverted the patch and reopened the bug. >> With the patch, ispell-change-directory (on this system) seems to list >> all the dictionaries it can use. This is quite useful, because now that >> command allows me to actually choose the dictionary variant I most want >> to use, which was impossible before when they were hidden among all the >> dictionaries Emacs was claiming I could use (but can't). > > I see your point and agree with the convenience part, but > unfortunately things are not as simple as they seem. > > First, if this kind of filtering of the potentially available > dictionaries should happen, its place is in > ispell-valid-dictionary-list, not where the proposed change was made. Right. > So all of this is ... complicated. And since the original complaint > is about the completion candidates shown by ispell-change-directory, I > think we should solve that problem by tweaking only the completion, > not the data structures it uses. If you agree, maybe you or someone > else could come up with an alternative patch which only modified how > the collection of completion candidates is calculated. A different option might be to use the current way of doing the completion candidates, but mark (for instance in bold) the ones that aspell/hunspell has said are available on the system. > (And btw, I think it is a mistake to call completing-read with > MUST-MATCH argument non-nil here, because it prevents users from > typing a full absolute file name of the dictionary, an entirely valid > and useful response.) Yup. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no