bug#4459: 23.1; ERC customize does not hide password from view

bug#4459: 23.1; ERC customize does not hide password from view

[Robin Green]

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

If I use the Customize mode to set a password for ERC to try automatically, Customize does not hide the password from view. (Incidentally, I can't hide the password from view by clicking the relevant show/hide arrow afterwards, either - it refuses to hide anything.)

To reproduce this, in ERC major mode (reachable with M-x erc), choose Customize from the ERC menu. Then choose the Erc Services group. Then, under "Erc Nickserv Passwords:", press the INS button and choose some Network name. Press the INS buton under "Nickname and password:" and enter some arbitrary nickname and password. The password is visible on the screen (unlike when ERC prompts for a password itself, when it hides the password by printing periods instead of the actual password characters).

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/share/emacs/23.1/etc/DEBUG for instructions.


In GNU Emacs 23.1.1 (i386-redhat-linux-gnu, GTK+ Version 2.17.9)
 of 2009-08-31 on x86-4.fedora.phx.redhat.com
Windowing system distributor `The X.Org Foundation', version 11.0.10699901
configured using `configure  '--build=i386-redhat-linux-gnu' '--host=i386-redhat-linux-gnu' '--target=i686-redhat-linux-gnu' '--program-prefix=' '--prefix=/usr' '--exec-prefix=/usr' '--bindir=/usr/bin' '--sbindir=/usr/sbin' '--sysconfdir=/etc' '--datadir=/usr/share' '--includedir=/usr/include' '--libdir=/usr/lib' '--libexecdir=/usr/libexec' '--localstatedir=/var' '--sharedstatedir=/var/lib' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--with-dbus' '--with-gif' '--with-jpeg' '--with-png' '--with-rsvg' '--with-tiff' '--with-xft' '--with-xpm' '--with-x-toolkit=gtk' 'build_alias=i386-redhat-linux-gnu' 'host_alias=i386-redhat-linux-gnu' 'target_alias=i686-redhat-linux-gnu' 'CFLAGS=-DMAIL_USE_LOCKF -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-bu
 ffer-size=4 -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Custom

Minor modes in effect:
  erc-list-mode: t
  erc-menu-mode: t
  erc-autojoin-mode: t
  erc-ring-mode: t
  erc-networks-mode: t
  erc-pcomplete-mode: t
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-match-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-netsplit-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
*censored because it contains a password*

Recent messages:
Creating customization items ...done
Resetting customization items...done
Creating customization setup...done
Mark set
M-TAB: complete field; RET: enter value
To install your edits, invoke [State] and choose the Set operation
custom-toggle-hide: There are unsaved changes [5 times]
byte-code: Beginning of buffer [8 times]
Saving file /home/greenrd/.emacs...
Wrote /home/greenrd/.emacs

bug#4459: Hiding erc nickserv passwords in custom buffers

[Vivek Dasmohapatra]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 119 bytes --]

Tags: patch

Not sure about the previous comment about it not being possible, but the
above patch seems to dtrt for me.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: TEXT/x-diff; name=0001-Hide-erc-nickserv-passwords-password-field-contents-.patch, Size: 426 bytes --]

diff --git a/lisp/erc/erc-services.el b/lisp/erc/erc-services.el
--- a/lisp/erc/erc-services.el
+++ b/lisp/erc/erc-services.el
@@ -195,7 +195,8 @@ Example of use:
 		(repeat :tag "Nickname and password"
 			(cons :tag "Identity"
 			      (string :tag "Nick")
-			      (string :tag "Password"))))))
+			      (string :tag "Password"
+                                      :secret ?*))))))
 
 ;; Variables:
 

bug#4459: Hiding erc nickserv passwords in custom buffers

[Lars Magne Ingebrigtsen]

Vivek Dasmohapatra <vivek@etla.org> writes:

> Not sure about the previous comment about it not being possible, but the
> above patch seems to dtrt for me.

Thanks for the patch; I've installed it in the Emacs trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/