From: Andrii Kolomoiets <andreyk.mad@gmail.com>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 44885@debbugs.gnu.org, joaotavora@gmail.com
Subject: bug#44885: 28.0.50; [PATCH] ElDoc buffer mode and separator
Date: Thu, 03 Dec 2020 12:29:05 +0200 [thread overview]
Message-ID: <m2zh2vdvym.fsf@gmail.com> (raw)
In-Reply-To: <87r1ocl3j2.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 29 Nov 2020 13:02:25 +0000")
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
>> * lisp/emacs-lisp/eldoc.el (eldoc-doc-buffer-separator): New option.
>
> Does this need calling out in etc/NEWS?
Sure. But I left it for later, when the patch will be ready.
>> + (define-key map [?\S-\ ] 'scroll-down-command)
>
> Nit: please prefer '\s' over '\ '.
This is copy-paste from the `special-mode-map` and will be removed once
eldoc-buffer mode will be derived from special-mode.
>> +(define-derived-mode eldoc-doc-mode fundamental-mode "ElDoc doc"
>> + "Major mode for ElDoc documentation buffer."
>
> If it's the major mode for the ElDoc buffer, why not call it
> eldoc-buffer-mode so as to avoid the repetition/ambiguity of "doc"?
Indeed. I think I was confused by the `eldoc-doc-buffer` command name.
>> + (setq buffer-read-only t))
>> +
>> (defun eldoc--format-doc-buffer (docs)
>> "Ensure DOCS are displayed in an *eldoc* buffer."
>> (interactive (list t))
>> @@ -472,12 +495,13 @@ eldoc--format-doc-buffer
>> eldoc--doc-buffer
>> (setq eldoc--doc-buffer
>> (get-buffer-create " *eldoc*")))
>> + (unless (eq major-mode 'eldoc-doc-mode)
>
> Why not derived-mode-p?
You are right. Will fix.
Thanks!
next prev parent reply other threads:[~2020-12-03 10:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 12:42 bug#44885: 28.0.50; [PATCH] ElDoc buffer mode and separator Andrii Kolomoiets
2020-11-28 23:54 ` João Távora
2020-12-03 9:25 ` Andrii Kolomoiets
2020-11-29 13:02 ` Basil L. Contovounesios
2020-12-03 10:29 ` Andrii Kolomoiets [this message]
2021-01-25 14:19 ` Felician Nemeth
2021-09-08 9:44 ` Lars Ingebrigtsen
2021-09-08 9:46 ` João Távora
2021-09-08 18:56 ` Andrii Kolomoiets
2022-09-11 11:33 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2zh2vdvym.fsf@gmail.com \
--to=andreyk.mad@gmail.com \
--cc=44885@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).