From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrii Kolomoiets Newsgroups: gmane.emacs.bugs Subject: bug#44885: 28.0.50; [PATCH] ElDoc buffer mode and separator Date: Thu, 03 Dec 2020 12:29:05 +0200 Message-ID: References: <87r1ocl3j2.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26456"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (darwin) Cc: 44885@debbugs.gnu.org, joaotavora@gmail.com To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 03 11:30:47 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kklsp-0006ey-Pb for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Dec 2020 11:30:43 +0100 Original-Received: from localhost ([::1]:41518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kklso-0004C6-Q8 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Dec 2020 05:30:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kklsB-00049h-2D for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2020 05:30:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55203) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kklsA-0001ZV-EZ for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2020 05:30:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kklsA-0000Wg-Af for bug-gnu-emacs@gnu.org; Thu, 03 Dec 2020 05:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrii Kolomoiets Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Dec 2020 10:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44885 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44885-submit@debbugs.gnu.org id=B44885.16069913621945 (code B ref 44885); Thu, 03 Dec 2020 10:30:02 +0000 Original-Received: (at 44885) by debbugs.gnu.org; 3 Dec 2020 10:29:22 +0000 Original-Received: from localhost ([127.0.0.1]:38516 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kklrP-0000VD-Qi for submit@debbugs.gnu.org; Thu, 03 Dec 2020 05:29:22 -0500 Original-Received: from mail-lf1-f52.google.com ([209.85.167.52]:42511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kklrN-0000V0-JD for 44885@debbugs.gnu.org; Thu, 03 Dec 2020 05:29:14 -0500 Original-Received: by mail-lf1-f52.google.com with SMTP id u18so1933643lfd.9 for <44885@debbugs.gnu.org>; Thu, 03 Dec 2020 02:29:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=z/ndh/0ycktfTFidBfn+bcRYj5XRyK4ECtJff7jYCZ8=; b=NLB5OQGZRLTb/7tUqtJ8DUfAk9ZO1Dm8MWpv6zFWJBWU1KcOePWgu3I9BYnMWJpW/K nSDsAW6u+z+x3pshclwv6ySy2v4QcMoaJAMII6MgEQQym6aVrudDjBk/LkrEeJYVtcrK tg7riO2UYeW9BHIjitv0MzqKwfJcE5FFGmcD65LaN3+Z3rlHt9qAx6g34l0eYH+O2pgM cV+VI/pXqqxqHQo/WZt1RCaG+krY25VVX0xOMXoX/AtYI+AKGLQDix8f+rzpSsgdLnWW LaDXMXn5Bg0ybQ9lxFUm0GAQ36EG73k9B3zpy1RVJKT9ZFKhqPdNjligN6EdLQrLdEgK /x8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=z/ndh/0ycktfTFidBfn+bcRYj5XRyK4ECtJff7jYCZ8=; b=cGFC1UMNLjtPjAdEr9BdzM9bQg4jLSRjWhzVxbDfJ+v6nGkY6KSvkWjnFCb+gfVS8v 36nCySlQOMttcKSDGV0XorW9x0tCUHAzogWbQR2G/vz5LfqWr/pXbYsS0BI3kjcjYsdI dHbW26ERDVoU/8SUu/M2aj4CoQSiPQGSOS9uXTe5KYLLXFBaM69h1YJ/EV8QjCeZk8c0 t0J2cw64TSWVbz9kU2sThjLiCryf92M8nJAqjMyaVZFbGY32+ckYy0J07glrM69Hq4L1 66lBeoWEnC7AhGc591PnLgm4pEEXoL0AmZE1eU/2CmoCCYOCBbZXE0I4nIhz/2AY0ujH 7nSA== X-Gm-Message-State: AOAM5308XUYLRJ6y80Kw6wK1hOGyYvQqaf5twdEPSnHPW2CQ+62S2hYN 6F9BmKZBRF89mFUVfUs7ngA= X-Google-Smtp-Source: ABdhPJxDtqu75D6GvnKs/A+vbynKFgrrZcvXdwRg5TB/rYwmlI3A3dRy9mqgolQGcrNdIggspfdz/g== X-Received: by 2002:ac2:5108:: with SMTP id q8mr1056522lfb.380.1606991347507; Thu, 03 Dec 2020 02:29:07 -0800 (PST) Original-Received: from muffinmac ([91.206.110.206]) by smtp.gmail.com with ESMTPSA id o72sm362794lfa.278.2020.12.03.02.29.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Dec 2020 02:29:06 -0800 (PST) In-Reply-To: <87r1ocl3j2.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 29 Nov 2020 13:02:25 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194868 Archived-At: "Basil L. Contovounesios" writes: >> * lisp/emacs-lisp/eldoc.el (eldoc-doc-buffer-separator): New option. > > Does this need calling out in etc/NEWS? Sure. But I left it for later, when the patch will be ready. >> + (define-key map [?\S-\ ] 'scroll-down-command) > > Nit: please prefer '\s' over '\ '. This is copy-paste from the `special-mode-map` and will be removed once eldoc-buffer mode will be derived from special-mode. >> +(define-derived-mode eldoc-doc-mode fundamental-mode "ElDoc doc" >> + "Major mode for ElDoc documentation buffer." > > If it's the major mode for the ElDoc buffer, why not call it > eldoc-buffer-mode so as to avoid the repetition/ambiguity of "doc"? Indeed. I think I was confused by the `eldoc-doc-buffer` command name. >> + (setq buffer-read-only t)) >> + >> (defun eldoc--format-doc-buffer (docs) >> "Ensure DOCS are displayed in an *eldoc* buffer." >> (interactive (list t)) >> @@ -472,12 +495,13 @@ eldoc--format-doc-buffer >> eldoc--doc-buffer >> (setq eldoc--doc-buffer >> (get-buffer-create " *eldoc*"))) >> + (unless (eq major-mode 'eldoc-doc-mode) > > Why not derived-mode-p? You are right. Will fix. Thanks!