unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Y. E. via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 52303@debbugs.gnu.org
Subject: bug#52303: [PATCH] Remove not defined face info-menu-5 from manoj-dark theme
Date: Sun, 05 Dec 2021 19:43:55 +0200	[thread overview]
Message-ID: <m2wnkj0wx0.fsf@ego.team> (raw)

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

Tags: patch

Hello,

The face 'info-menu-5' was obsoleted in favor to 'info-menu-star' back
in 2005 (185cff95450).

This patch suggests removal of the not defined face and not updating it,
because the de facto used 'info-menu-star' default value has served the
theme users during the last years.

A side-question: do I still need to add "Copyright-paperwork-exempt:
yes" to the minor commits even if I have the CA completed?

Thanks,
YE



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-etc-themes-manoj-dark-theme.el-Remove-not-defined-fa.patch --]
[-- Type: text/patch, Size: 985 bytes --]

From 85ca17dd7fd3d3aaf8be81d2358809a7768d598e Mon Sep 17 00:00:00 2001
From: YugaEgo <yet@ego.team>
Date: Sun, 5 Dec 2021 19:32:44 +0200
Subject: [PATCH] ; * etc/themes/manoj-dark-theme.el: Remove not defined face
 info-menu-5

Copyright-paperwork-exempt: yes
---
 etc/themes/manoj-dark-theme.el | 1 -
 1 file changed, 1 deletion(-)

diff --git a/etc/themes/manoj-dark-theme.el b/etc/themes/manoj-dark-theme.el
index f10b88507e..e80403f5b3 100644
--- a/etc/themes/manoj-dark-theme.el
+++ b/etc/themes/manoj-dark-theme.el
@@ -541,7 +541,6 @@ manoj-dark
  '(ido-indicator ((t (:background "red1" :foreground "yellow1" :width condensed))))
  '(ido-only-match ((t (:foreground "ForestGreen"))))
  '(ido-subdir ((t (:foreground "red1"))))
- '(info-menu-5 ((t (:underline t))))
  '(info-menu-header ((t (:bold t :weight bold))))
  '(info-node ((t (:bold t :italic t :foreground "yellow"))))
  '(info-node ((t (:italic t :bold t :foreground "white" :slant italic :weight bold))))
-- 
2.34.1


             reply	other threads:[~2021-12-05 17:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-05 17:43 Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-12-05 21:19 ` bug#52303: [PATCH] Remove not defined face info-menu-5 from manoj-dark theme Lars Ingebrigtsen
2021-12-07 10:18   ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-07 20:23     ` Lars Ingebrigtsen
2021-12-08 10:14       ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-09  1:11         ` Lars Ingebrigtsen
2021-12-09 10:36           ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-10  0:35             ` Lars Ingebrigtsen
2021-12-10 10:52               ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2wnkj0wx0.fsf@ego.team \
    --to=bug-gnu-emacs@gnu.org \
    --cc=52303@debbugs.gnu.org \
    --cc=yet@ego.team \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).