unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Y. E. via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 52303@debbugs.gnu.org, yet@ego.team
Subject: bug#52303: [PATCH] Remove not defined face info-menu-5 from manoj-dark theme
Date: Thu, 09 Dec 2021 12:36:30 +0200	[thread overview]
Message-ID: <m2o85qdpzl.fsf@ego.team> (raw)
In-Reply-To: <87a6ha4m5i.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 09 Dec 2021 02:11:53 +0100)

>> The mentioned commit messages seem to contain accidentally duplicated
>> content. For example, see the part of the `git show d3d8a6ccda7' output:
>>
>> Date:   Sun Dec 5 22:18:18 2021 +0100
>>
>>     ; * etc/themes/manoj-dark-theme.el: Remove not defined face info-menu-5
>>
>>     * etc/themes/manoj-dark-theme.el (manoj-dark): Remove reference to
>>     face removed in 2005 (bug#52303).
>>
>> diff --git a/etc/themes/manoj-dark-theme.el b/etc/themes/manoj-dark-theme.el
>>
>>> Is there something that should be changed?
>>
>> My guess was I should have notified you, in case this indeed was a kind
>> of a typo or broken automation. (I didn't see/notice such commit
>> messages in Emacs commit history before.)
>
> Do you mean that the commit message here is wrong?  I still don't quite
> understand what you mean.

Yes, it seemed so to me: the two lines of the commit message saying
basically the same thing. If it's correct, then what purpose does it
serve?

Thanks.





  reply	other threads:[~2021-12-09 10:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-05 17:43 bug#52303: [PATCH] Remove not defined face info-menu-5 from manoj-dark theme Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-05 21:19 ` Lars Ingebrigtsen
2021-12-07 10:18   ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-07 20:23     ` Lars Ingebrigtsen
2021-12-08 10:14       ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-09  1:11         ` Lars Ingebrigtsen
2021-12-09 10:36           ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-12-10  0:35             ` Lars Ingebrigtsen
2021-12-10 10:52               ` Y. E. via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2o85qdpzl.fsf@ego.team \
    --to=bug-gnu-emacs@gnu.org \
    --cc=52303@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=yet@ego.team \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).