From: David Edmondson <dme@dme.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 40280@debbugs.gnu.org, Ted Zlatanov <tzz@lifelogs.com>
Subject: bug#40280: gnus-cloud doesn't do anything useful
Date: Wed, 17 Jun 2020 09:13:29 +0100 [thread overview]
Message-ID: <m2v9jq6rfa.fsf@dme.org> (raw)
In-Reply-To: <87y2omq1q2.fsf@tcd.ie>
On Tuesday, 2020-06-16 at 19:56:05 +01, Basil L. Contovounesios wrote:
>> From a3bdd2219855a72e2ee90de1b6f823c9678a470c Mon Sep 17 00:00:00 2001
>> From: David Edmondson <dme@dme.org>
>> Date: Sat, 28 Mar 2020 19:03:58 +0000
>> Subject: [PATCH] gnus-cloud: Improve cloud sync
>>
>> After replaying a set of actions downloaded by gnus-cloud, persist the
>> highest sequence number seen as the local `gnus-cloud-sequence'
>> number, in order that a future download will not unnecessarily replay
>> previously seen actions and any future uploads from this emacs
>> instance use a higher sequence number than that downloaded.
>>
>> Remove the test on whether individual newsrc entries are older than
>> the current time, as that is always going to be the case.
>
> In the future please follow the formatting guidelines for change log
> messages described in the file CONTRIBUTE.
Understood.
> [...]
>
>> --- a/lisp/gnus/gnus-cloud.el
>> +++ b/lisp/gnus/gnus-cloud.el
>> @@ -480,7 +478,9 @@ Otherwise, returns the Gnus Cloud data chunks."
>> (push (gnus-cloud-parse-chunk) chunks)
>> (forward-line 1))))
>> (if update
>> - (mapcar #'gnus-cloud-update-all chunks)
>> + (progn
>> + (mapcar #'gnus-cloud-update-all chunks)
>> + (setq gnus-cloud-sequence highest-sequence-seen))
>> chunks)))
>
> This change means the result of the mapcar is no longer used or
> returned, giving rise to the following warning:
>
> In gnus-cloud-download-data:
> gnus/gnus-cloud.el:482:12: Warning: ‘mapcar’ called for effect; use ‘mapc’ or
> ‘dolist’ instead
>
> It also makes highest-sequence-seen the return value of
> gnus-cloud-download-data. Is this intended?
No, it's not an intended change and is not desirable. Presumably
replacing `progn' with `prog1' would properly restore the previous
behaviour.
Should I submit a further patch?
dme.
--
J'aurais toujours faim de toi.
next prev parent reply other threads:[~2020-06-17 8:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-29 17:15 bug#40280: gnus-cloud doesn't do anything useful David Edmondson
2020-05-13 10:21 ` Mathieu Othacehe
2020-06-09 16:41 ` Ted Zlatanov
2020-06-16 18:14 ` Ted Zlatanov
2020-06-16 18:56 ` Basil L. Contovounesios
2020-06-17 8:13 ` David Edmondson [this message]
2020-06-17 14:10 ` Ted Zlatanov
2020-06-23 11:52 ` bug#40280: [PATCH] Fix gnus-cloud-download-all-data return value David Edmondson
2020-06-23 13:14 ` Ted Zlatanov
2020-07-19 2:39 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2v9jq6rfa.fsf@dme.org \
--to=dme@dme.org \
--cc=40280@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).